Giter Site home page Giter Site logo

entityframework.apidocs's Introduction

entityframework.apidocs's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

entityframework.apidocs's Issues

incorrect links

From @StillLearnin on July 10, 2018 21:37

Two APIs are marked as obsolete but the links to what we should use instead simply take us to the obsolete APIs


Document Details

โš  Do not edit this section. It is required for docs.microsoft.com โžŸ GitHub issue linking.

Copied from original issue: dotnet/EntityFramework.Docs#827

Not working web link for bulk operations

In the documentation of new bulk methods, the documentation link is not working

This link precisely:

See <see href="https://aka.ms/efcore-docs-bulk-operations">Executing bulk operations with EF Core</see>

Return a 302 Moved Temporarily to https://www.bing.com?ref=aka&shorturl=efcore-docs-bulk-operations which return nothing (Bing don't seems to understand what to do with it and stay at landing page).

Links to documentation like that will be very helpful to maintains code, please fix it and add new ones when possible :)

More internal namespaces to filter

Since now we have API docs for 2.2 & 3.0 also, there are few more internal namespaces we need to filter out.

Microsoft.EntityFrameworkCore.Cosmos.Diagnostics.Internal
Microsoft.EntityFrameworkCore.Cosmos.Infrastructure.Internal
Microsoft.EntityFrameworkCore.Cosmos.Internal
Microsoft.EntityFrameworkCore.Cosmos.Metadata.Conventions.Internal
Microsoft.EntityFrameworkCore.Cosmos.Metadata.Internal
Microsoft.EntityFrameworkCore.Cosmos.Query.Internal
Microsoft.EntityFrameworkCore.Cosmos.Storage.Internal
Microsoft.EntityFrameworkCore.Cosmos.Update.Internal
Microsoft.EntityFrameworkCore.Cosmos.ValueGeneration.Internal
Microsoft.EntityFrameworkCore.Diagnostics.Internal
Microsoft.EntityFrameworkCore.InMemory.Diagnostics.Internal
Microsoft.EntityFrameworkCore.Sqlite.Diagnostics.Internal
Microsoft.EntityFrameworkCore.Sqlite.Query.Internal
Microsoft.EntityFrameworkCore.Sqlite.Storage.ValueConversion.Internal
Microsoft.EntityFrameworkCore.SqlServer.Diagnostics.Internal
Microsoft.EntityFrameworkCore.SqlServer.Storage.ValueConversion.Internal

Move EF6, EF5, and EF4.3.1 API reference to Docs

The API references for the non-core versions of the NuGet package should be part of the .NET API Browser. I talked to @dend and apparently they can be hosted in this repo.

To have complete coverage we discussed having the API reference generated for the following EntityFramework package versions:

Current locations which need to be redirected

Incorrect documentation generated for methods which changed return type

EF Core has API over DbSet<T> - AddAsync which returned task in past. In 3.0 release, we changed it to return ValueTask instead.

Generated xml content does not contain the change.

<Member MemberName="AddAsync">
<MemberSignature Language="C#" Value="public virtual System.Threading.Tasks.Task&lt;Microsoft.EntityFrameworkCore.ChangeTracking.EntityEntry&lt;TEntity&gt;&gt; AddAsync (TEntity entity, System.Threading.CancellationToken cancellationToken = null);" FrameworkAlternate="efcore-1.1;efcore-2.0;efcore-2.1;efcore-2.2" />
<MemberSignature Language="ILAsm" Value=".method public hidebysig newslot virtual instance class System.Threading.Tasks.Task`1&lt;class Microsoft.EntityFrameworkCore.ChangeTracking.EntityEntry`1&lt;!TEntity&gt;&gt; AddAsync(!TEntity entity, valuetype System.Threading.CancellationToken cancellationToken) cil managed" FrameworkAlternate="efcore-1.1;efcore-2.0;efcore-2.1;efcore-2.2" />
<MemberSignature Language="DocId" Value="M:Microsoft.EntityFrameworkCore.DbSet`1.AddAsync(`0,System.Threading.CancellationToken)" FrameworkAlternate="efcore-1.1;efcore-2.0;efcore-2.1;efcore-2.2" />
<MemberSignature Language="F#" Value="abstract member AddAsync : 'Entity * System.Threading.CancellationToken -&gt; System.Threading.Tasks.Task&lt;Microsoft.EntityFrameworkCore.ChangeTracking.EntityEntry&lt;'Entity&gt;&gt;&#xA;override this.AddAsync : 'Entity * System.Threading.CancellationToken -&gt; System.Threading.Tasks.Task&lt;Microsoft.EntityFrameworkCore.ChangeTracking.EntityEntry&lt;'Entity&gt;&gt;" Usage="dbSet.AddAsync (entity, cancellationToken)" FrameworkAlternate="efcore-1.1;efcore-2.0;efcore-2.1;efcore-2.2" />
<MemberType>Method</MemberType>
<AssemblyInfo>
<AssemblyName>Microsoft.EntityFrameworkCore</AssemblyName>
<AssemblyVersion>1.1.0.0</AssemblyVersion>
<AssemblyVersion>1.1.6.0</AssemblyVersion>
<AssemblyVersion>2.0.0.0</AssemblyVersion>
<AssemblyVersion>2.0.3.0</AssemblyVersion>
<AssemblyVersion>2.1.0.0</AssemblyVersion>
<AssemblyVersion>2.1.11.0</AssemblyVersion>
<AssemblyVersion>2.2.6.0</AssemblyVersion>
</AssemblyInfo>
<ReturnValue>
<ReturnType>System.Threading.Tasks.Task&lt;Microsoft.EntityFrameworkCore.ChangeTracking.EntityEntry&lt;TEntity&gt;&gt;</ReturnType>
</ReturnValue>

XML mentions about API returning Task. Also assemblies specified does not include 3.x onward.
So for 3.x we did not generate API in xml for this method.

At the same time,
On doc page, https://docs.microsoft.com/en-us/dotnet/api/microsoft.entityframeworkcore.dbset-1.addasync?view=efcore-3.1#applies-to

It says that it is applicable to 3.0 & 3.1. Not sure why it computed that.

It seems that this is issue somewhere in reference doc generation.

cc: @scottaddie

SaveChangesAsync() doc page

Moved from dotnet/efcore#12751 posted by @erictrigo

Check out: https://docs.microsoft.com/en-us/dotnet/api/microsoft.entityframeworkcore.dbcontext.savechangesasync?view=efcore-2.1

Says signature for SaveChangesAsync is

public virtual System.Threading.Tasks.Task<int> SaveChangesAsync (System.Threading.CancellationToken cancellationToken = null);

If you try overriding SaveChangesAsync using the above example, it'll give you the following error:

image

Using default(CancellationToken) instead of null solves the issue:
public override async Task<int> SaveChangesAsync(CancellationToken cancellationToken = default(CancellationToken))

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.