Better error recovery for unfinished result expressions in pattern matching clauses.

[edgarfgp]

Better error recovery for unfinished result expressions in pattern matching clauses.

[T-Gro]

In the video, this is how strings work - you get them already doubled by the IDE, and you are expected to type in between them to get good recovery.

I do not see how this particular case could be changed throughout lexing, since strings are a legit part of the language.

Do you have a particular idea in which direction to improve this without breaking strings?
Also, why did you delete the double quote instead of typing in-between them?

[T-Gro]

I am not sure if this would be the valid thing to do in all cases though.

[auduchinok]

@edgarfgp Do you remember how you ended up with only one double quote? I expect that they are added and removed together by an IDE during typing.

Unfortunately, in this particular case it looks like expected behavior: F# strings are always multiline, so everything after an unfinished string is considered a part of it, and this was a design choice in the language itself.

[edgarfgp]

@edgarfgp Do you remember how you ended up with only one double quote? I expect that they are added and removed together by an IDE during typing.

@auduchinok . See this GIF

[edgarfgp]

In the video, this is how strings work - you get them already doubled by the IDE, and you are expected to type in between them to get good recovery.

I do not see how this particular case could be changed throughout lexing, since strings are a legit part of the language.

Do you have a particular idea in which direction to improve this without breaking strings? Also, why did you delete the double quote instead of typing in-between them?

@T-Gro I guess what I would expect is that when I delete a single pair of quotes it removes the other, leaving only the failwith ?