Re-consider usage of ProjectSystemProject._gate

[ToddGrun]

Re-consider usage of ProjectSystemProject._gate

[ToddGrun]

@CyrusNajmabadi in case he wishes to add more context or concerns

[CyrusNajmabadi]

Nope. That sums it up nicely. I nominate @jasonmalinowski

[jasonmalinowski]

@ToddGrun Your callstack file is empty, not sure if something went wrong in the upload.

I'm not going to dig into this right now (obviously) but the my question at least reading the title: why was there contention on the project lock? The project lock is expected to be held only when a manipulation to that project is happening, just in case a project system like CPS is trying to update a single project on multiple threads at once. But if CPS isn't doing that then I'd expect zero contention on that lock since it only exists to prevent state corruption if CPS did that -- but we don't really expect that AFAIK. Making CreateBatchScope async feels like it's masking a symptom here...