download/memorystorage

Memory-backed storage object that implements the Web Storage API

memorystorage's Issues

Typings

Does anybody was creating typing for this package?

Add npm install to README

If you can install via npm, you might want to put that information in the readme. If I hadn't happened to go back to your project page to look at the links, I never would have known this was available in npm, and would have moved on to another library. 👍

Incompatible property enumeration and toJSON method

Unfortunately I rely on things like Object.keys(localStorage) to give me the keys of all items stored.

var isolated = new MemoryStorage('my-app');
isolated.setItem("test", JSON.stringify({ key: "value" }));
Object.keys(isolated);  
/// returns ["id", "length", "getItem", "setItem", "removeItem", "key", "clear", "test"]

localStorage.setItem("test", JSON.stringify({ key: "value" }));
Object.keys(localStorage); 
/// returns ["test"] 

It might be related, also that the output of applying JSON.stringify is not compatile to localStorage. It should be

JSON.stringify(localStorage)
// returns {"test":"{\"key\":\"value\"}"}

but instead it is

JSON.stringify(isolated)
// returns {"id":"my-app","length":1,"test":"{\"key\":\"value\"}"}

Perhaps one should define a .toJSON method to fix that behaviour.

With best regards
Semmel

Push v0.9.10 to NPM

Hi,

Looks like v0.9.10 never got pushed to NPM. Would you mind doing that?

Thanks!

Cannot find module memorystorage

Hi, I'm confused about the documentation and different header sizes. I.e. where does 'Installation' end? My troubles could be because of this.

I did:

npm install --save memorystorage

And then in my Angular CLI project ES2015:

import MemoryStorage from 'memorystorage';
....
this.storage = new MemoryStorage();

but my ng serve spits out cannot find module 'memorystorage'. It is there in my npm folder and other packages like moment work.

Also could be a Typescript issue, ... since that't not ES2015.

In my package.json: "memorystorage": "^0.11.0",

Any ideas about this?

Not persistent through page update

Using it in Chrome on Windows 10, MemoryStorage object is reset after each page update.
Should it persist across updates ?

If this allows me to use Session Storage like things across all the browsers, why would I use a switch case? Why not just use MemoryStorage the whole time in all situations?

Convert the library to a ECMAscript module instead of a CommonJS module

Rationale: https://web.dev/commonjs-larger-bundles/

Errors in comments for examples

Some the statements below are not matching the comments. Better to tidy them up?

store.setItem('myString', 'Hello MemoryStorage!');
store.myObject = JSON.stringify({my: 'object'}));
alert(store.getItem('My string')); // alerts 'Hello MemoryStorage!'
alert(store['My string']); // alerts 'Hello MemoryStorage!'
alert(store.length); // alerts '2'
alert(store.key(1)); // alerts 'My object'
store.removeItem('My string');
alert(store.length); // alerts '1'
store.clear();
alert(store.length); // alerts '0'

Invalid exports in package.json

With recent NPM and node updates, for example node 12.18.0 and npm 6.14.4, there is a more strict check on the package.json.

Error [ERR_INVALID_PACKAGE_TARGET] [ERR_INVALID_PACKAGE_TARGET]: Invalid "exports" main target "MemoryStorage" defined in the package config /var/www/restref-site/node_modules/memorystorage/package.json; targets must start with "./"

This prevents the use of this package.