Giter Site home page Giter Site logo

dpdconnect / prestashop17-shipping Goto Github PK

View Code? Open in Web Editor NEW
3.0 7.0 1.0 155 KB

Met deze plugin heb je toegang tot de services van DPD en is het makkelijk om deze kant-en-klare oplossing te integreren met je systeem. Zo kun je labels en retourlabels maken en kiezen voor thuisbezorging of bezorging bij een DPD Pakketpunt.

License: GNU General Public License v3.0

PHP 79.74% Smarty 14.07% CSS 3.40% JavaScript 0.63% Twig 2.15%

prestashop17-shipping's People

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

snatis

prestashop17-shipping's Issues

Improvement: Display the address of the parcelshop in the delivery address in the order summary and on documents (invoices, etc.)

Logically, the delivery address should be replaced by the parcelshop address when the customer chooses a parcelshop delivery. This is not the case while all other modules do this.

Is it possible to plan this improvement? This would also make it possible to know which parcelshop the customer has chosen in the event of a problem (rather than searching the database for the parcelshop ID).

Places to be modified :

  • Order confirmation
  • Order summary
  • Documents (invoice, order, delivery)
  • Backoffice

Bug: Tracking numbers are not displayed in the shipping list

The correction in #7 does not work. The button works and the shipping list is generated but without the tracking numbers

Here are the different screenshots of the problem.

In debug mode:
bug-dpdshippinglist

Without the debug mode:
bug-dpdshippinglist-2

At the same time, it should be possible to translate the shipping list and add the information from the DPD Connect shipping list (name of the depot, signature of the deliverer, etc.)

Improving translations - _dpdLocator1.7 & _adminOrderTabLabels

Version: 1.7.7

I couldn't make a pull request but anyway I think my file needs to be improved (even if it works for me) for older versions perhaps.

There are several translation problems or fields that could not be translated:

_dpdLocator1.7.tpl

  • More information
  • Ship to this parcelshop
  • There is 1 error
  • Please select a parcelshop

_adminOrderTabLabels.tpl

  • Print DPD label
  • Number of parcels
  • Adding a margin-left

Thanks
_dpdLocator1.7.txt
_adminOrderTabLabels.txt

Choose the format of the label (A4/A6)

I noticed that the API takes into account the possibility of defining the format of the label, but the module does not.

Is it possible to add this option?

I explain our problem at the moment, all the labels are printed in A4 and when we generate 2 labels for an order, the second one is printed on the top right. With an A6 printer, we are unable to print the second one.

Gmap classe isn't working

$url = "https://maps.googleapis.com/maps/api/geocode/json?key=" . $gmapsKey . "&address=" . $data . '&sensor=false';

This line should be

 $url = "https://maps.googleapis.com/maps/api/geocode/json?key=" . $gmapsKey . "&components=" . $data . '&sensor=false'; 

Use "components" instead of "address".

Now it's working on our store, the map is shown and we can select a pickup point, but once the parcel shop is selected, it's not saved in the order and the delivery address stays the client's address. The selected carrier is correct tho.

No /vendor/autoload.php error

I tried to install the module in PS 1.7.7.3 but got this:
Compile Error: PrestaShop\PrestaShop\Adapter\Module\ModuleDataProvider::main(): Failed opening required '/home/pournop/www/modules/dpdconnect/vendor/autoload.php' (include_path='/home/pournop/www/vendor/pear/pear_exception:/home/pournop/www/vendor/pear/console_getopt:/home/pournop/www/vendor/pear/pear-core-minimal/src:/home/pournop/www/vendor/pear/archive_tar:.:/usr/local/php7.2/lib/php');
After I delete require_once(PS_MODULE_DIR . 'dpdconnect' . DIRECTORY_SEPARATOR . 'vendor' . DIRECTORY_SEPARATOR . 'autoload.php');
I have error Attempted to load class "DpdHelper" from namespace "DpdConnect\classes".
Did you forget a "use" statement for another namespace?

Use dpdconnect_default_product_weight instead of a default weight of 5 kg

In DpdLabelGenerator.php (line 198-203), you use a default weight of 5 kg when the product weight is 0 kg. 5 kg is too much and causes problems in the generation of the labels.

        foreach ($orderProducts as $orderProduct) {
            if ((float)$orderProduct['product_weight'] <= 0) {
                $orderProduct['product_weight'] = '5.0';
            }
            $weightTotal += ((float)$orderProduct['product_weight'] / 100) * (int)$orderProduct['product_quantity'];
        }

Why don't you use Configuration::get('dpdconnect_default_product_weight')?

It is used in line 356 - 358

            if ($weight === 0) {
                $weight = Configuration::get('dpdconnect_default_product_weight');
            }

Bug: Possibility to order via DPD Parcelshop without selecting a parcelshop

A major bug to be fixed.

It is possible to order and have your order delivered to a parcelshop without selecting the parcelshop. As a result, you get a label in DPD Classic (or Home) when the customer has paid for the parcelshop.

So money is lost.

Step to reproduce the bug (there may be other cases!):

  • Disable javascript and select "DPD ParcelShop".
  • Continue
  • Pay (if problem to pay, allow again the javascript)

I have tried with other carriers (other than DPD), some refuse to validate the delivery step if javascript is not allowed.

1.3 : dpdconnect_url is not defined

You are using your new API for parcelshop integration, but in some cases the dpdconnect_url is not defined because it is an optional field, which is a problem :

In DpdCheckoutDeliveryStep.php :
'dpdParcelshopMapUrl' => Configuration::get('dpdconnect_url') . '/parcelshop/map/js',

dpdconnect-db

dpdconnect-bo

dpdconnect-console

Permissions to generate, download and delete labels

In version 1.2.3 (not tested on 1.3.1), it is impossible to generate, delete, upload labels if all permissions are not granted in "Advanced Parameters > Team > Permissions".
dpdlabel

We want to be able to create specific permissions, especially for logisticians, so that they cannot access general settings, stats, etc.

Currently this is not possible, we have to grant permissions to the whole back office so that they can create and generate DPD labels.

Really problematic, they would need to be able to access the AdminDpdLabels controller via the DPD module permissions

ShippingList in 1.7.7 no longer works

Hello,

Is it possible to solve this problem? It is no longer possible to override the AdminOrdersController, hence the bug.
21-05-2021 16-42-56

Thank you for the solution!

empty order page

when customer is clicking on PROCEED TO CHECKOUT button in the Cart(.../en/cart?action=show) - empty page appears with: HTTP ERROR 500

Display the real logo of the final carrier for DPD Shop (depending on the local name of the partner)

After several years of e-commerce presence, we can say that one thing that is really important for the customer is who delivers.
In some countries, DPD group uses a very specific name (BRT, Seur, PostNord, Chronopost, ...) and different. Most people do not really know DPD but this local carrier

In version 1.2 of the module, we have added a condition in _dpdLocator1.7.tpl to display the right logo on the map depending on the country of delivery.

{if $page.body_classes|classnames|strstr:"country-fr"}
	{assign var="imgPickup" value="chronopost.png"}
{elseif $page.body_classes|classnames|strstr:"country-es"}
	{assign var="imgPickup" value="seur.png"}
{elseif $page.body_classes|classnames|strstr:"country-it"}
	{assign var="imgPickup" value="brt.png"}
{elseif $page.body_classes|classnames|strstr:"country-dk" || $page.body_classes|classnames|strstr:"country-fi" || $page.body_classes|classnames|strstr:"country-se"}
	{assign var="imgPickup" value="postnord.png"}
{else}
	{assign var="imgPickup" value="pickup.png"}
{/if}

dpd-parcelshop

This is a real satisfaction because in Italy, the customer knows BRT and not DPD.

In version 1.3 of the module, since you use your API, this modification does not seem possible anymore. It must be done directly within your API.

Do you think this could be done in a future version? Do you see, as I do, the interest of this from a customer satisfaction point of view?

PS: it would be great if in addition to the logos, you also adapted the colours (like background-color for a.parcelshoplink in CSS)

Unable to install

Hello,
When a drop the dpdconnect.zip in the modal, that's make an error...
image
image
image

Someone can help me please ?

thanks

No translation of your API for parcelshop

Thank you for completely rewriting the Parcelshop functionality, but in this case, your version 1.3 module is unusable because it cannot be translated.

We have French, Dutch, English, Spanish and German speaking customers and we end up with a mixture of French, English and Dutch. (see attached screenshots) and even some terms that are poorly translated or look like "selectParcelshop" code.

Your API should also take into account the language of the client!

parcelshop
parcelshop-2
parcelshop-3

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.