CI: open_pr fails when a nominee file has been deleted

[dpgalliance]

CI: open_pr fails when a nominee file has been deleted

[DivyanshiSingh]

@lacabra May I know the status of this issue? I would like to work on this issue.

[lacabra]

Thanks @DivyanshiSingh, this is issue is valid and current. The only caveat is that it probably the hardest of all the ones we have open because it interfaces directly with the Continuous Integration (CI) environment of GitHub Actions. In order to tackle this, you may need to fork this repo and the destination repo, and test that you accomplish the right behaviour on your own repos (and point us to a commit that proves it) before we can proceed to merge it. Having said this, it would be an enormous help to fix this. Thanks! 🙏

Please ask as many questions as you need here

[DivyanshiSingh]

ok sure
Thank you :)

[DivyanshiSingh]

Hey, @lacabra I would like to ask whats the destination repo and when you mention "CI should account for the deleted file, and push it to delete it in the other repo as well", what do you mean by the other repo here? Where can I see the failed build?

[lacabra]

Absolutely. This is how it works (providing additional info beyond your question, in case it helps):

1. The script that runs is main.yml, and the relevant section is open_pr starting on L44, which in turn, on L63 calls scripts/open_pr.js
2. From L6 and L7 of scripts/open_pr.js you will see that the destination repo is publicgoods/products

An example of a failed built is linked in the description of this issue, at the very top: here

[DivyanshiSingh]

@lacabra thanks for this explanation. It was a great help and I understood it, I will update you with my changes.

[DivyanshiSingh]

@lacabra I have implemented my solution. You can have a look at the build here and the PR's are generated on the destination repo here
The changes in the open_pr.js file can be viewed here

[DivyanshiSingh]

Any update @lacabra