dr0nee/capstone

capstone's Issues

`head`

https://github.com/DR0nee/Capstone/blob/master/index.html#L3-L10

Make sure to include the viewport meta tag so that you can properly control the viewport's size and scale.

This is a must for any mobile-optimized site.

<meta name="viewport" content="width=device-width, initial-scale=1.0">

Semantic markup

https://github.com/DR0nee/Capstone/blob/master/index.html#L12-L35

Great job making your markup more semantic by using tags like header, nav, and footer. 👍

See if you can add some other easy semantic tags, like main and section. This is much better than relying constantly on div tags, and can make your code much easier to read and reason about.

Keep in mind that you shouldn't use redundant class names. For example, a footer tag probably doesn't need a class of footer. You can just refer to it by the tag in your CSS.

`img alt`

https://github.com/DR0nee/Capstone/blob/master/index.html#L15

Nice job giving all of your img tags an alt attribute with a value that adequately describes the image, just in case your website is not able to load it. 👍

Doing so will help improve the accessibility of your website, which might be accessed by visually impaired users on e-readers or other devices that might deliberately neglect images-- as well as any other time that your website is just unable to render images.

Keep in mind that if screen readers are to read these alt values... You should provide something that can actually be read usefully. Use "Colmar Logo" instead of "colmarlogo". Use "Guy reading a book." instead of "guyreadingbook".

Mobile responsiveness

You nailed the desktop version of the site as well as the mobile version.

On top of that, you've ensured that your website resizes gracefully across all screen sizes, which ensures a great experience for your users.

Great job! 👍

Including assets

https://github.com/DR0nee/Capstone/blob/master/index.html#L15

Nice job including your website's assets (in this case images) in your project and providing a relative file path to them in your img tags. 👍

It's always better to provide static assets up front instead of depending on external URLs that could fail or otherwise become unavailable.

Summary

Satisfactory 👍

You've done a great job writing a fully mobile responsive website!

Just for practice you should see if you can make some nice mobile versions of your previous sites. There's no reason you shouldn't leave this program without a full portfolio mobile responsive websites!

Hover styling

Excellent job applying all of the hover effects throughout your website. 👍

For example, styling the "Fisma" and "Our Guest Lecture" sections so that a dark background background color is applied, not statically, but rather when the user hovers over the individual link. This gives the impression that element is "clickable".

Even if these links don't actually lead anywhere, it's important to have this sense of interaction for a modern site.