drbirbdev/stardewvalley

Mods for StardewValley created by drbirbdev

stardewvalley's Issues

Error calling GetApi method

This mod throws an error when the game starts (see example log):

[GameboyArcade] This mod failed in the GameLoop.GameLaunched event. Technical details:
System.Reflection.AmbiguousMatchException: Ambiguous match found.
   at System.DefaultBinder.FindMostDerivedNewSlotMeth(MethodBase[] match, Int32 cMatches)
   at System.RuntimeType.GetMethodImplCommon(String name, Int32 genericParameterCount, BindingFlags bindingAttr, Binder binder, CallingConventions callConv, Type[] types, ParameterModifier[] modifiers)
   at System.RuntimeType.GetMethodImpl(String name, BindingFlags bindingAttr, Binder binder, CallingConventions callConv, Type[] types, ParameterModifier[] modifiers)
   at System.Type.GetMethod(String name, BindingFlags bindingAttr)
   at BirbShared.Mod.ModClassParser.<>c__DisplayClass0_2.<ParseMod>b__1(Object sender, GameLaunchedEventArgs e) in C:\Users\russe\source\repos\StardewValley\BirbShared\Mod\ModClassParser.cs:line 37
   at StardewModdingAPI.Framework.Events.ManagedEvent`1.Raise(TEventArgs args) in SMAPI\Framework\Events\ManagedEvent.cs:line 111

The mod calls mod.Helper.ModRegistry.GetType().GetMethod("GetApi"), but there are two versions of that method:

public object? GetApi(string uniqueID);
public TInterface? GetApi<TInterface>(string uniqueID) where TInterface : class;

You'll need to specify which one you need to avoid the error. For example:

mod.Helper.ModRegistry.GetType().GetMethod"GetApi", genericParameterCount: 1, new[] { typeof(string) })

RSV code is always firing false.

public static bool Prepare() { return ModEntry.RSVLoaded; }

This always seems to be returning false. I noticed it when I had EXP bars and wasn't gaining exp in ridgeside... and villagers weren't getting angry at me.

Downloading the github here and removing that code, seemed to fix it. That said, removing that without having ridgeside village installed might cause issues.