dreamofabear/amp-pwa

A sample React PWA with AMP content.

amp-pwa's Issues

Optimize images

Optimize the following images to reduce their size by 20MiB (79% reduction).

Compressing https://choumx.github.io/amp-pwa/content/hero/6.jpeg could save 1.3MiB (83% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/5.jpeg could save 1.1MiB (82% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/20.jpeg could save 1MiB (78% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/15.jpeg could save 984.3KiB (77% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/22.jpeg could save 982.7KiB (86% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/7.jpeg could save 912.9KiB (77% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/27.jpeg could save 875.1KiB (77% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/19.jpeg could save 861.2KiB (86% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/21.jpeg could save 852.9KiB (91% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/1.jpeg could save 796.4KiB (80% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/17.jpeg could save 773.7KiB (89% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/12.jpeg could save 744.9KiB (74% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/16.jpeg could save 744.2KiB (74% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/28.jpeg could save 740.4KiB (90% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/29.jpeg could save 686KiB (73% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/2.jpeg could save 655.8KiB (75% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/9.jpeg could save 644.2KiB (80% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/24.jpeg could save 621.4KiB (79% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/18.jpeg could save 582.1KiB (77% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/3.jpeg could save 543.2KiB (73% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/23.jpeg could save 530.1KiB (75% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/13.jpeg could save 523.5KiB (77% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/14.jpeg could save 461.1KiB (71% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/11.jpeg could save 422.3KiB (65% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/25.jpeg could save 406.4KiB (75% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/26.jpeg could save 398.2KiB (81% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/8.jpeg could save 392.7KiB (69% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/10.jpeg could save 359.5KiB (81% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/4.jpeg could save 301.8KiB (72% reduction).
Compressing https://choumx.github.io/amp-pwa/content/hero/30.jpeg could save 232.5KiB (67% reduction).

Improve Lighthouse score (74/100)

• Paste https://gist.github.com/choumx/595094cb5da0876d7853896ae263b1bd into https://googlechrome.github.io/lighthouse/viewer/ to view report.

Errors in shadow doc with amp-carousel

Uncaught Error: No ampdoc found for [object HTMLElement]
    at sa (https://cdn.ampproject.org/shadow-v0.js:9:358)
    at qa.f.createError (https://cdn.ampproject.org/shadow-v0.js:6:36)
    at tf.getAmpDoc (https://cdn.ampproject.org/shadow-v0.js:134:512)
    at HTMLElement.Wf.b.connectedCallback (https://cdn.ampproject.org/shadow-v0.js:166:442)
    at https://cdn.ampproject.org/rtv/001493142602549/v0/amp-carousel-0.1.js:22:318
    at Array.forEach (native)
    at Q.push.f.f.buildSlides (https://cdn.ampproject.org/rtv/001493142602549/v0/amp-carousel-0.1.js:22:142)
    at Q.push.f.f.buildCarousel (https://cdn.ampproject.org/rtv/001493142602549/v0/amp-carousel-0.1.js:16:326)
    at Q.push.f.f.buildCallback (https://cdn.ampproject.org/rtv/001493142602549/v0/amp-carousel-0.1.js:11:465)
    at HTMLElement.Wf.b.build (https://cdn.ampproject.org/shadow-v0.js:161:514)

custom-element.js:1052 Uncaught TypeError: Cannot read property 'remove' of null
    at HTMLElement.Wf.b.disconnectedCallback (https://cdn.ampproject.org/shadow-v0.js:173:21)
    at https://cdn.ampproject.org/rtv/001493142602549/v0/amp-carousel-0.1.js:22:318
    at Array.forEach (native)
    at Q.push.f.f.buildSlides (https://cdn.ampproject.org/rtv/001493142602549/v0/amp-carousel-0.1.js:22:142)
    at Q.push.f.f.buildCarousel (https://cdn.ampproject.org/rtv/001493142602549/v0/amp-carousel-0.1.js:16:326)
    at Q.push.f.f.buildCallback (https://cdn.ampproject.org/rtv/001493142602549/v0/amp-carousel-0.1.js:11:465)
    at HTMLElement.Wf.b.build (https://cdn.ampproject.org/shadow-v0.js:161:514)
    at Wg.f.build (https://cdn.ampproject.org/shadow-v0.js:233:151)
    at fh (https://cdn.ampproject.org/shadow-v0.js:254:244)
    at jh (https://cdn.ampproject.org/shadow-v0.js:253:453)

Is Google identify the page is an AMP page

From the documentation, seems Google identify the pages by the <html amp>
Can the google search engine identify that PWA page is AMP and showing the "AMP" tag next to serach result like this?

Related links are broken

A (recent?) change in AMP Shadow API causes errors when a shadow root node is reused for multiple docs.

Use shell URL rewriting for Safari

https://github.com/ampproject/amphtml/blob/master/extensions/amp-install-serviceworker/amp-install-serviceworker.md#shell-url-rewrite

Missing Images in build folder

Hi,

I am having issue with images not showing up. It seems like issues with creating build folder that does not include images from content/hero folder.

Let me know if you will be able to help me with that?

Cheers,

crashes when refreshing an article (by swipe down)

When refreshing an articles on an installed pwa:

Getting nasty error which cannot go back:

Upgrade create-react-app

https://facebook.github.io/react/blog/2017/05/18/whats-new-in-create-react-app.html