Giter Site home page Giter Site logo

Comments (12)

DrKain avatar DrKain commented on May 29, 2024 1

The updated rule should now return the correct URL, please let me know if you have any more issues with it

from tidy-url.

EpokK avatar EpokK commented on May 29, 2024 1

Thanks @DrKain for fixing this so quickly.

from tidy-url.

LeGrosSancho avatar LeGrosSancho commented on May 29, 2024 1

Thanks for the revert. 🙏
Indeed looks like the link was cleaned correctly on your side, I think it's a misunderstanding with the report we received which wasn't clear... I will ask for some more details

Sorry for the inconvenience, but thanks a lot for your reactiveness.

from tidy-url.

DrKain avatar DrKain commented on May 29, 2024 1

I'm going to give this 3 more days before closing. As far as I can see there is no issue with this package, so I'll wait a few more days before closing. If you or someone else wants to chime in here I'm more than happy to look into it, but with the lack of information there's really not much I can do here.

from tidy-url.

LeGrosSancho avatar LeGrosSancho commented on May 29, 2024 1

Hey sorry I completely missed the notifications 😬
Indeed, we did not received any updates on this report on our side, so I think we can close it completely.
Thanks, and again sorry for the inconvenience 😕

from tidy-url.

DrKain avatar DrKain commented on May 29, 2024

Thanks for reporting, I'll look into this shortly.
The removed array would contain a list of parameters that have been removed, but in this case the issue is with the amp rule

from tidy-url.

LeGrosSancho avatar LeGrosSancho commented on May 29, 2024

Oh okay I see thanks a lot!
So if I need to check whether the link has changed or not, do you suggest to check difference or reduction (or something else)?

from tidy-url.

DrKain avatar DrKain commented on May 29, 2024

If I remember right: difference is the number of characters removed and reduction is a percentage, they were originally meant for debugging.
The best way to check if the link has changed: data.url !== data.info.original

from tidy-url.

LeGrosSancho avatar LeGrosSancho commented on May 29, 2024

Okay I see, I will do it that way then, thanks a lot once again 🙏

from tidy-url.

LeGrosSancho avatar LeGrosSancho commented on May 29, 2024

Hey, I'm sorry, I messed up in the original report, I inverted current and expected...
We're expecting this instead:

URL before cleaning:

Current result when cleaning:

Expected outcome:

Could you have a look when you have some time please ? 😬

from tidy-url.

DrKain avatar DrKain commented on May 29, 2024

I might be missing something here, but didn't the old rule return the expected outcome?

Input: https://m7267kld.r.us-west-2.awstrack.me/L0/https:%2F%2Fauth.pathapplication.com%2Fprovider%2Fchange-password/1/SOME_RANDOM_ID_1/SOME_RANDOM_ID_2
Clean: https://auth.pathapplication.com/provider/change-password/1/SOME_RANDOM_ID_1/SOME_RANDOM_ID_2
New Host: true
35.86% smaller (52 characters)

from tidy-url.

DrKain avatar DrKain commented on May 29, 2024

Hi @LeGrosSancho, any update on this? Is it safe to close?

from tidy-url.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.