Comments (12)
The updated rule should now return the correct URL, please let me know if you have any more issues with it
from tidy-url.
Thanks @DrKain for fixing this so quickly.
from tidy-url.
Thanks for the revert. 🙏
Indeed looks like the link was cleaned correctly on your side, I think it's a misunderstanding with the report we received which wasn't clear... I will ask for some more details
Sorry for the inconvenience, but thanks a lot for your reactiveness.
from tidy-url.
I'm going to give this 3 more days before closing. As far as I can see there is no issue with this package, so I'll wait a few more days before closing. If you or someone else wants to chime in here I'm more than happy to look into it, but with the lack of information there's really not much I can do here.
from tidy-url.
Hey sorry I completely missed the notifications 😬
Indeed, we did not received any updates on this report on our side, so I think we can close it completely.
Thanks, and again sorry for the inconvenience 😕
from tidy-url.
Thanks for reporting, I'll look into this shortly.
The removed
array would contain a list of parameters that have been removed, but in this case the issue is with the amp rule
from tidy-url.
Oh okay I see thanks a lot!
So if I need to check whether the link has changed or not, do you suggest to check difference
or reduction
(or something else)?
from tidy-url.
If I remember right: difference
is the number of characters removed and reduction
is a percentage, they were originally meant for debugging.
The best way to check if the link has changed: data.url !== data.info.original
from tidy-url.
Okay I see, I will do it that way then, thanks a lot once again 🙏
from tidy-url.
Hey, I'm sorry, I messed up in the original report, I inverted current and expected...
We're expecting this instead:
URL before cleaning:
Current result when cleaning:
Expected outcome:
Could you have a look when you have some time please ? 😬
from tidy-url.
I might be missing something here, but didn't the old rule return the expected outcome?
Input: https://m7267kld.r.us-west-2.awstrack.me/L0/https:%2F%2Fauth.pathapplication.com%2Fprovider%2Fchange-password/1/SOME_RANDOM_ID_1/SOME_RANDOM_ID_2
Clean: https://auth.pathapplication.com/provider/change-password/1/SOME_RANDOM_ID_1/SOME_RANDOM_ID_2
New Host: true
35.86% smaller (52 characters)
from tidy-url.
Hi @LeGrosSancho, any update on this? Is it safe to close?
from tidy-url.
Related Issues (20)
- Update: youtube.com
- Website: manor.ch HOT 1
- Website: ojrq.net HOT 1
- Website: knowyourmeme.com
- Website: wfaa.com
- Website: cbsnews.com
- Website: jdt8.net HOT 1
- Bug: No utm tracker cleaned when allow_amp rule is set to true HOT 6
- Update: reddit.com
- Update: open.spotify.com
- Website: adclick.g.doubleclick.net HOT 1
- Request: Expand decode rule HOT 1
- Request: Move handlers into their own functions HOT 8
- Request: Test runner
- Other: Thoughts on what justifies as an unwanted redirect HOT 2
- Website: patchbot.io
- Bug: InvalidCharacterError: String contains an invalid character
- Broken: google.com HOT 1
- Website: vi-control.net HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tidy-url.