drone/go.stripe

a simple Credit Card processing library for Go using the Stripe API

go.stripe's Issues

Missing "data" field for Invoice.Data.Object.Lines type ?

Hi,

I think i spotted an error while using the webhooks. It returns an object which contains "lines". But it contains json field called "data" which is not present in the structure :(

Can you confirm it ?

JSON
Webhook payment_succeeded from stripe

  "period_start": 1406634003,
      "period_end": 1406634003,
      "lines": {
        "data": [       // <==== HERE
          {
            "id": "sub_4UY3vxOFvXGlQm",
            "object": "line_item",
            "type": "subscription",

Struct
https://github.com/drone/go.stripe/blob/master/invoice.go

....
    Discount        *Discount     `json:"discount"`
    Lines           *InvoiceLines `json:"lines"`
    StartingBalance int64         `json:"starting_balance"`
    EndingBalance   Int64         `json:"ending_balance"`
    NextPayment     Int64         `json:"next_payment_attempt"`
    Livemode        bool          `json:"livemode"`
}

// InvoiceLines represents an individual line items that is part of an invoice.
type InvoiceLines struct {
    InvoiceItems  []*InvoiceItem      `json:"invoiceitems"`
    Prorations    []*InvoiceItem      `json:"prorations"`
    Subscriptions []*SubscriptionItem `json:"subscriptions"`
}

type SubscriptionItem struct {
    Amount int64   `json:"amount"`
    Period *Period `json:"period"`
    Plan   *Plan   `json:"plan"`
}
....

Delete return types

Delete functions should return a special struct, that use the following format:

{
  "deleted": true,
  "id": "cus_3Sndou3HZmZVOW"
}

Appengine Compatibility

I receive the following error creating a charge using stripe.Charges.Create() :

Post https://_SECRET_KEY[email protected]/v1/charges: http.DefaultTransport and http.DefaultClient are not available in App Engine. See https://developers.google.com/appengine/docs/go/urlfetch/overview

Unit Tests, Invoice Items

Need unit tests for invoice items

Status of the repo?

Hi there,

I'm just checking if the library is still being maintained, and if so, if we should use bradrydzewski's version or drone.io's version.

Thanks!

Implement HandlerFunc for Events

Implement an http.HandlerFunc so that a developer can easily handle Stripe Events.

i'm thinking something like this

type EventCallback func(Event);

func HandleEvent(callback EventCallback) {
    return func(req *http.Request, resp http.Response) {
         // parse the event in the incoming request
         event, err := json.Unmarshall(...)

         // return a 202 so that stripe knows we go it
         w.WriteHeader(http.StatusOK)

         // invoke EventCallback function
         go callback(event)
    }
}

Unit Tests, Invoices

Need unit tests for invoices

Create Customer using Card Token

Per the Stripe API docs, we should be able to substitute a Token in place of any API call that sends an actual Credit Card. Need to implement this functionality, specifically in the Customers.Create and Customer.Update API implementations

Two incorrect checks in plan_test.go

Two checks in plan_test.go compare a value with itself, instead of with the expected value:

/src/github.com/drone/go.stripe/plan_test.go:53:5: identical expressions on the left and right side of the '!=' operator
/src/github.com/drone/go.stripe/plan_test.go:98:5: identical expressions on the left and right side of the '!=' operator

Update Subscription, Attach New Card

When updating a subscription, the API gives the ability to attach a new Credit Card (or Card Token). This feature is currently not implemented.

Test Coverage for Subscriptions

Currently the Subscriptions API does not include any Unit Tests

Cancel Subscription, At Period End

When cancelling a subscription need to enable the at_parameter_end flag:

If you set the at_parameter_end parameter to true, the subscription will remain active until the end of the period, at which point it will be cancelled and not renewed.

Test Coverage for Tokens

Write unit tests for the Tokens API

No stripe.Cards?

In stripe.go there's a convenience constructor for most ...Client types, but there isn't one that says:

Cards = new(CardClient)

Any reason for that? I can submit a pull request fix if not.

Cannot update DefaultCard using CustomerParams

I can read the default_card fine by retrieving a customer, but cannot update it even though that is legal: https://stripe.com/docs/api#update_customer. Fix coming.