Giter Site home page Giter Site logo

Comments (7)

baltom avatar baltom commented on June 12, 2024 1

@idc77 Had to revert your commit/pr as it dosen't build see: https://rollupjs.org/configuration-options/#output-exports

Also note that it KeycloakSymbol is exported here https://github.com/dsb-norge/vue-keycloak-js/blob/main/src/index.ts#L42

import VueKeyCloak from '@dsb-norge/vue-keycloak-js'
const symbol = VueKeyCloak.KeycloakSymbol

from vue-keycloak-js.

idc77 avatar idc77 commented on June 12, 2024

@chrisnruud @baltom @josteitv
You probably don't want to be pinged but this is an easy change which would make away with the getCurrentInstance() requirement.

from vue-keycloak-js.

idc77 avatar idc77 commented on June 12, 2024

Ok. After MUCH experimentation the simplest solution is to just add export to the KeycloakSymbol declaration.

old

const KeycloakSymbol = Symbol('keycloak')

new

export const KeycloakSymbol = Symbol('keycloak')

And with this one can just

import {KeycloakSymbol} from "@dsb-norge/vue-keycloak-js";

// ... setup() 
    const kc = inject(KeycloakSymbol)

Please just make this small change.

Meanwhile I've copy/pasted the change to
https://www.npmjs.com/package/dalu-vue3-keycloak
https://code.icod.de/dalu/vue3-keycloak

from vue-keycloak-js.

chrisnruud avatar chrisnruud commented on June 12, 2024

Thank you for the ping. We will try to take a look at the earliest convenience. Sorry for not responding in a timely manner :)

from vue-keycloak-js.

idc77 avatar idc77 commented on June 12, 2024

Meanwhile 2 weeks have passed and nothing happened. Writing 7 characters is very time consuming.
Come on already.

from vue-keycloak-js.

chrisnruud avatar chrisnruud commented on June 12, 2024

@idc77 thank you for the PR!

from vue-keycloak-js.

idc77 avatar idc77 commented on June 12, 2024

wow, so much trouble over nothing.
Sorry to have bothered you.

from vue-keycloak-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.