dsccommunity/xwordpress

xwordpress's Issues

MSFT_xWordPressSite is failing basic schema validation tests with Test-xDscResource

• Test-ParameterMetaDataIsDscResourceProperty : The ValidateSet tag has a different number of items between the schema and module.
• Test-SetHasExactlyAllNonReadProperties : The functions Set-TargetResource and Test-TargetResource must take all Key, Required and Write properties. There is an issue with the
  parameter Ensure defined in the schema.

Fails on the common test due to it's a composite resource

Fails on the common test, due to that the test framework does not support composite resource at the moment.

    Context DscResources\xIisWordPressSite\xIisWordPressSite.Schema.psm1
There are parse errors in C:\projects\xwordpress\DscResources\xIisWordPressSite\xIisWordPressSite.Schema.psm1:
Extent          : xWebSite
ErrorId         : ResourceNotDefined
Message         : Undefined DSC resource 'xWebSite'. Use Import-DSCResource to import the resource.
IncompleteInput : False
Extent          : xWebSite
ErrorId         : ResourceNotDefined
Message         : Undefined DSC resource 'xWebSite'. Use Import-DSCResource to import the resource.
IncompleteInput : False
Extent          : xRemoteFile
ErrorId         : ResourceNotDefined
Message         : Undefined DSC resource 'xRemoteFile'. Use Import-DSCResource to import the resource.
IncompleteInput : False
Extent          : xArchive
ErrorId         : ResourceNotDefined
Message         : Undefined DSC resource 'xArchive'. Use Import-DSCResource to import the resource.
IncompleteInput : False
      [-] Module file 'DscResources\xIisWordPressSite\xIisWordPressSite.Schema.psm1' should not contain parse errors 81ms
        Expected $false, but got $true.
        248:                 $containsParseErrors | Should -Be $false
        at <ScriptBlock>, C:\projects\xwordpress\DscResource.Tests\Meta.Tests.ps1: line 248

BLOCKER: PSSA Errors Need to Be Fixed

Errors from PS script analyzer are causing the tests to fail like this.
This resource module cannot be released until these errors are fixed or suppressed and the tests are passing.

xIisWordPressSite is not discoverable

'Get-DscResource -name xIisWordPressSite' doesn't discover the module.
Files associated with the resource are not formatted correctly.

xWordPress: Converting to new CI pipeline

Work need to be done to convert this repository to use the new CI pipeline.

https://dsccommunity.org/blog/convert-a-module-for-continuous-delivery/

xPhp resource name needs to be updated to xPhpProvision php in Wordpress sample configuration

When one installs the modules that are required by Wordpress configuration from powershell gallery, the resource name for xPhp has changed in the latest version of xPhp module , and the new name is xPhpProvision. The below configuration resource block needs to be updated to refer to the new resource:
Old version:
xPhp php
{
InstallMySqlExt = $true
PackageFolder = $Node.PackageFolder
DownloadUri = $Node.Php.DownloadURI
DestinationPath = $Node.Php.Path
ConfigurationPath = $Node.Php.TemplatePath
Vc2012RedistDownloadUri = $Node.Php.Vc2012RedistUri
}

Proposed version:
xPhpProvision php
{
InstallMySqlExt = $true
PackageFolder = $Node.PackageFolder
DownloadUri = $Node.Php.DownloadURI
DestinationPath = $Node.Php.Path
ConfigurationPath = $Node.Php.TemplatePath
Vc2012RedistDownloadUri = $Node.Php.Vc2012RedistUri
}

For the repro have a VM with latest WMF 5.0 and run the following script:

This Script installs the required modules for the WordPress Sample

It uses the PowerShell Resource Gallery, see https://msconfiggallery.cloudapp.net/

This requires WMF 5. If you don't have WMF 5, Please install the modules manually.

Write-Host "Installing required modules..."
Install-Module xWebAdministration -MinimumVersion 1.3.2 -Force
Install-Module xPSDesiredStateConfiguration -MinimumVersion 3.0.1 -Force
Install-Module xMySql -MinimumVersion 1.0 -Force
Install-Module xWordPress -MinimumVersion 1.0 -Force
Install-Module xPhp -MinimumVersion 1.0.1 -Force

xMySqlProvision - changed members in mySql 2.0

In the updated 2.0 version of xMySql, 'ServiceName' is no longer needed and there are a couple new required members that need to be added in addition. (SingleNodeEndToEndWordPress.ps1, line 109)