dss-web/ninjaforms-uploads-azure

Add support for offloading Ninja Forms Uploads to the Microsoft Azure cloud.

ninjaforms-uploads-azure's Issues

Ensure classes not covered by autoloaders have no local-relationship

Currently there are calls to use NF_FU_* classes (for example use NF_FU_Fields_Upload which is being extended by the plugins own Fields_Upload class), but since the code is namespaced, these are looked for within the currently active namespace, where the classes do not exist since they belong to a different plugin.

Classes that are not explicitly covered by the plugins autoloader need to be declared as part of the global namespace (prefixed with \), since the autoloader can not be built on each site that uses the plugin, and therefore has no guarantee that it will find the class otherwise, leading to fatal errors.

Clean up hardcoded keys

There are currently hardcoded, but commented out, connection strings. These should not be here, as they contain API keys, if even for a test environment.

Implement more user friendly account-definitions

Currently the way to create a connection to Azure requires a rather long handcrafted string which may be easy to get wrong.

Instead I propose we change DEKODE_NINJAFORMS_AZURE_CONNECTION_STRING to a set of strings, preferably with a naming convention that suits other Azure plugins that exists in the WP ecosystem.

Let's consider using these:

• MICROSOFT_AZURE_ACCOUNT_NAME
• MICROSOFT_AZURE_ACCOUNT_KEY
• MICROSOFT_AZURE_CONTAINER
• MICROSOFT_AZURE_CNAME

The MICROSOFT_AZURE_CNAME entry may not necessarily be needed here (it is used to represent a site-specific URL that is an alias for the default Microsoft blobstorage URL, so it looks nicer and more familiar to end users).

Pass coding standards checks

Currently the plugin is not fully compliant with the coding standards, as defined by composer run lint.

Document local test setups

Currently there's a short text identifying a test-string to use for a local test, we should probably document what software is needed for local testing as well (for example the local Azure Blob Storage test environment).