dthies/moodle-atto_cloze

An editor plugin to help create embedded answer questions

moodle-atto_cloze's Issues

Initial Atto cloze editor plugin test results and suggestions: 1 installation instructions

These are the Initial Atto cloze editor plugin tests and suggestions:

Please change Readme.txt:

"To install add to the Atto editor plugins directory and visit notifications to update database."

to an easier to follow :
"To install, please add to '... -> server-> moodle -> lib -> editor -> atto -> plugins ' directory and visit notifications to update database."

sporadically next cloze answers are copied from previus ones

It happens from time to time, answers made to previous questions are copied when creating news ones, instead of being empty.

As an example for replicating this bug try to copy this:

>{1:SHORTANSWER:~%100%enable}
# {1:SHORTANSWER:~%100%conf~%100%configure} term
(config)#vlan 2
(config-vlan)#name marketing

and then add a new cloze shortanswer selecting the word "term" in the second line.

NOTE: my current version is from github (2016111500)

Another usability addition borrowed from the TinyMCE version.

Oops... I added a blank paragraph...

Deprcated string

The string [grade, core] appears deprecated in 3.11 and needs to be removed. Ideally all of the core strings should be copied to the plugin.

Answer form is difficult to read

The alignment on the answer form is difficult to read. Moving the navigation to the right side will allow the answer and feedback text boxes to be aligned.

Moodle documentation for this plugin

At https://docs.moodle.org/31/en/Cloze_editor_for_Atto .
...Work in progress...
Please feel free to add or change as needed.

Moodle 4 version ?

Please read https://moodle.org/mod/forum/discuss.php?d=432462#p1740065

The duplicating function submits form

The handler for the duplicate button appears to have been disabled somewhere. It needs to be reenabled.

Create tests for reading existing question

Need to test the subquestion parsing with behat.

No need to include version.php to get the Moodle version

It seems that atto_cloze_params_for_js() includes the main version.php to get access to the moodle core version. Note that you have that value available via $CFG->version or via more readable $CFG->branch

Default marks for additional answers should set properly.

Currently all new answers default to 0% as the grade. Short answer and numerical types should be 100%. Multichoice needs a rational value to be given.

Add/delete buttons not focusing after operation

There are coding error in calculating the text box to focus on that causes exceptions.

When using a multichoice option, if the user inserts many options, the screen grows taller, but without scroll bars the user can not click on the 'Insert' button.

When using a multichoice option, if the user inserts many options, the screen grows taller, but without scroll bars the user can not click on the 'Insert' button. See enclose image

Button not showing in Moodle 4.0

Moodle not showing n Moodle 4.0 even with cloze = cloze and in the Cloze question type

Multiple choice doesn't recognize scores with decimals

Scores with decimals are not recognized as scores and appear annexed to the answer text.

Multiresponse editor wrongly suggesting decimal weights

Hi,
A friend has just discovered that while editing a multi-response type of question the suggested grading options are too many.

First of all, If the teacher chooses an option with decimal points, the question fails to decode at all, e.g.

{1:MULTIRESPONSE:%16.66667%a%16.66667%b~%16.66667%c~%16.66667%d~%16.66667%e~%16.66667%f}

will produce the warning " One of the answers should have a score of 100% so it is possible to get full marks for this question. "

It IS possible to use weightings in the drop-down ONLY IF they do NOT use decimal points, e.g. this one compiles correctly:

NEW QUESTION {1:MULTIRESPONSE:%50%ANSWER 3#GREATWRONG#BAD~%25%ANSWER 2#GREAT~%25%ANSWER 1#GREAT}.

Interestingly, it seems to produce exactly the same effect as:

NEW QUESTION {1:MULTIRESPONSE:%100%ANSWER 3#GREATWRONG#BAD~%50%ANSWER 2#GREAT~%50%ANSWER 1#GREAT}.

The original proposal from OU was to only use correct or incorrect options here (cf. https://docs.moodle.org/36/en/OU_multiple_response_question_type) . The use of "weighting" in the selected grades is perhaps a (recent ?) "bonus".

My suggestion is to shortlist the list of available options in the dropdown for multi-response to "Correct" and "Incorrect", and remove all the other options. If we want to keep the weighting options, we must at least exclude the grades with decimal points that fail to compile for the Embedded answer (Cloze) (in Moodle 3.6.5+ at least, where we have tested).

TinyMCE6-Version

Are there plans for an TinyMCE6-Version (https://moodle.org/plugins/browse.php?list=category&id=82) of that very helpful plugin?
Since TinyMCE 6 is standard as of Moodle 4.2, it is only a matter of time before Atto is no longer supported.

Thanks for sharing your plans!

kind regards
Klaus

Check for question test does not work for all themes

A check was added so the button only displays in question text area on question form. The selector does not work for the renderer for Boost them. It needs to be removed at the moment.

Parsing method crashes in IE 11

This was reported in the Moodle forum https://moodle.org/mod/forum/discuss.php?d=337286#p1368531. Console complains .contains is not supported on node.

Provide appropriate response to user errors.

Currently the plugin accepts any answers in the blanks. It should deal constructively when users leave and answer blank or enter nonnumerical answer in a numeric question. These errors will be caught when the full question is decoded.

High time to submit for peer testing and review ?

Hi Daniel.

Great work you have done in a very short time :)

Will you now post about it in a new thread in the Moodle quiz forum ?
Does your plugin current version comply with the Moodle guidelines for plugin submittal ?
When do you think you can submit it for Moodle plugin approval ?

Thanks a lot for allowing me to collaborate in this process.

Button not appearing in Atto editor anymore

The Cloze button does not appear in Atto editor anymore - did use this a whole year but button disappeared in Moodle 3.4. - Unable to have it back. Tried direct with placing question in Question Bank.

tag plugin releases

Hi,

Our build process fetches the stable code via Github API under the assumption that there is a tag for each plugin release.
Could you please tag the current version (1.1) and future releases on Github? It has no cost and would support our build process.

Thanks in advance!
Beni

Great usability addition

The plugin looks great so far, but I think it will be a lot easier to use for novice Moodler if you added some help inside the popup window of the cloze editor itself. This help will link to Moodle Docs page https://docs.moodle.org/31/en/Embedded_Answers_(Cloze)_question_type#Format . The Documemntation page, of course, must be updated and match the different buttons options.

I think that this link (button or text hyperlink) would be even better if it was a variable string, which can be translated in AMOS. For example, the spanish translationfor this string in AMOS might be https://docs.moodle.org/all/es/Tipo_de_Pregunta_con_respuestas_incrustadas_(Cloze)#Formato . The text 'HELP' must also be an AMOS translatable English language string.

Lack of spacing with 3.8DEV

Hi Daniel,

I have been testing this and other plugins with the Moodle 3.8dev+ (Build: 20191016) branch.

In both Classic and Boost themes, the options show too close to the selection buttons, which looks ugly.

The same problem happens with the TinyMCE plugin for cloze.
I think it is a Moodle core issue.

Moodle 3.1 was the last branch that had a proper spacing.

This lack of spacing happens with all Moodle branches from 3.2 to 3.8DEV

Improve user interface

I pushed some commits to improve the user interface and to implement button hightlighting. After modifiying answer form the affected answer blank is focus. This means saves a mouse click before input and makes it more keyboard friendly. I am not sure whether removing the add and delete buttons entirely is a good idea or not.

Wildcard * Numerical

When I put a wildcard * into the cloze editor it enters a NaN into the question text instead of the *. Also when tolerance is left as blank it inserts an 0 which is not compatible with the *. What is required is a * with no tolerance so feedback ia given for any answer which isn't the correct answer.

Escape characters in answers and feedback

The editor should add and remove backslashes so that special characters are automatically escaped when add to the answer and feedback inputs on the form.

Missing question types

Support needs to be add for case sensitive matching. Also in Moodle 3.2, multiple choice with multiple correct responses is being added. All need to be accommodated.

Alternative condition for the button display

I see the intention is to display the button when and only when the user is actually editing a Cloze question. Alternative and more precise implementation might be to check the body tag's id attribute. When editing such a question, the value is like

<body id="page-question-type-multianswer" ... >

Button not appearing on moodle atto

Even after adding cloze = cloze on this page (admin/settings.php?section=editorsettingsatto). Not a sign of button.

The only thing I saw, is that this required moodle-tinymce_cloze-editor. And this is not found.

Moodle is currently on version 3.8.3.
editor_atto is on 2019111800
atto_cloze is on 1.1 - 2017072802

Thank you