dthies/moodle-atto_fullscreen

An Atto plugin which enables fullscreen editing mode

moodle-atto_fullscreen's Issues

Static postioning causes scrolling problems on mobile devices

The current version works well on destop, but has an issue on mobile devices (tested with android). The screen scrolls dragging the editor off the page. Earlier version worked better using fixed css positoning. Reverting to that should give better results provided later changes are retained for the html plugin.

Quiz timer overlaps a part of the editor toolbar in full screen mode

In Moodle 3.11 you can't switch back from the full screen mode if you use it in the answer field of a quiz and the quiz timer is used (as usual in exams).

In Moodle 4.1. the quiz timer is placed directly in the writing field.

Here are the some screenshots for Moodle 3.11 and 4.1 (Boost theme):
https://box.hu-berlin.de/d/973230fdd9d549f6b1ee/

Is it possible to make the quiz timer box smaller and align it to the top on the right side?

If you use the Tiny MC, the quiz timer is completely hidden in full screen mode (which I don't like either).

Seeing an "echo" of the scroll bar on Google Chrome

Hello,

This issue might be more on Google's end? But when using the fullscreen plugin, I get an "echo" of the scroll bar appears over top of the hyperlink button, as shown below:

This happens only after you have saved your text at least once using the Atto editor, and on all activities and resources; however, I have not observed this same behavior in FireFox or Safari, which renders this normally. It is unknown to me if it happens with MS Explorer.

Moodle version: 2.8.7
Theme: Essential

Thankya kindly.

button conflicts with html+ plugin

I have installed both plugins, atto_fullscreen and atto_htmlplus. In source mode - fullscreen toolbar button is inactive.

Request: Please add release tags for versions present on moodle.org/plugins + please change version numbering according to moodle.org recommendations

Hi,

would you be so kind to reconsider your version numbering system? At the moment you're just incrementing the 2015xxxxx release, which may be the easiest way for you but makes it hard to recognize when a certain version was released. Please consider changing that to reflect what's written on https://docs.moodle.org/dev/version.php. (The version number should be the date of the release of that version).

It would also be nice if you could convert to semantic versioning (https://semver.org/lang/de/) or something like it for both $plugin->release and the git release tags as that makes stuff more readable.

It also looks like you re-release the same version of the plugin on moodle.org if a new Moodle version is released and you've checked that your version will work with the new Moodle version. If I got it right, you don't need to do that but you can just change the already existing version to append compatibility info.

There also seems to be some confusion with your plugin release on https://moodle.org/plugins/atto_fullscreen/2015122002/20235 where the header says "Full screen 2015122002" but the plugin version is 2015122007.

Apart from that to make things easier here are the commands to add the git release tags for the versions we're currently upgrading from and to...

# add the git tag for 2015122007 (or whatever new version number you'd use) (taken from the $plugin->version of that commit)
git tag -a "2015122007" b31c540ee77b8b817230749cadce953e73fd68f2 -m "ADDITIONAL_OPTIONAL_INFO"
# add the git tag for 1.0.1 (taken from moodle.org)
git tag -a "1.0.1" fd192511a38d886cba615d21ae0c5b08349041ae -m "ADDITIONAL_OPTIONAL_INFO"

Toolbar menus don't work in Safari

In Safari, when the Atto full screen toggle is engaged, the menus in the Atto toolbar (e.g., paragraph styles, font color) don't work. The problem is not present on Chrome or Firefox (tested on the Mac). This issue is present in both the version 2015122012 along with the recently-released update.

Feature Request - Behat tests

Are there any plans to support Behat tests for this Atto plugin? (in the same way that they are supported here: https://github.com/moodle/moodle/tree/master/lib/editor/atto/plugins/bold/tests/behat
Thanks
Mark

Officially support Moodle 3.1

on full-screen mode gets overlapping with bottom menu while switching from text to html vice versa

Moodle Atto HTML editor on full-screen mode get overlapping with the bottom menu while switching from text to HTML.

Moodle version 4.1
see image below:the

syntax error, unexpected '.1' (T_DNUMBER) !!!

Upgrading Moodle Core started...
!!! Exceção - syntax error, unexpected '.1' (T_DNUMBER) !!!

Issues with Boost Theme

When utilizing Atto Fullscreen in conjunction with Atto HTML Plus on Boost theme, a col 3 pushes the content to the right and text extends off of the screen.

Overlapping fullscreen modes

When creating a page resource it is possible to open the full screen mode of the Atto editor for two text fields, description and page content, at the same time. After expanding to the full screen view for the description field, the user may use the tab key to have the page content field displayed overtop of the Atto fullscreen for the description field. From there, the user may also expand the editor to full screen for the page content field. The user may toggle off full screen for the page content field, to return to the fullscreen of the description field. However, once full screen is closed for the page content field, other page elements not previously displayed are loaded over top of the full screen editor for the description field. When using the Boost theme the navigation drawer is now loaded. In the classic theme, any left-aligned blocks are now loaded. The elements may obscure part or all of the description text as well as most of the Atto editor tool including the full screen toggle. Ultimately, it is possible with enough scrolling or by collapsing the Boost navigation drawer to gain access to the full screen toggle control to exit the full screen mode for the description field, but the experience can be quite confusing to the user.

I am not sure if the problem should be viewed as the nested full screen modes should not be permitted or that other page elements should not be loaded when toggling off fullscreen.

Here is a narrated video to help demonstrate the issue: https://www.screencast.com/t/ugnZNtkj.

STEPS TO REPLICATE

1. In a course using the Boost theme, turn editing on.
2. Expand the navigation drawer (top left button) if collapsed.
3. Click "Add an activity or resource" and choose the page resource.
4. Enter a name for the page.
5. Enter some text in the Description field.
6. Use the show/hide advanced buttons button on the Atto editor to expand all of the Atto editor tools.
7. Click the Toggle full screen button for the description field. Observe that the full screen mode of the Atto editor is opened blocking all other page elements including the navigation drawer.
8. Hit tab on the keyboard. The Page content field is loaded over the middle of the fullscreen mode for the description field. Enter some text in the page content field.
9. Use the show/hide advanced buttons button on the Atto editor to expand all of the Atto editor tools for the page content field.
10. Click the Toggle full screen button for the page content field. Observe that only the Atto full screen mode for the page content field is displayed on the screen.
11. Click the Toggle full screen button again.
12. Observe that the you are returned to a view with the regular sized page content field displayed over top of the full screen mode for the description field. However the boost navigation drawer is now also displayed over top of the full screen mode obscuring the Atto editor tools, including the full screen toggle.

NOTE: The same replication steps may be applied to the Classic theme which will result in the left-aligned blocks being loaded over top of the full screen Atto editor.

Bad selector crashing in Moodle 2.7

An exception is thrown in Moodle 2.7 because a class is missing that is used as a selector. Editor is expanded, but not minimized. This is a regression from the last HTMLplus fix.

The plugin doesn't work with Edwiser Remui theme

Tested with Chrome, Fire fox and Safari, with moodle 4.2.2+ et and theme Edwiser Remui 4.2.
Here is the screenshot when you activate it with no way to go back but go back with your navigator.
It works fine with Boost theme.

Is anybody can fix it ? Edwiser guys ?

Drawer in Boost them overlaps editor

Moodle 3.2 added the Boost theme as default. The theme has a navigation drawer on the left that needs to be hidden in fullscreen mode.

Paragraph styles don't work in fullscreen mode

When in fullscreen mode, clicking the paragraph styles button does not bring up the menu. I suspect this is a z-indexing issue?