dthies/moodle-block_deft

Interacative polling, chat, and confering plugin for Moodle

moodle-block_deft's Issues

Re-uses block_rss_client capabilities without explicit dependency

moodle-block_deft/manage.php

Lines 48 to 51 in 329457e

	$managesharedfeeds = has_capability('block/rss_client:manageanyfeeds', $context);
	if (!$managesharedfeeds) {
	require_capability('block/rss_client:manageownfeeds', $context);
	}

re-uses the other block's capabilities.

1. Is this intentional? Would not it be better to have a dedicated capability for this and eventually make use of clonepermissionsfrom (https://moodledev.io/docs/apis/subsystems/access) to make the initial setup easier?
2. If is it intentional, it would be better / safer to have the other block explicitly mentioned as a dependency, even when it is a standard one.

Accidentally added empty file

The commit d7b7041 accidentally introduced an empty file https://github.com/dthies/moodle-block_deft/blob/329457e42134bbc057ac2eb2348e46954b790e08/block_deft_manage_task.feature

Make it clear that post-installation step is needed

When installing the plugin, the New settings page may suggest there is not much to be configured for the block. It took me a while to realise I had to go back to block's settings in the site administration to actually activate the integration with deftly.us.

It might help to extend the README and the plugin description at https://moodle.org/plugins/block_deft to make it clear that a post-installation step is needed to activate the integration with the service.

Reply to a Comment Feature

Just as an enhancement suggestion, it would be neat to see the ability to to have a nested reply so a "reply comment" can be left directly under an initial comment. Currently this can be done in a forum, but I like how the polling and the commenting are all wrapped together in this one block, so figured I'd make the improvement suggestion in case this feature could ever be useful to anyone else too. Use case -- a professor posts a challenge poll question and users select an answer and use the comment to explain their reasoning, the professor then replys to each comment with some additional thoughts specific to that comment.

SQL SELECT inside foreach loop

In the block_deft\cache\results::load_many_for_cache() the SQL SELECT queries are executed inside the foreach loop. In general, this is always better to avoid and use https://moodledev.io/docs/apis/core/dml#get_in_or_equal instead.