dthies/moodle-format_popups

Moodle course format that opens some activities in a modal instead of a new page

moodle-format_popups's Issues

Stop videos playng in background

Videos and other content are playing in the background when the windows closes. The content should be removed when the modal is closed rather that when it opened. https://moodle.org/mod/forum/discuss.php?d=420525#p1758717

Dependency on block_deft

If you try to add functions to a web service you get "Exception - Class "block_deft\external\renew_token" not found". If you don't have block_deft installed. block_deft should at least be a dependency in the version file.

moodle-format_popups/classes/external/renew_token.php

Line 34 in 53abf4f

class renew_token extends \block_deft\external\renew_token {

Problem with H5P interactive book content

Hi,

I've noticed an issue with H5P content. If an H5P interactive book is uploaded as an H5P package there is a problem with the full screen function. The background image for the book page fits the window when the pop-up displays at its default size (fig1) but, when the pop-up is expanded to full screen, the image does not grow to match the screen (fig 2).

Thanks.

Upgrade error

In Moodle 3.11.11

When i tried to update to

I got THIS:
Downloading format_popups ... OK
Validating format_popups ... Error
[Error] Required Moodle version [2022030300]
Installation aborted due to validation failure

Any suggestion?

I have installed (working OK)

Popup support for third-party plugins

Hi Daniel,

love the idea! I will certainly use it in the future.

One question:
Is it possible to add support to additional plugins? I would really like Video Time to be supported (https://moodle.org/plugins/mod_videotime), is that something you would need to do, or can we do it from within mod_videotime? I see that there's a file per mod in /classes/local, is that the (only) way to add support?

Thanks!
Stefan

Indicate completion status for 3.11

Completion status information was added to the module view page in 3.11 instead of on the course page. This information should be shown by modal somehow.
See https://moodle.org/mod/forum/discuss.php?d=420525#p1704546

Show navigation footer

Request was made in forum to add module navigation to bottom of modal https://moodle.org/mod/forum/discuss.php?d=420525. I think it may be to much navigation and cause confusion, but will try it.

redirecterrordetected with SCORM content

The plugin seems to works fine with other content elements (tried "Page"). However, when I use it with SCORM content it works fine as admin, but as participant I get the error

Error code: redirecterrordetected
* line 2838 of /lib/weblib.php: moodle_exception thrown
* line 1079 of /mod/scorm/locallib.php: call to redirect()
* line 148 of /course/format/popups/classes/local/mod_scorm.php: call to scorm_simple_play()
* line 91 of /course/format/popups/lib.php: call to format_popups\local\mod_scorm->render()
* line 7912 of /lib/moodlelib.php: call to format_popups_output_fragment_mod()
* line 423 of /lib/external/externallib.php: call to component_callback()
* line 261 of /lib/externallib.php: call to core_external::get_fragment()
* line 81 of /lib/ajax/service.php: call to external_api::call_external_function()

I checked the permissions and they look fine. Any ideas?

Glossary entries multiplication issue

Hi,

I believe I have discovered a problem with how this plugin reacts with Moodle's glossary function.

It appears to interact badly with glossary entries that are linked to text on a page where the format has been set up to "pop-up activities". Where a glossary link is clicked before a pop-up activity is selected it acts normally. If a pop-up activity (specifically a video added as a page or an H5P package) is accessed, and then the glossary link is selected, the glossary entry appears multiple times (screenshot attached).

Thanks

Menu-Icon in Book disappears when Vimeo-Video is embedded

Hi, I have just started using the "pop up activities" Plugin for moodle. And I love it. But I ran into some trouble.

I am using multiple Books in my moodle course. And I observed that sometimes the blue hamburger-Menu on the top left disappears. I then found out that this happens, when I had opened lastely a book with an embedded Vimeo Video. Then closed that book and opend (any) other. Always when the lastely opened book page had an embedded Vimeo Video the next opening of a book comes without that little Menue icon...

With the embed-code comes a script-code... maybe it is related to that...

<script src="https://player.vimeo.com/api/player.js" type="text/javascript"></script>

<iframe src="https://player.vimeo.com/video/599992066?badge=0&autopause=0&player_id=0&app_id=58479&h=624d6a77b7" allow="autoplay; fullscreen; picture-in-picture" allowfullscreen="" style="position: absolute; top: 0; left: 0; width: 100%; height: 100%;" title="26 Einf&uuml;hrung Propheten" frameborder="0"></iframe>

I am using Moodle 3.10.4 and pop up activities 1.0.6

Bugs echos - admin and user Coding erorrs

Tested on Moodle 3.11.2+ (Build: 20210805) and Moodle 3.11.1 (Build: 20210712)

Worklfow standard user:
Module URL-> click -> open in new window -> go back to course window -> codingerror

Coding error detected, it must be fixed by a programmer: Cannot call moodle_page::add_body_class after output has been started.
File: /lib/pagelib.php
Line: 1210
Stack trace:

Error code: codingerror

• line 1210 of /lib/pagelib.php: coding_exception thrown
• line 1300 of /lib/outputrenderers.php: call to moodle_page->add_body_class()
• line 171 of /mod/url/locallib.php: call to core_renderer->header()
• line 271 of /mod/url/locallib.php: call to url_print_header()
• line 100 of /course/format/popups/classes/local/mod_url.php: call to url_print_workaround()
• line 91 of /course/format/popups/lib.php: call to format_popups\local\mod_url->render()
• line 7917 of /lib/moodlelib.php: call to format_popups_output_fragment_mod()
• line 423 of /lib/external/externallib.php: call to component_callback()
• line 261 of /lib/externallib.php: call to core_external::get_fragment()
• line 81 of /lib/ajax/service.php: call to external_api::call_external_function()

Loged as admin with same workflow:
codingerror
Coding error detected, it must be fixed by a programmer: Invalid state passed to moodle_page::set_state. We are in state 2 and state 1 was requested.
File: /lib/pagelib.php
Line: 980
Stack trace:

Error code: codingerror

• line 980 of /lib/pagelib.php: coding_exception thrown
• line 1321 of /lib/outputrenderers.php: call to moodle_page->set_state()
• line 171 of /mod/url/locallib.php: call to core_renderer->header()
• line 271 of /mod/url/locallib.php: call to url_print_header()
• line 100 of /course/format/popups/classes/local/mod_url.php: call to url_print_workaround()
• line 91 of /course/format/popups/lib.php: call to format_popups\local\mod_url->render()
• line 7917 of /lib/moodlelib.php: call to format_popups_output_fragment_mod()
• line 423 of /lib/external/externallib.php: call to component_callback()
• line 261 of /lib/externallib.php: call to core_external::get_fragment()
• line 81 of /lib/ajax/service.php: call to external_api::call_external_function()

Missing `:string` on MOODLE_39_STABLE provider.php

Missing :string on https://github.com/dthies/moodle-format_popups/blob/MOODLE_39_STABLE/classes/privacy/provider.php#L45

causing:

Fatal error: Declaration of format_popups\privacy\provider::get_reason() must be compatible with core_privacy\local\metadata\null_provider::get_reason(): string in /var/www/site/course/format/popups/classes/privacy/provider.php on line 45
PHP Fatal error:  Declaration of format_popups\privacy\provider::get_reason() must be compatible with core_privacy\local\metadata\null_provider::get_reason(): string in /var/www/site/course/format/popups/classes/privacy/provider.php on line 45

Renderer functions depricated in 4.0dev

There is a deprecation warning when the page is refreshed in master when modal closed. We need to remove the deprecated methods from the ajax.

Feature request: Add SCORM landing option

SCORM display better in Moodle App if we set SCORM open in new window, like in this docs (https://docs.moodle.org/311/en/Moodle_app_SCORM_player):
"If you want to display your SCORM package in semi full-screen mode (it will just remove the app bottom menu), you have to configure it in Moodle so it will open in "New window" via the SCORM module Appearance settings".

But in Desktop Browser, some people prefer to display SCORM in current window. And before v.1.0.8, your plugin help us to get the best of both world. Eg. in v1.0.7 we just set SCORM to open in new window, with your plugin it will open in modal (if we run in Browser) and open in semi fullscreen (in Moodle App).

Can you make an option, so admin can choose whether they want SCORM always open in modal no matter what setting for window, or obey new window setting. Thank before.