dtm-labs/client-csharp

The new client for dtm in csharp, including workflow, dtmcli, and dtmgrpc

client-csharp's Issues

这样遍历添加20个，在dtm库里只有18个子事务

await globalTransaction.Excecute(async (tcc) =>
{
for (int i = 0; i < 20; i++)
{
var res1 = await tcc.CallBranch(request, svc + "/TransOut/Try"+i, svc + "/TransOut/Confirm" + i, svc + "/TransOut/Cancel" + i, cts.Token);
}
}, cts.Token);

tcc.Callbranch 检查分支调用结果，如果出错，则走异常

之前dtmcli-csharp的使用者很容易出现的一个误会是，CallBranch调用分支时，如果分支返回了错误的结果，调用方很容易忽略，而继续执行下一步。
因此更好的做法是，检查返回的结果，如果是错误，则走异常，避免被调用者忽略。

调用分支返回错误：旧版本（dtm版本小于1.10.0）为StatusCode==200 && content.Contains("FAILRUE")，新版本可以采用StatusCode >= 400
为了兼容，SDK可以检查两种情况，然后转成异常

子事务屏障添加对二阶段消息的rejected处理

参考

https://github.com/dtm-labs/dtm/blob/7fddbd48f96c74e2a117d0954853fcbd673f9af5/dtmcli/barrier.go?_pjax=%23js-repo-pjax-container%2C%20div%5Bitemtype%3D%22http%3A%2F%2Fschema.org%2FSoftwareSourceCode%22%5D%20main%2C%20%5Bdata-pjax-container%5D#L87

没有找到c# SDK的XA模式

我在demo/src中都没有发现关于 XA模式的事务支持， 请问是我看漏了，还是c#的SDK里暂未支持XA模式？

Support XA

go等客户端都支持 XA事务模式 | DTM开源项目文档 ,咱.net也不能落后了。

Support: MySql、TDSQL MySQL版 分布式事务-开发指南-文档中心-腾讯云（分布式的TDSql的XA 分布式事务与mysql有区别）

Support EF Core on branch barrier

Integrate EF Core with branch barrier.

PS: I will implement it after I complete dapr support.

[CORE] Remove PassthroughHeaders option

see dtm-labs/dtm@d65440d

---

参考 dtm-labs/dtm@d65440d

[Dtmcli/Dtmgrpc] Split DtmClient/DtmgRPCClient and barrier relate dependency injection in ServiceCollectionExtensions

Keep the principle of minimum injection. Not all scenarios will involve the server-side request and sub transaction barrier. Consider leaving these two parts during dependency injection and injecting them on demand.

---

保持最小化注入原则，并不是所有的场景都会涉及到服务端请求和子事务屏障，考虑将这两部分在依赖注入时分离开，按需注入。

希望sdk能基于.netstandard2.0

当前sdk基于netstandard2.1导致.net FX项目无法使用。

个人建议将sdk包的.netstandard版本由2.1调整至2.0（版本调整会增加sdk包代码量和实现难度）。好处如下：
1、更好的在.net生态圈推广，让传统行业的.net FX开发人员便捷使用分布式事务
2、帮助.net版本升级的公司。减少从.net FX向.net core3.1+版本升级的过程中分布式事务相关的弯路
3、更便捷的在.net 和java技术栈共存的公司中推广

优化TransRequestBranch的HttpClient用法

https://github.com/dtm-labs/dtmcli-csharp/blob/55faa95e371452a8ec3c30702a1b3c85a5c95715/src/Dtmcli/DtmClient.cs?_pjax=%23js-repo-pjax-container%2C%20div%5Bitemtype%3D%22http%3A%2F%2Fschema.org%2FSoftwareSourceCode%22%5D%20main%2C%20%5Bdata-pjax-container%5D#L109

目前是直接new一个出来，应该用IHttpClientFactory 来创建

增加请求超时时间的自定义配置

目前 cli 向 dtm服务端 和 分支事务 发起的请求都是 HttpClient 的默认超时时间。

对这两类请求，可以设置对应的自定义的超时时间。

支持从配置文件读取DtmOptions

现在配置 Dtmcli，只支持 Action 的方式，需要增加一个 IConfiguration 的方式

customer action

如果这里只是指定的url。可能会很局限。
比如说：
1、我们系统url调用即使错误业务返回统一格式的数据。即使失败也不会http异常
2、我可能不是一个http调用。只是本地d代码处理了一些业务逻辑。
3、正向调用返回的数据可能会在逆向调用中使用。
4、第一个saga.Add返回的数据可能会给第二个saga.Add使用

[Core] Support RollbackReason and Protocol

The new dtm client support RollbackReason and Protocol in trans_base. We should add support in client-csharp as well.

---

最新版本的 dtm 客户端 在 trans_base 中 支持了 RollbackReason and Protocol, 同样也需要在 client-csharp 中支持。

[WORKFLOW] Support new pattern workflow

After dtm v1.15.1, it support a new pattern named workflow, we should add support for this pattern.

see https://en.dtm.pub/practice/workflow.html

---

在 dtm v1.15.1 版本之后，支持了一种新模式 workflow，同样应该支持这种模式。

参考 https://dtm.pub/practice/workflow.html

http response status: NotFound, Message 报错信息如下

DtmCommon.DtmException: http response status: NotFound, Message :
at DtmAPI1.Controllers.TestController.PostTest() in D:\案例代码\elk\Solution1\DtmAPI1\Controllers\TestController.cs:line 46
at lambda_method5(Closure , Object )
at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.AwaitableResultExecutor.Execute(IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.g__Awaited|12_0(ControllerActionInvoker invoker, ValueTask`1 actionResultValueTask)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.g__Awaited|10_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.g__Awaited|13_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.g__Awaited|20_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)
at Microsoft.AspNetCore.Routing.EndpointMiddleware.g__AwaitRequestTask|6_0(Endpoint endpoint, Task requestTask, ILogger logger)
at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
at Swashbuckle.AspNetCore.SwaggerUI.SwaggerUIMiddleware.Invoke(HttpContext httpContext)
at Swashbuckle.AspNetCore.Swagger.SwaggerMiddleware.Invoke(HttpContext httpContext, ISwaggerProvider swaggerProvider)
at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

Support dapr driver

Support DAPR service invocation REST API with dapr driver ultiliy.

PS: I am working on it with my forked branch

[SAGA] Support RetryLimit and RetryCount

see dtm-labs/dtm#342

---

参考 dtm-labs/dtm#342

how to implement sub barrier transaction for this case, can you implement more?

how to implement for example in c#, can you implement more?

Maybe better to use `TryAdd` for service register

Sometimes we may register services more than one time by mistake, Using TryAdd would help to ensure service is registered once even
this method is called multi times

https://github.com/dtm-labs/dtmcli-csharp/blob/86808bac9b69916ec6d17703f3f52ba23dce5dbf/src/Dtmcli/ServiceCollectionExtensions.cs#L59-L61