duanedave/leaderboard

This project is built using Html | Css | JavaScript | Webpack+ API, it saves the scores of users to a backend and displays it on the browser.

Hi 👋, I'm David

I'm a passionate software developer from Nigeria

• 🌱 I’m currently learning backend development

• 💬 Ask me about coding, life and history

• 📫 How to reach me [email protected]

• ⚡ Fun fact I am a great listener with cutting-edge skills in parsing information

Connect with me:

Languages and Tools:

 

leaderboard's Issues

Peer-To-Peer Feedback

@DuaneDave 👋🏻

Your project is looking good and you added the really good GUI. But still, I noticed some issues which I think you need to improve.

1. Please use HTML semantics properly. Use either label tag OR aria-label.
   

   LeaderBoard/src/index.html

   Lines 32 to 37 in c69e931

   	<form>
   	<h2 class="score-header border-radius">Add Your Score</h2>
   	<input type="text" placeholder="Enter Your Name" id="name" />
   	<input type="number" placeholder="Enter Your Score" id="score" />
   	<button type="submit" id="submit">Submit</button>
   	</form>

2. Please Follow CSS Best Practices, Check below you will see that you are using tag-name directly in your CSS. Please use class name or id.
   

   LeaderBoard/src/style.css

   Lines 137 to 154 in c69e931

   	form h2 {
   	margin-bottom: 1rem;
   	align-self: flex-start;
   	}
   	form input {
   	width: 100%;
   	border: 1px solid rgba(94, 49, 158, 0.795);
   	max-width: 400px;
   	padding: 0.7em 1em;
   	border-radius: 20px;
   	margin-bottom: 1rem;
   	}
   	form input:focus {
   	outline: none;
   	transform: scale(1.05);
   	}

3. Please prevent to use innerHTML instead of it please insertAdjacentHTML. (Optional)
   

   LeaderBoard/src/modules/render.js

   Line 5 in c69e931

   container.innerHTML += `

   .

Happy Coding 🥂