duck-nukem/optional-type

Java's Optional coming to Typescript

🦆 Latest CV / 🥰 "Fan favourite" CV

 █████  ██████   ██████  ██    ██ ████████     ███    ███ ███████ 
██   ██ ██   ██ ██    ██ ██    ██    ██        ████  ████ ██      
███████ ██████  ██    ██ ██    ██    ██        ██ ████ ██ █████   
██   ██ ██   ██ ██    ██ ██    ██    ██        ██  ██  ██ ██      
██   ██ ██████   ██████   ██████     ██        ██      ██ ███████ 
                                                                  
 
$ find . -print | sed -e 's;[^/]*/;|____;g;s;____|; |;g'
.
|____links
|____4fun
| |____art.ansi
|____skills
| |____experienced.py
| |____experienced.js
| |____experienced.rs
| |____experienced_docker.yml
| |____medium.kt
| |____medium_aws.tf


$ cat links
https://tailored.hu
https://blocked.lol
https://profile.codersrank.io/user/kreatemore
https://stackoverflow.com/users/1775089/alex-szabó
https://app.hackthebox.eu/profile/21854
https://app.pluralsight.com/profile/szabo-alex

Open-source contributions:

• s0md3v/Cloak#1
• jazzband/django-oauth-toolkit#963
• nccgroup/ScoutSuite#552
• getsaf/shallow-render#106
• getsaf/shallow-render#100
• ngneat/content-loader#11
• django-import-export/django-import-export#1481

optional-type's Issues

Improve quality of isTypeInvalid method

Describe the bug
Not a bug, just not high quality code

To Reproduce
Check isTypeInvalid() implementation

Expected behavior
Current implementation is:

  private isTypeInvalid<T>(value: Undefinable<T>): boolean {
    const valueType = String(value) as JavascriptRepresentation;
    const isInvalidType = this.invalidTypes.has(valueType);
    const isWhiteListed = !this.allowedInvalidTypes.has(valueType);

    return isInvalidType && isWhiteListed;
  }

As you can see it doesn't make sense to return isWhiteListed for the name of the method. It should be !isWhiteListed in the return, and the variable should lose the negation

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
N/A

An in-range update of ts-jest is breaking the build 🚨

The devDependency ts-jest was updated from 23.10.0 to 23.10.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ts-jest is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ ci/circleci: Your tests failed on CircleCI (Details).

---

Commits

The new version differs by 13 commits.

• d9c5b45 Merge pull request #743 from huafu/release/23.10.1
• e4a3a09 chore(release): 23.10.1
• ab94359 Merge pull request #742 from huafu/fix-740-no-js-compilation-with-allow-js
• a844fd4 Merge branch 'master' into fix-740-no-js-compilation-with-allow-js
• 18dced1 Merge pull request #741 from huafu/e2e-weird-deep-paths
• 9e7d6a0 test(config): adds test related to allowJs
• 374dca1 fix(compile): js files were never transpiled thru TS
• 70fd9af ci(cache): removes some paths from the caching
• c12dfff fix(windows): normalize paths
• 0141098 test(e2e): deep paths and coverage
• 6ccbff3 Merge pull request #736 from huafu/detect-import-and-throw-if-none
• a2a4be2 fix(config): warn instead of forcing ESM interoperability
• 21644da Merge pull request #735 from huafu/master

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Add support for undefined

Is your feature request related to a problem? Please describe.
In JS world, undefined is more common than null - it would be nice if we could work with that.

Describe the solution you'd like
A new public API method for handling both null & undefined