The championify's discuss from dustinblackman

Disable Trinkets And/Or Consumables

Make a Windows Installer

Dragging the files from the .zip is fine, but it would be easier if you just had an installer that put all of the stuff in C:\Program Files (x86)\Championify with a single click.

Make directory confirmations more obvious

Stuck at ARAM Zyra

Similar to issue #36, program stops processing after ARAM Zyra.
Screenshot: http://imgur.com/Di2C00S

OS : Windows 8 Enterprise
Expected Behavior : Browse button opens only one folder select dialog when pressed multiple times.
Observed Behavior : Browse button opens multiple folder select dialog when pressed multiple times.

This usually happens when my computer is busy doing something resource intensive.

AutoUpdate Status/Failure Notifications

Random Timeout / unhandled error

events.js:85
    throw er; // Unhandled 'error' event
          ^
Error: connect ETIMEDOUT
    at exports._errnoException (util.js:746:11)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1000:19)

Happens randomly between after the 10th champion and the last. Couldn't figure out any reason.

Mocha/Linter Tests for Gulp Release

https://github.com/jprichardson/electron-mocha

Borderless Window

Create a Borderless application, kinda like how Spotify uses it.
Reference: https://github.com/halbkreativ/osx-window-css3

New Icon

Download of itemsets blocking

When trying to download the newest itemsets, the download stops at "Processing Rift: zyra" (which is the last champ to be downloaded) then the program just hangs up!
Are there any logs with which i could give u some further info`?

Mastery Pages from Champion.gg

if this could be added to the LoLClient as like an overlay it would help some noobs like me and others that are new to league :P thanks for the awesome app thou! keep up the good work :D

Make the item set title be accurate

First, I don't know why it is called 5.x.1. Why is there the .1 there? Second, I'm playing 5.9, but the builds are from 5.8 and should be labelled correctly (I think it should be rather easy to scrape the patch version from champion.gg too).

Autorun with command line parameters

Auto run with command line parameters. See if Atom Shell will let it start minimized as well.

--autorun --path C:\Riot Games\League of Legends

Create 2 separeted items sets

I'd like it more if there would be one for the highest winrate, and one for the most common build.

good work tho :-) I'll try to contribute

Add scroll-ability on log

Item builds version flaw.

The version info used for the build labels uses data from RIOT even though the data from champion.gg hasn't been updated for the "live" patch yet.

For example the current live patch is 5.9.1 but the data on champion.gg is for patch 5.8. This will lead to issues where the build says it is for the "live" version but the data will be from the previous patch(if the user updates before champion.gg has aggregated data for the "live" patch).

A better solution would be scraping the version info from champion.gg so the item build data will always be in sync with the label. It would also be nice to have an indicator showing what patch version champion.gg has data from so the user knows when data for the new patch is available.

Allow user to select install directory

Continue to auto locate LoL, but give the user the option to browse as well.

Add "Browse for League Folder" above browse input

Missing Node.dll

So far not related to Avast or AVG (as some have claimed.) Possibly related to #24

Delete Championify Item Sets Button

Safety measure.

Gulp Release

-Compile ZIPs for both OSX and Windows (on OSX)
-Parse Changelog to be used in Git Release
-Post Git Release.

Compiling the Windows client on OSX will most likely require rcedit to run in Wine, shouldn't been an issue if the system is setup correctly to execute .exe

Future:
-Upload to Virustotal

Create Legacy/Terminal Version of 0.0.3 for Vista/XP/Lion

Add Progress Bar

3% for checking versions
2% for downloading champs from Riot
90% for processing (divided by the amount of champs)
2.5% for deleting
2.5% for saving

Shortened skill orders don't have full accuracy for first 3-4 skills

A skill order like http://champion.gg/champion/Quinn is shortened to "Q>E>W" in both the Most Frequent and Highest Win Rate builds. But one starts with "QEWQ" and the other starts with "QEQW". I recommend you separate the first 3-4 skills and list them in addition to the shortened order.

I mentioned this in the reddit thread but I'm not sure if I was clear about what I meant. See https://github.com/mpcomplete/lisa/blob/master/lib/js/outputFormat.js#L84 for the way I handle this (there's no need to sort the skills - you know if a skill is finished by level 9 that it is maxed, and by level 13 that it is second-to-max.)

AutoUpdate Error - Unable to find valid app

Fresh zip from reddit post(i saved it) Championify.WIN.0-1-0 always does the same. Run as admin, still same prob.i5 8gb x64 lenovo win 7 enterprise
included screenshot of error. tried to pinpoint the origin in the source code but the file does not exist. and also my knowledge of asar and js is limited so i didnt tried further, also no sdk for this.
http://imgur.com/2BefnUB

let me know if you need more info

Missing Shell32.dll

So far not related to Avast or AVG (as some have claimed.)

Garena check #1 does not work if not running in SG region

Because Garena appends region name after "LoL" in directory name (for example LoLTH instead of only LoL for Thai server). Checking "/GameData/Apps/LoL/Game/Config/Champions" won't detect anything except SG region (the only region without suffix in directory name).

Please see https://github.com/dustinblackman/Championify/blob/master/app.coffee#L124 for reference.

Stuck on processing after Zyra.

Championify gets stuck on processing after it ends on Zyra.
Screenshot: http://i.imgur.com/JIVRXh3.jpg
Tried running as admin, and deleted previous champ files. Nothing helped.

Not downloading itemsests

I have LoL installed in the default location: C:\Riot Games. I run the file in admin mode, it says that it is selecting the right folder, but when it ends, the Champions folder is empty. I even copied the exe to the folder where the LoL launcher is.

Something that I notice is a bit weird is the separators for the location of Champions folder . If I run the exe from any location it separates the folders with "/".

But if I use the exe in the LoL folder it uses "" till the LoL folder.

Windows admin test.

I just encountered a bug. A fresh install of LOL doesn't have the Config/Champions folder created so the isWindowsAdmin always fails when trying to create test.txt.

Worked fine once I manually created the folder.

Championify 2 not supported in Mac 10.7.5

An error pops out when trying to open it saying:

"You can't use this version of the application Championify 2 with this version of Mac OS X.

You have Mac OS X 10.7.5 The application requires Mac OS X 10.8 or later."

Is there a way of fixing this? Thanks

Windows XP and Vista Not Supported (SHELL32.DLL Missing)

XP: electron/electron#691
Vista: electron/libchromiumcontent#66

Change title of option for Skill Priorities to something more simple

Auto Updater

Some spec Not Available

As of may 31, i can't get those following build: Zyra Middle, XinZhao Top, Warwick Top, Trundle Jungle, Sion Jungle, Shen Jungle, Poppy Jungle and maybe more since i can't scroll down. All those have there build up on Champion.gg don't know why they don't get imported.

ARAM item sets version number

Hey, the version number is ARAM item sets is back to x.x.1 for some reason.

Allow user to change position of item set entry

Consumables on top instead, for example.
Thinking about a drag and drop styled bit.

Allow for a different format of skill priorities.

Q.W.E.Q.Q.R
Q>W>E

ARAM Item Sets

ARAM Item Sets from lolflavor.com.
I need help in finding out what keys are used in the JSON object to only set the builds to be used in ARAM, opposite of the issue here. #13

EDIT: Required to be done before this feature can be released.
#23

Disable Summoners Rift Item Sets on ARAM

If anyone knows the keys to use to disable on ARAM, and/or only enable on ARAM, I'd be greatful.
Example item set JSON for those needing.
https://gist.github.com/dustinblackman/f8619cefdbf7dda3f704

EDIT: Required to be done before this feature can be released.
#23

Crash when launching

I've come across an odd issue. On one of my computers, when I run it from the desktop (which is how I run it on my other two) it says it can't find my LoL folder and to run it from inside the install path. I moved it to /Riot Games/League and ran it again, and then the following error appears before closing itself:

[09:42:57] | Your version of Championify is up to date!
undefined:0

TypeError: Cannot read property 'replace' of undefined
at
at Math.Enclose.+c+:++t+h+e+b+o+x++C+h+a+m+p++n+o+d+e++m+o+d+u+l+e+s++g
+l+o+b++n+o+d+e++m+o+d+u+l+e+s++o+n+c+e++o+n+c+e+.+j+s.f ()
at Glob. ()
at Glob.emit (events.js:107:17)
at Glob.Math.Enclose.+c+:++t+h+e+b+o+x++C+h+a+m+p++n+o+d+e++m+o+d+u+l+e+
s++g+l+o+b++g+l+o+b+.+j+s.Glob.finish ()
at done ()
at Glob.Math.Enclose.+c+:++t+h+e+b+o+x++C+h+a+m+p++n+o+d+e++m+o+d+u+l+e+
s++g+l+o+b++g+l+o+b+.+j+s.Glob.processReaddir2 ()
at
at RES ()
at Math.Enclose.+c+:++t+h+e+b+o+x++C+h+a+m+p++n+o+d+e++m+o+d+u+l+e+s++g
+l+o+b++n+o+d+e++m+o+d+u+l+e+s++o+n+c+e++o+n+c+e+.+j+s.f ()

Hi,
My bitdefender found following set of simillar issues (about 60) on championify run:
"The we resource http://www.lolflavor.com/champions/Zielan/Recommended/Zielan_aram_scrape.jscon has been detected as infected. The web resource has been successfully blocked and your PC is now safe."

I assume false positive - but worht to check what happend.

Regards,
Michal

dustinblackman / championify Goto Github PK

championify's Issues

Recommend Projects

Recommend Topics

Recommend Org