dvdkruk/protobuf-dt

Automatically exported from code.google.com/p/protobuf-dt

Hi there, I'm Damiaan 👋

Software Engineer 👨‍💻

Interests: 🎮⚽🍺🍖

protobuf-dt's Issues

Display error message if protoc cannot be found

Show an error message if protoc integration is enabled but the protoc 
executable cannot be found

Original issue reported on code.google.com by [email protected] on 14 Apr 2011 at 6:53

Refactoring does not work on enum definitions

protobuf-dt does nothing when trying to rename an enum.

Original issue reported on code.google.com by [email protected] on 15 Apr 2011 at 9:57

Add ability to hyperlink to imported files

Show hyperlinks for the URIs of imported files and open the imported file when 
the hyperlink is clicked.

Original issue reported on code.google.com by [email protected] on 24 May 2011 at 11:51

Implement a formatter

protobuf-dt needs to format .proto files.

Original issue reported on code.google.com by [email protected] on 14 Apr 2011 at 12:05

Imports, options and package can appear in any order

Currently, protobuf-dt has a strict order for this elements: 

1. package
2. imports
3. options

Any change in ordering results in syntax errors.

Original issue reported on code.google.com by [email protected] on 8 May 2011 at 7:29

"extend message" should be allowed inside a message definition

The grammar currently does not support this.

Original issue reported on code.google.com by [email protected] on 9 May 2011 at 9:07

Fix qualified names

I haven't figured out what is the correct way to handle qualified names yet. I 
need to follow what protoc considers valid.

I'll update this issue once I have the answer.

Original issue reported on code.google.com by [email protected] on 21 Apr 2011 at 12:24

Message fields can have a default value and deprecation inside a single pair of brackets

The grammar currently does not support this.

Original issue reported on code.google.com by [email protected] on 9 May 2011 at 9:08

Options can appear inside messages

Messages can contain options as elements.

Original issue reported on code.google.com by [email protected] on 27 May 2011 at 11:12

protoc should be called only when building .proto files

Currently, protobuf-dt calls protoc when building any xtext-related file.

Original issue reported on code.google.com by [email protected] on 15 Apr 2011 at 9:57

Add instructions on how to build plug-in from source

Building from source is not straightforward. Documentation is needed.

Original issue reported on code.google.com by [email protected] on 13 Apr 2011 at 11:44

Negative numbers not supported for default values

Example:

optional int32 max_ads_to_annotate = 2 [default=-1];

Original issue reported on code.google.com by [email protected] on 29 Apr 2011 at 3:48

Add capability to hide "Compiler" preferences

Explore "Capabilities" to hide the "Compiler" preference page.

Original issue reported on code.google.com by [email protected] on 13 Apr 2011 at 11:48

Resolution of "Import URIs" does not work if such URI and the resource URI have overlapping folders

Example:

1. import URI: "testing/src/folder1/test.proto"
2. resource URI (that is, the file specifying the import in #1): 
"platform:/resource/testing/src/test.proto"

They both have overlapping folders: "testing" and "src". The resolved URI 
should be: "platform:/resource/testing/src/folder1/test.proto" but currently is 
"platform:/resource/testing/src/testing/src/folder1/test.proto"

Original issue reported on code.google.com by [email protected] on 9 May 2011 at 9:04

Services should support more than one RPC elements.

Currently we only support one.

Original issue reported on code.google.com by [email protected] on 1 May 2011 at 2:42

Allow "compiler" output folder name to more than one hierarchy level

Currently, protobuf-dt allows only one hierarchy level for name of the 
"compiler" output folder (the default is "src-gen".) Support for nested folders 
will be useful (e.g. "src/gen/proto".)

Original issue reported on code.google.com by [email protected] on 13 Apr 2011 at 11:50

Reduce noise in Outline View

Outline View needs to group imports and options in a similar way JDT groups all 
imports in a "import declarations" node. This will remove clutter, especially 
on large .proto files with lots of imports.

Original issue reported on code.google.com by [email protected] on 13 May 2011 at 12:44

RPC elements can have options

Add support for options in RPC elements.

Original issue reported on code.google.com by [email protected] on 28 May 2011 at 8:05

Validate duplicated tag numbers in a message

Verify that duplicated tag numbers are flagged.

Original issue reported on code.google.com by [email protected] on 27 May 2011 at 10:25

ProtobufQualifiedNameProvider assumes package names do not contain dots

ProtobufQualifiedNameProvider does not split the name of a package into 
segments, and treats the whole name as a single segment. Package names (if 
available) should be splitted using dot as delimiter.

Original issue reported on code.google.com by [email protected] on 16 Apr 2011 at 9:06

Remove Xtext's own markers

Xtext provides markers for syntax errors in the editor. We need to either 
replace them with our own markers or change the id of those markers with our 
own id.

Original issue reported on code.google.com by [email protected] on 13 Apr 2011 at 11:40

IllegalStateException: No IResourceServiceProvider found in registry for uri platform:/resource/javatest/src/folder1

1. Create 2 proto files
2. With the intention of importing one proto into the other, type `import ""` 
and hit enter.

Stack trace:
{{{

java.lang.IllegalStateException: No IResourceServiceProvider found in registry 
for uri platform:/resource/javatest/src/folder1
    at org.eclipse.xtext.scoping.impl.LoadOnDemandResourceDescriptions.getResourceDescription(LoadOnDemandResourceDescriptions.java:70)
    at org.eclipse.xtext.scoping.impl.ImportUriGlobalScopeProvider.createLazyResourceScope(ImportUriGlobalScopeProvider.java:104)
    at org.eclipse.xtext.scoping.impl.ImportUriGlobalScopeProvider.getScope(ImportUriGlobalScopeProvider.java:74)
    at org.eclipse.xtext.scoping.impl.AbstractGlobalScopeProvider.getScope(AbstractGlobalScopeProvider.java:48)
    at org.eclipse.xtext.scoping.impl.AbstractGlobalScopeDelegatingScopeProvider.getGlobalScope(AbstractGlobalScopeDelegatingScopeProvider.java:46)
    at org.eclipse.xtext.scoping.impl.AbstractGlobalScopeDelegatingScopeProvider.getGlobalScope(AbstractGlobalScopeDelegatingScopeProvider.java:42)
    at org.eclipse.xtext.scoping.impl.ImportedNamespaceAwareLocalScopeProvider.getResourceScope(ImportedNamespaceAwareLocalScopeProvider.java:96)
    at org.eclipse.xtext.scoping.impl.ImportedNamespaceAwareLocalScopeProvider.getScope(ImportedNamespaceAwareLocalScopeProvider.java:89)
    at org.eclipse.xtext.scoping.impl.ImportedNamespaceAwareLocalScopeProvider.getScope(ImportedNamespaceAwareLocalScopeProvider.java:87)
    at org.eclipse.xtext.scoping.impl.ImportedNamespaceAwareLocalScopeProvider.getScope(ImportedNamespaceAwareLocalScopeProvider.java:87)
    at org.eclipse.xtext.scoping.impl.ImportedNamespaceAwareLocalScopeProvider.getScope(ImportedNamespaceAwareLocalScopeProvider.java:87)
    at org.eclipse.xtext.scoping.impl.AbstractDeclarativeScopeProvider.delegateGetScope(AbstractDeclarativeScopeProvider.java:72)
    at org.eclipse.xtext.scoping.impl.AbstractDeclarativeScopeProvider.getScope(AbstractDeclarativeScopeProvider.java:102)
    at org.eclipse.xtext.linking.impl.DefaultLinkingService.getScope(DefaultLinkingService.java:59)
    at org.eclipse.xtext.linking.impl.DefaultLinkingService.getLinkedObjects(DefaultLinkingService.java:119)
    at org.eclipse.xtext.linking.lazy.LazyLinkingResource.getEObject(LazyLinkingResource.java:169)
    at org.eclipse.emf.ecore.resource.impl.ResourceSetImpl.getEObject(ResourceSetImpl.java:219)
    at org.eclipse.emf.ecore.util.EcoreUtil.resolve(EcoreUtil.java:206)
    at org.eclipse.emf.ecore.util.EcoreUtil.resolve(EcoreUtil.java:262)
    at org.eclipse.emf.ecore.impl.BasicEObjectImpl.eResolveProxy(BasicEObjectImpl.java:1483)
    at com.google.eclipse.protobuf.protobuf.impl.TypeReferenceImpl.getType(TypeReferenceImpl.java:75)
    at com.google.eclipse.protobuf.ui.util.Properties.nameOfTypeIn(Properties.java:47)
    at com.google.eclipse.protobuf.ui.labeling.Labels.labelFor(Labels.java:62)
    at com.google.eclipse.protobuf.ui.labeling.Labels.labelFor(Labels.java:42)
    at com.google.eclipse.protobuf.ui.labeling.ProtobufLabelProvider.text(ProtobufLabelProvider.java:33)
    at sun.reflect.GeneratedMethodAccessor10.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at org.eclipse.xtext.util.PolymorphicDispatcher.invoke(PolymorphicDispatcher.java:291)
    at org.eclipse.xtext.ui.label.DeclarativeLabelProvider.doGetText(DeclarativeLabelProvider.java:49)
    at org.eclipse.xtext.ui.label.DefaultEObjectLabelProvider.doGetText(DefaultEObjectLabelProvider.java:35)
    at org.eclipse.xtext.ui.label.AbstractLabelProvider.getStyledText(AbstractLabelProvider.java:92)
    at org.eclipse.xtext.ui.editor.outline.impl.DefaultOutlineTreeProvider._text(DefaultOutlineTreeProvider.java:174)
    at sun.reflect.GeneratedMethodAccessor13.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at org.eclipse.xtext.util.PolymorphicDispatcher.invoke(PolymorphicDispatcher.java:291)
    at org.eclipse.xtext.ui.editor.outline.impl.DefaultOutlineTreeProvider.createEObjectNode(DefaultOutlineTreeProvider.java:112)
    at org.eclipse.xtext.ui.editor.outline.impl.DefaultOutlineTreeProvider._createNode(DefaultOutlineTreeProvider.java:108)
    at sun.reflect.GeneratedMethodAccessor12.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at org.eclipse.xtext.util.PolymorphicDispatcher.invoke(PolymorphicDispatcher.java:291)
    at org.eclipse.xtext.ui.editor.outline.impl.DefaultOutlineTreeProvider.createNode(DefaultOutlineTreeProvider.java:104)
    at org.eclipse.xtext.ui.editor.outline.impl.DefaultOutlineTreeProvider._createChildren(DefaultOutlineTreeProvider.java:86)
    at sun.reflect.GeneratedMethodAccessor21.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at org.eclipse.xtext.util.PolymorphicDispatcher.invoke(PolymorphicDispatcher.java:291)
    at org.eclipse.xtext.ui.editor.outline.impl.DefaultOutlineTreeProvider.createChildren(DefaultOutlineTreeProvider.java:77)
    at org.eclipse.xtext.ui.editor.outline.impl.AbstractOutlineNode$1.process(AbstractOutlineNode.java:80)
    at org.eclipse.xtext.ui.editor.outline.impl.AbstractOutlineNode$1.process(AbstractOutlineNode.java:1)
    at org.eclipse.xtext.util.concurrent.IUnitOfWork$Void.exec(IUnitOfWork.java:36)
    at org.eclipse.xtext.ui.editor.outline.impl.AbstractOutlineNode$2.exec(AbstractOutlineNode.java:161)
    at org.eclipse.xtext.ui.editor.outline.impl.AbstractOutlineNode$2.exec(AbstractOutlineNode.java:1)
    at org.eclipse.xtext.util.concurrent.AbstractReadWriteAcces.readOnly(AbstractReadWriteAcces.java:32)
    at org.eclipse.xtext.ui.editor.model.XtextDocument.readOnly(XtextDocument.java:86)
    at org.eclipse.xtext.ui.editor.outline.impl.AbstractOutlineNode.readOnly(AbstractOutlineNode.java:158)
    at org.eclipse.xtext.ui.editor.outline.impl.AbstractOutlineNode.getChildren(AbstractOutlineNode.java:77)
    at org.eclipse.xtext.ui.editor.outline.impl.OutlineRefreshJob.restoreChildrenSelectionAndExpansion(OutlineRefreshJob.java:68)
    at org.eclipse.xtext.ui.editor.outline.impl.OutlineRefreshJob.restoreChildrenSelectionAndExpansion(OutlineRefreshJob.java:71)
    at org.eclipse.xtext.ui.editor.outline.impl.OutlineRefreshJob.restoreChildrenSelectionAndExpansion(OutlineRefreshJob.java:71)
    at org.eclipse.xtext.ui.editor.outline.impl.OutlineRefreshJob$1.exec(OutlineRefreshJob.java:60)
    at org.eclipse.xtext.ui.editor.outline.impl.OutlineRefreshJob$1.exec(OutlineRefreshJob.java:1)
    at org.eclipse.xtext.util.concurrent.AbstractReadWriteAcces.readOnly(AbstractReadWriteAcces.java:32)
    at org.eclipse.xtext.ui.editor.model.XtextDocument.readOnly(XtextDocument.java:86)
    at org.eclipse.xtext.ui.editor.outline.impl.OutlineRefreshJob.refreshOutlineModel(OutlineRefreshJob.java:57)
    at org.eclipse.xtext.ui.editor.outline.impl.OutlineRefreshJob.run(OutlineRefreshJob.java:46)
    at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
}}}

Original issue reported on code.google.com by [email protected] on 14 Apr 2011 at 10:28

Fixed references to messages in services

RPC elements in Services cannot resolve references to local and imported 
Messages.

Original issue reported on code.google.com by [email protected] on 6 May 2011 at 9:25

Protobuf-dt should be able to open files outside workspace

This is handy when navigating through imported files.

Original issue reported on code.google.com by [email protected] on 25 May 2011 at 6:36

Add support for services in grammar

Currently, protobuf-dt's grammar does not have support for 
[http://code.google.com/apis/protocolbuffers/docs/proto.html#services services].

Original issue reported on code.google.com by [email protected] on 13 Apr 2011 at 11:41

Indicate that the output folder is relative to the project in the 'Compiler' preference page

The "Compiler" preference page has a '*' next to the label "Folder Name." The 
preference page needs to have some text like:

'*' relative to project's folder

Original issue reported on code.google.com by [email protected] on 13 Apr 2011 at 11:39

Groups can end with a semicolon

The current grammar does not supports this.

Original issue reported on code.google.com by [email protected] on 9 May 2011 at 9:06

Use the location of workspace folders for import resolution

Currently, protobuf-dt searches for imported files using the paths provided by 
users. These paths can belong to workspace folders or file system folders. 

There are cases that custom file systems include only certain files in the file 
system, forcing users to specify both the workspace-related path and the file 
system one for the *same* folder.

In order to make configuration easier, import resolution should also look for 
files using the actual location of workspace folders.

Original issue reported on code.google.com by [email protected] on 27 May 2011 at 8:31

Finish outline view for proto files

Pending:

1. "syntax" element does not have icon
2. "extend" shows MessageReference as child with no name
3. "extend" needs to show target Message as its description
4. "rpc" shows MessageReferences as children with no name
5. "rpc" needs to show the arg type and return type as part of the label

Original issue reported on code.google.com by [email protected] on 7 May 2011 at 10:04

Mapping Xtext syntax errors to protoc ones.

There's redundancy between Xtext's errors and protoc ones.

Original issue reported on code.google.com by [email protected] on 6 May 2011 at 8:39

Problems with "extend"

The following produces syntax errors:

  extend proto2.Person {
    optional string name = 2;
  }

Original issue reported on code.google.com by [email protected] on 29 Apr 2011 at 5:44

Add more options for syntax coloring

Currently, protobuf-dt has very basic options for syntax coloring. It would be 
great if we had more options, for example, a different color for message 
declarations or enum declarations.

Original issue reported on code.google.com by [email protected] on 14 Apr 2011 at 5:06

Add support for optional semicolon for message elements

Message elements accept an optional semicolon at the end. Example:

message Hello {

// message properties here

};

Original issue reported on code.google.com by [email protected] on 21 Apr 2011 at 12:23

Make editor find type references to match behavior of protoc

Currently, types from imported .proto files can be referred by their qualified 
names only.

Original issue reported on code.google.com by [email protected] on 14 Apr 2011 at 12:04

Import errors reported by protoc are not being added as markers

In a proto file, import a file that does not exists. Make sure you have protoc 
integration on and working.

protoc will complain that the file that we are trying to import does not exist, 
but, there are no error markers in the editor.

Original issue reported on code.google.com by [email protected] on 3 May 2011 at 12:40

Groups can be deprecated

It is valid for a group declaration to have "[deprecated = true]".

Original issue reported on code.google.com by [email protected] on 27 May 2011 at 10:20

Add wiki pages for each feature listed on the front page.

The front page lists protobuf-dt's features. We need more details to show off 
what this plug-in offers.

Original issue reported on code.google.com by [email protected] on 13 Apr 2011 at 11:33

Add support for groups

Even though groups are deprecated, we need to support them for existing proto 
files.

Original issue reported on code.google.com by [email protected] on 28 Apr 2011 at 5:11

Add content-assist options for "syntax"

The "syntax" element only allows the value "proto2". It would be nice if the 
editor proposes this value by default.

Original issue reported on code.google.com by [email protected] on 15 May 2011 at 10:39

Add support for deprecated message fields

Example:

repeated fixed64 website_criteria_fp_deprecated = 102 [deprecated=true];

Original issue reported on code.google.com by [email protected] on 29 Apr 2011 at 3:49

Change grammar to allow indices greater than zero

Currently, the grammar allows zero to be a field index.

Original issue reported on code.google.com by [email protected] on 13 Apr 2011 at 11:35

Find a way to remove Xtext's icon from projects using protobuf-dt

Projects using protobuf-dt need Xtext's nature for things like indexing, 
refactoring and building. The problem is that this nature adds an icon to the 
project. In our case, Xtext is an implementation detail and users shouldn't 
know or care about it.

Original issue reported on code.google.com by [email protected] on 13 Apr 2011 at 11:53

Make auto-complete of '[packed = true]' available only to primitive types

Currently, protobuf-dt automatically adds '[packed = true]' as part of the 
"smart semicolon" command for all repeated fields. This option should be 
available only to repeated fields of primitive type.

I first need to learn what is a primitive type.

Original issue reported on code.google.com by [email protected] on 13 Apr 2011 at 11:37

Add simple support for refactoring

Add support for refactoring among .proto files. In the future we can consider 
including references to generated code.

Original issue reported on code.google.com by [email protected] on 14 Apr 2011 at 12:30

Allow code generation in multiple languages simultaneously

Allow code generation in Java, C++ and Python simultaneously. User should be 
able to select languages and output directories for each language.

Original issue reported on code.google.com by [email protected] on 18 May 2011 at 10:13

Add support for import resolution across multiple folders

Currently, import resolution assumes all .proto files are in the same folder.

Original issue reported on code.google.com by [email protected] on 9 May 2011 at 10:37

Add support for "syntax" element

Add support for: syntax = "proto2";

Original issue reported on code.google.com by [email protected] on 21 Apr 2011 at 12:15

Only one IMarker is displayed in the 'Errors' view

If protoc finds more than one error in a .proto file, protobuf-dt only shows 
one error marker.

Original issue reported on code.google.com by [email protected] on 13 Apr 2011 at 11:34

Remove multi-line comments from grammar

protobuf only supports single-line comments. Xtext out-of-the-box supports both 
types of comments.

Original issue reported on code.google.com by [email protected] on 14 Apr 2011 at 12:29

Minimum proposed index for enum literals should be zero

It is currently 1.

Original issue reported on code.google.com by [email protected] on 25 Apr 2011 at 7:48