Comments (17)
Indeed, numpy = "^1.22"
it is what's in our package metadata here. We need to bump it.
-- https://github.com/earthobservations/wetterdienst/blob/v0.60.0/pyproject.toml#L118
from wetterdienst.
versioning-strategy: lockfile-only
. That must have been accidental, but was probably instrumental for a few dependency woes we had been going on.
wetterdienst/.github/dependabot.yml
Lines 8 to 12 in 8b3b522
from wetterdienst.
GH-1016 will resolve that problem, but we will need to do some manual version bumping work beforehand. Currently upgrading Poetry on my machine, because, well, dependency staleness is everywhere.
==> Upgrading poetry
1.4.2 -> 1.6.1
I am still on Catalina, that means Homebrew needs to actually compile stuff (needs a fresh python@{3.9,3.10,3.11}
whatever). Feels a bit like Gentoo, but at least we don't suffer from spindle disks any longer. ;] I may continue on that later this day.
from wetterdienst.
Thanks Moritz. I noticed that as well. Starting with GH-1017, the project metadata will probably need a few more subsequent patches, where polars will also be bumped.
from wetterdienst.
Those are the two major leftovers after bumping all the other dependencies to their most recent versions. Maybe you can add corresponding adjustments to make them being accepted?
from wetterdienst.
I can take care of the wradlib changes.
from wetterdienst.
Hi again,
thank you so much for your support here, @kmuehlbauer, @gutzbenj, and @xylar.
After refreshing the dependencies on the feedstock package, and updating the corresponding release patch accompanying version 0.61.0, we will need to resolve an issue about the eccodes
package, where the Anaconda Buildbot complains on behalf of its Azure Pipelines CI run.
With kind regards,
Andreas.
from wetterdienst.
Hi again,
if Kai is satisfied with the outcome now, I think it is safe to close the issue.
Cheers,
Andreas.
from wetterdienst.
Dear Kai,
thanks for reporting. Wetterdienst should be a good citizen of the packaging ecosystem, so we should look into relaxing that constraint.
I am a bit hesitant on pinning on the lower bound in general, because, well, that does not protect against breaking changes, specifically with dependencies in their 0.x cycles, because we can't look into the future.
In fact, I am asking myself why Dependabot did not submit a corresponding suggestion to upgrade the Pint
package here. Maybe the dependencies of the feedstock package (meta.yaml) went out of sync, and need another round of (separate) maintenance?
With kind regards,
Andreas.
P.S.: I didn't look into the details yet, so I was just writing down what came to my mind about this.
from wetterdienst.
- Dependency definition is
Pint = "^0.17"
at https://github.com/earthobservations/wetterdienst/blob/v0.60.0/pyproject.toml#L120. - Pint 0.22 is available at https://pypi.org/project/Pint/.
- Dependabot did not send a suggestion to upgrade?
- Why?
from wetterdienst.
Thanks Andreas, much appreciated. It's not only Pint
, but also numpy
which is stuck at 1.22
and maybe others. Maybe some misconfiguration of dependabot?
from wetterdienst.
All right, I also wanted to ask if you have more candidates to care about. Thanks! About NumPy, there is GH-1009. Not sure why the feedstock says it is different. @xylar did a great amount of work there, supporting us to get things right (thanks again!), maybe it needs a refresh/review?
from wetterdienst.
Oh my. Looking at those patches recently submitted by Dependabot, it looks like it only bumps versions in poetry.lock
. Well, there we have it. How is this supposed to work? ;]
-- https://github.com/earthobservations/wetterdienst/pull/1009/files
-- https://github.com/earthobservations/wetterdienst/pull/1010/files
from wetterdienst.
Hi @amotl,
thank you very much for your work on this library! I really enjoy using it.
All right, I also wanted to ask if you have more candidates to care about.
I noticed that polars
is still pinned at ^0.16
whereas its library releases are already at 0.19
.
Best,
Moritz
from wetterdienst.
Hi again,
I've just tried to bump polars, but there is a problem with version 0.17 already, see 1.
pip install "polars<0.18" --upgrade
pytest tests/core/timeseries/test_io.py -k test_export_duckdb
👀
- datetime.datetime(1939, 7, 26, 0, 0),
? ^ ----
+ datetime.datetime(1969, 9, 27, 0, 0),
? ^ ++++
Because it doesn't work without further ado, I am adding 04b2d1f, which will effectively not change anything on this matter. We will have to humbly ask @gutzbenj about it, to adjust the code correspondingly, when possible. 🙏
With kind regards,
Andreas.
P.S.: GH-1026 attempts to go straight to polars 0.19. Maybe directly working on supporting this version is applicable, instead of bumping through 0.17 and 0.18 first. I don't think we need to support multiple versions here.
Footnotes
from wetterdienst.
Dear all,
can we close this issue given the new set of requirements rules?
from wetterdienst.
Great work. Thanks a bunch!
from wetterdienst.
Related Issues (20)
- Can't figure out why some parameters raise a TypeError while others work normally HOT 1
- Request for DWD Solar Irradiance returns missing data despite filters set HOT 2
- List of DWD-parameters that throw exceptions HOT 2
- Column names of 5 minute precipitation data different for recent and historical data HOT 2
- matching the forecasts with the ground truth HOT 10
- ValueError: seek of closed file HOT 2
- Feat: Add integrated surface database HOT 11
- wradlib: Improve installation recipe when building the Docker "full" image HOT 2
- wradlib: Recently released wradlib 1.19.0 has an installation flaw? HOT 7
- confusing/wrong precipitation-height unit HOT 2
- Conda install fails HOT 26
- No data downloaded < 2h HOT 4
- Packaging: Introduce `versioningit` HOT 3
- Handle external pull requests wrt. OCI image build + push well HOT 6
- Possible bug: ModuleNotFoundError: pa.array requires 'pyarrow' module to be installed HOT 3
- Length mismatch: Expected axis has 33 elements, new values have 6 elements HOT 7
- Bug in GeosphereObservationDataset class HOT 2
- Bug in datetime conversion in GeosphereObservationValues._collect_station_parameter HOT 1
- Confusion of extracted parameters in the Geosphere Dataset HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wetterdienst.