Comments (10)
Dear @mhuber89 ,
had busy days but will look into this the upcoming weekend and respond to you asap.
from wetterdienst.
no worries, I have a workaround for now :)
from wetterdienst.
Another addon to this: it seems as W / m2
is only used for 10 minute values a unit conversion would be reasonable effort to get all units straight as J / cm2
, I'll hand in a PR soon.
from wetterdienst.
In addition there is also a bug in the unit conversion in the 10 minute dataset for the parameter radiation_global in the geosphere dataset. the origin unit is W/m2 not Joule/cm2
from wetterdienst.
Dear @mhuber89 ,
thanks for reporting this!
The parameter confusion is fixed with latest version.
Regarding the unit I think we need a bit of discussion! I think so far I took at as the unit should always refer to the time interval that is requested e.g. if you request daily data the energy shouldn't refer to seconds (which watt / joule per second would do). However I'm now unsure whether this is really smart for the case of watt?
Another example: if you request daily precipitation you'd always expect the amount to be per 86400 seconds rather then the amount of precipitation per 1 second.
Do you have other experiences with this?
from wetterdienst.
Hi @gutzbenj ,
thanks a lot again for the quick fix :)
I think having the SI units of wetterdienst referring to the duration of the requested time interval is fine (at least from my side there is nothing against it). On the other hand I think having normalised (to seconds) SI units would be also fine as long as it is done consistently. as far as I can see the unit scheme seems very consistent in the code :)
what I was referring to in the comment above was more that the origin unit of the extracted geosphere parameter radiation_global is W/m2 (for the 10 minute dataset). but in the code the origin value is interpreted as joule / cm2. so I guess just the marked part would need to be exchanged to have the values correct again.
from wetterdienst.
Sorry for the many comments, but I have one hopefully last question. I think the units for the radiation values in geosphere that are give in Joule per ... are always given in per cm2 (at least according to your documentation and the geosphere documentation). So in the above file most of the unit Values for radiation related values should be changed to JOULE_PER_SQUARE_CENTIMETER, right?
from wetterdienst.
Sorry, couldn't look into the issue during the weekend but hopefully next weekend!
from wetterdienst.
Hey again,
I checked the units and it should be W / m2
, see this: https://dataset.api.hub.geosphere.at/v1/station/historical/klima-v1-10min/metadata
So as it stands, our documentation is wrong!
Also after considering everything again I'm a bit frustrated:
It seems there are two ways used to express energy per area:
- At Geosphere they use Watt which includes the time scale (s)
- At DWD they use sums (J / cm2 per ... e.g. day) which implicitly tells the time over the queried data
After thinking over it again it would actually be more logical to use Watts as it includes the time period but the user would obviously have to do the hard work of multiplying it and even there are even some other logical implications like leap years...
I think at the moment easiest would be to keep both units and I'll fix the documentation.
Addition
Turns out Geosphere is using J / cm2
for daily sums as well! https://dataset.api.hub.geosphere.at/v1/station/historical/klima-v1-1d/metadata
from wetterdienst.
Hi again.
Is GH-998 already the intended fix for your issue, @mhuber89? Did you have the chance to validate whether it works well for you? It looks like the improvement has been included into release 0.59.2 already.
With kind regards,
Andreas.
from wetterdienst.
Related Issues (20)
- Can't figure out why some parameters raise a TypeError while others work normally HOT 1
- Request for DWD Solar Irradiance returns missing data despite filters set HOT 2
- List of DWD-parameters that throw exceptions HOT 2
- Too strict dependency pinning HOT 17
- Column names of 5 minute precipitation data different for recent and historical data HOT 2
- matching the forecasts with the ground truth HOT 10
- ValueError: seek of closed file HOT 2
- Feat: Add integrated surface database HOT 11
- wradlib: Improve installation recipe when building the Docker "full" image HOT 2
- wradlib: Recently released wradlib 1.19.0 has an installation flaw? HOT 7
- confusing/wrong precipitation-height unit HOT 2
- Conda install fails HOT 26
- No data downloaded < 2h HOT 4
- Packaging: Introduce `versioningit` HOT 3
- Handle external pull requests wrt. OCI image build + push well HOT 6
- Possible bug: ModuleNotFoundError: pa.array requires 'pyarrow' module to be installed HOT 3
- Length mismatch: Expected axis has 33 elements, new values have 6 elements HOT 7
- Bug in GeosphereObservationDataset class HOT 2
- Bug in datetime conversion in GeosphereObservationValues._collect_station_parameter HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wetterdienst.