ecatch-kyst/backend

backend's Issues

An in-range update of date-fns is breaking the build 🚨

The dependency date-fns was updated from 2.0.0-beta.5 to 2.0.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

date-fns is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

---

Release Notes for v2.0.0

🔥🔥🔥 date-fns v2 is out! 🔥🔥🔥

See the changelogs:

• Pre-releases changelog (if you're upgrading from alpha or beta): https://gist.github.com/kossnocorp/a307a464760b405bb78ef5020a4ab136#v200
• Full changelog: https://github.com/date-fns/date-fns/blob/master/CHANGELOG.md#200---2019-08-20

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

✨ Send messages to Dualog

Every message should be forwarded from our backend to Dualog.

Expected Behavior

When a user saves a message to our backend it should send a HTTP(S?) request to the Dualog backend. Depending on the response we should update the status of the message in our backend to let the user know the message status.

Messages:

• DEP
• DCA
• POR
• RET
• error messages

Priority

Fast

Size

3

✨ Firestore rules

Firestore needs rules to limit what a user can do.
This issue extends #4

Expected Behavior

We need several firestore rules to ensure safety for our application. This includes limiting access as well as validating input. These rules should also be tested.

• unauthenticated user should not be able to read or write any data
• authenticated user should only be able to read his own user data
• authenticated user should only be able to read his own messages
• authenticated user should be able to create new messages
• authenticated user should only be able to read his own boat data
• add tests

Priority

Fast

Size

3

✨ New Feature (Automatic DCA before midnight)

This is originally issue #51 from ecatch-kyst/web

The user should get help from the system if he has not sent a DCA message before midnight

Expected Behavior

If a fisher has sent a DEP message, but no DCA message before midnight, the system should automatically send a message for him.

• Use cloud functions to send automatic DCA a few minutes before midnight

Priority

Should be implemented, but no other components depending on this solution.

Size

1

🐛 RN is not added to message

When a user adds a new message RN is not set.

Expected Behavior

When a message is created it should automatically set the RN.

Current Behavior

When a message is created RN is not set automatically.

Possible Solution

add RN to the update message function in created.js

Steps to Reproduce

1. Create a DEP message
2. Send DEP message
3. Observe in Firestore console that RN is not added
4. ???

✨ Notify the user that their message is received

The user needs to know that a message is sent.

Expected Behavior

When firebase receives a message it should set status to received to let the user know it is sent.

Priority

Fast

Size

3

An in-range update of babel7 is breaking the build 🚨

There have been updates to the babel7 monorepo:

• • The devDependency @babel/cli was updated from 7.4.4 to 7.5.0.

• The devDependency @babel/core was updated from 7.4.5 to 7.5.0.
• The devDependency @babel/preset-env was updated from 7.5.2 to 7.5.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the babel7 group definition.

babel7 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

---

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

✨ Mock Server

We need to mock answers to messages you sent from the frontend.

It this process we can validate our messages and respond with ACK or NAK.

• Server that responds
• Validate and respond correctly
• Respond with error messages

✨ Handle DCA messages

Since frontend is focusing on sending DCA messages, the backend needs to be able to handle it. This includes:

• make sure firestore rules accepts the messages
• add DCA case to the switch in created.js
• tests

Expected Behavior

When a user sends a DCA message it should be validated in firestore and generate the message which will be sent to Dualog mock.

Priority

Fast

Size

2

An in-range update of babel-eslint is breaking the build 🚨

The devDependency babel-eslint was updated from 10.0.1 to 10.0.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

babel-eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

---

Release Notes for v10.0.2

Fixes #772

Commits

The new version differs by 2 commits.

• 48f6d78 10.0.2
• 0241b48 removed unused file reference (#773)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

✨ User authentication

This issue tracks the backend handling of user authentication.
For the frontend issue see ecatch-kyst/web/issues/10

Expected Behavior

When a new user is created it should also create a new firestore document with the same uid. When user deletion is requested it should delete the user on uid from firestore.

• add user
• remove user
• add security rules
• add tests

Priority

Fast

Size

4 (implementation, testing, security, frontend)

🤯 add Jest 🃏 & Codecov to CI pipeline

Description

• .travis.yml
  • scripts
  • install jest globally
• Travis enviroment variables

✨ Handle POR messages

Since frontend is focusing on sending POR messages, the backend needs to be able to handle it. This includes:

• make sure firestore rules accepts the messages
• add POR case to the switch in created.js
• tests

Expected Behavior

When a user sends a POR message it should be validated in firestore and generate the message which will be sent to Dualog mock.

Priority

Fast

Size

2

An in-range update of eslint-plugin-promise is breaking the build 🚨

The devDependency eslint-plugin-promise was updated from 4.1.1 to 4.2.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-promise is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

---

Commits

The new version differs by 6 commits.

• 5b935bd 4.2.1
• 9017a70 4.2.1
• 254c0fd 4.2.0
• 3f2c61d Merge pull request #136 from ota-meshi/fix/no-return-wrap
• 57267ca Add testcase
• d8b9206 Fixed that no-return-wrap does not work if type is not "ExpressionStatement".

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Add mock boat to new users

For users to able to send messages they need to have a boat registered. This would be provided by Dualog. For now we have a mock boat provided by Dag Frode.

As of now only two users have been fixed manually. Manual labour is not wanted.

Expected Behavior

When a new user signs up firebase should automatically create a new boat to that userId. This needs to happen after the function that creates the user document.

Priority

Fast

Size

1

An in-range update of @google-cloud/functions-emulator is breaking the build 🚨

The devDependency @google-cloud/functions-emulator was updated from 1.0.0-beta.5 to 1.0.0-beta.6.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@google-cloud/functions-emulator is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

---

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

🐛 GS and ME are not validated

Expected Behavior

Both GS and ME fields should be validated correctly.

Current Behavior

They are not.

Possible Solution

The problem is, that these fields are dependent on others. Dualog's servers will probably handle this, so we do nothing 👼

An in-range update of babel7 is breaking the build 🚨

There have been updates to the babel7 monorepo:

• • The devDependency @babel/cli was updated from 7.4.4 to 7.5.0.

• The devDependency @babel/core was updated from 7.4.5 to 7.5.0.
• The devDependency @babel/preset-env was updated from 7.5.0 to 7.5.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the babel7 group definition.

babel7 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

---

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴