eclipse-ee4j/glassfish-security-plugin

glassfish-security-plugin's Issues

Merge 1.0.11-BRANCH to master

Please merge this release branch to master and delete it.

https://github.com/eclipse-ee4j/glassfish-security-plugin/compare/1.0.11-BRANCH?expand=1

Fix compatibility with JDK17

[ERROR] Failed to execute goal org.glassfish.build:command-security-maven-plugin:1.0.12:check (default-check) on project config-types: Error loading config beans: java.lang.RuntimeException: org.apache.maven.plugin.MojoExecutionException: Error analyzing java/lang/Object: Unsupported class file major version 61 -> [Help 1]

TypeProcessorImpl.java leaves file open - causes failure in windows build of glassfish v5

Glassfish - https://github.com/javaee/glassfish.git,
fails to build on Windows 10 and has refused to build since prior (1-2 months) to my first notice in 12/2017.
I have debugged the cause - and have tested a fix that works for me on windows.

The cause is that a file is left open by this plugin that results in an error in a different plugin used in the build of glassfish.

I can provide much detail if required and have emailed the report of the issue to [email protected] with subject 'gfv5 window 10 build fails with latest maven and jdk 8' .

from that email,

This is an update of the below previous post in Dec/2017.

Glassfish still does not build on windows 10 64 bit with java 8 and maven 3.5.2.

This afternoon I determined the reason and a fix.

The reason the default file cannot be deleted is that it is open in windows.
file: glassfish\nucleus\hk2\hk2-config\target\classes\META-INF\hk2-locator\default
It gets opened in the command-security-maven-plugin project code,
from the repo https://github.com/javaee/command-security-maven-plugin.git

The file I changed is command-security-maven-plugin\src\main\java\org\glassfish\module\maven\commandsecurityplugin\TypeProcessorImpl.java .
The method is : private List findInhabitantsInModule(final BufferedReader br) throws IOException is passed the BufferedReader br
that has the file open. When the method returns the file is still open. I determined it was safe to call br.close(); before the return of the method,
and after adding the br.close call I can now successfully build Glassfish.
snippet:
}
br.close(); //newly added
return result;
} // last line of method

Place holder issue for Pull Request 4

This is a place holder issue for Pull request from javaee/command-security-maven-plugin#4

o.g.b:command-security-maven-plugin:1.0.11 not available in maven-central

Can 1.0.11 be promoted to central from staging?

Please release 1.0.12 to central

https://jakarta.oss.sonatype.org/content/repositories/staging/org/glassfish/build/command-security-maven-plugin/1.0.12/

releasing new glassfish security plugin

updating the asm lib to 7.1 needs a new release to make the change effective. Who can do the release?
TIA,
rlfnb

Place holder issue for Pull Request 3

This is a place holder issue for Pull request from javaee/command-security-maven-plugin#3

`:print` throws `NPE` when select modules are built

To reproduce use for example glassfish (a364892e1) and execute from top-level directory:

$ mvn install -pl nucleus/admin/util,appserver/jms/admin command-security:print

which results in

[INFO] 
[INFO] --- command-security-maven-plugin:1.0.15:print (default-cli) @ admin-util ---
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for admin-util 7.0.1-SNAPSHOT:
[INFO] 
[INFO] admin-util ......................................... FAILURE [ 27.678 s]
[INFO] JMS admin .......................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  32.518 s
[INFO] Finished at: 2022-12-23T15:52:28+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.glassfish.build:command-security-maven-plugin:1.0.15:print (default-cli) on project admin-util: Execution default-cli of goal org.glassfish.build:command-security-maven-plugin:1.0.15:print failed: Cannot invoke "org.apache.maven.project.MavenProject.getBasedir()" because "execRoot" is null -> [Help 1]
[ERROR] 

Please push tag used to produce 1.0.12

https://jakarta.oss.sonatype.org/content/repositories/staging/org/glassfish/build/command-security-maven-plugin/1.0.12/

Place holder issue for Pull Request 1

This is a place holder issue for Pull request from javaee/command-security-maven-plugin#1