eddiesigner / sketch-map-generator Goto Github PK
View Code? Open in Web Editor NEWSketch plugin to fill a shape with a map generated from a given location using Google Maps and Mapbox
License: MIT License
Sketch plugin to fill a shape with a map generated from a given location using Google Maps and Mapbox
License: MIT License
When I released feature 'dynamic map', I specially reminded you, then that's the second time plagiarism without any mention.
Your commit on 20 Aug 2017 copied my commit on 11 Aug 2017
Same project structure and some same code, just change method or parameter name.
Now it happened again. This time you remove my control-index-design, but not change file name, and I can still find the similar code.
As we all know, we are in an open source community, you can copy and use any code in MIT, but just copy and change method or parameter name, and then make it as your own product, that would make author uncomfortable, and is not a good practice.
Hey guys,
I'm having a small issue with your plugin. My steps are the same from your tips:
Create a shape and select it.
Run the Map Generator Plugin:Google Maps
Plugins > Map Generator > Generate a Map using Google Maps
And what I'm getting after these steps is blank shape—without map.
What's wrong? I've re-installed Sketch, Plugin and update everything.
It stopped working for me, I think it was after a Sketch update.
You started this project earlier than me, I admit you are the first one. But you said 'The structure of my code is like that since long time ago', it's not true definitely.
Actually you project just has one code file 'script.cocoascript' until your commit on 20 Aug 2017. After your reconstruction, new project got to be the same structure, same file name, same index-control-design with mine. You said your google map code file should be named 'google.js' definitely
, but not all the utility code file should be named 'common.js', actually engineers usually name it 'utils.js' or 'tools.js'. I can find several 'coincidence' in your commit. So you see, there are so many choices, you always select the most similar one. If you still insist that's coincidence, I can just said 'hehe'.
I think your new feature is based on the post you mentioned, but your commit on 20 Aug 2017, I still think it's not just by yourself. But you are right, I should stop arguing about that, it's meaningless, after all, open source is the community, the code is only a small part.
BTW, if you think your are right, why set the last issue to limited conversation, others would judge it by their common sense if I talked nonsense.
Anyway, best wish to you.
Hi –
Plugin interface works perfect with preview, but hitting Generate has no effect, the selected shape remains empty (but the layer name is updated to the address)
Followed steps to copy entries in Console.app
Text file attached
console.txt
Sketch v58
Map Generator 3.5.4
OS X 10.15.2
Maybe CartoDB Maps, Mapbox, Nokia, TomTom?
Hi,
I tried this :
brew install ffmpeg
brew link ffmpeg
gifme shows in plugins but after select gif file nothing happens.
The Sketch Plugin Manager is an amazing project, combining the best of all plugin managers that came before it:
The instructions that your users would need in order to instal Sketch Map Generator via Sketch Plugin Manager are:
Installation via [Sketch Plugin Manager](https://mludowise.github.io/Sketch-Plugin-Manager/):
1. In the 'Catalog' tab of the Sketch Plugin Manager window, click in the 'Search' field and type 'Map Generator', to filter the list.
2. You will see the 'Sketch Map Generator' plugin listed at the top of the list. Click the 'Instal' button inside it.
Adding these instructions would greatly help popularise and support the project.
Using the latest beta (47).
From version 52 onwards, Sketch now supports custom Data sources, which allow us to populate a layer with text and image from pre-defined sources. It would be great if the Map Generator plugin was provided as a custom Data source.
Is it perhaps possible to remove Google watermarks?
First off love the plugin! Incredibly useful.
One thing that would be great though is retina support. When designing @2x there's no way to stop the maps looking blurry, so I have to resort to screenshoting Google Maps on my retina display.
Hi there. I keep getting a message "There was a problem, please check the address settings." But Google maps works fine.
Adding a command that looks for the location data from the layer's metadata (instead of a dialog) would enable dynamically generating maps from real data.
i am running sketch 41.2, and whenever i run the plugin it says style cannot be applied??
any thoughts?
Originally posted by @ShorryJK in #23 (comment)
The text size is much larger than a real Google map. It is as though the image is zoomed in 200%.
I have tried running Sketch and the plugin on a retina and non-retina screen, and it is the same.
I am designing a map-centric interface and your plugin has served me greatly in this. One thing I am missing, though, is that it has a strong limitation on the size of the tile it can produce. I design on a canvas of 1440x900, would it be possible to produce a continuous image that has that size?
Right now I am working around the limitation producing different tiles and overlapping them, but it's a bit of a petty workflow and I am wondering if it can actually be automised.
Thanks!
Hi there,
I just downloaded your plugin but looks like its not working on this operation system. Looks like it is not pulling the location when I want to generate the map.
Thanks,
Aleks
I input my token and username, however the styles that are displayed when I try to generate a map are not my personal styles, I am not sure if I am doing something wrong or it doesn't work?
First of all thanks for this plugin, works awesome and it saves a lot of screenshooting!
This is just a suggestion, how about integrate this with snazzy maps themes (https://snazzymaps.com/) to allow style customisation of map?
For what I can see you're getting a static image from google maps API. From the documentation you can pass a style object to the url for styling. You can get that object from snazzy maps api. 💥
Probably isn't so linear as I think, but is a starting point.
This would be great to get maps with the look & feel of your app, taking of labels and other designer stuff...
Once again, many thanks! Keep shipping!
Hi, my colleague introduced me to this awesome plugin.
But unfortunately I can't generate and can't see the preview modus.
I use Sketch version 60.1
Thanks in advance for your help :)
Very helpful plugin, thank you! For certain aspect ratios of shape layers however, the plugin seems to generate the following error: "There was a problem. Please check the address settings." The fix appears to be to use a different size of shape layer, and then rescale the shape after the map has been generated.
When I try generating a map using the Mapbox option,
it pops up an error message that reads "There was a problem, please check the address settings".
That of Google Maps works just fine.
I only happen to prefer the Mapbox.
I'll appreciate if there's a way around this.
Hey, Loved your plugin... i use it very offen. can you please add support to generate Bing Maps also.
Hi
Thanks for this plugin, I adore it.
I hope you can create a shortcut to re-create a map with the same options as the last map generated.
While I am previewing my map I can see the map pins but when I generate the image they disappear. Why is that?
Also, is there a way to customize the pins to use logos, etc.?
I would also like a way to use multiple pins in the same map, like a company showing how many states or cities they are located in.
Please provide official support for Sketchpacks - this is a project that deserves it. It allows the Sketch plugin developer to keep all their users automatically updated, with no work from their part - updates are delivered automatically from your GitHub repo, when you push to your 'master' branch.
Please have a look their integrations page, so we can get not just automatic version numbering, but also auto-updating!
Hi there!
This is a quick note to remind you that Sketch 45 will include a plugin update system.
It would be awesome if you could add support to it (it's really easy!) before Sketch 45 comes out. Ideally, you should release an update for your plugin while we're still in Sketch 44, so your users will have a nice & easy experience when 45 is released.
For more details, please check http://sketchplugins.com/d/229-updating-plugins and http://developer.sketchapp.com/introduction/updating-plugins/
Thanks in advance!
Hi Mate.
When i try with mapbox its saying "There were an issue, please check the address settings" can u please help me out with this
Every time I've used Map Generator I've had to manually add a map marker symbol on top of the map. While there may be a case where a marker is not needed, chances are in most instances having at least one marker placed already would be welcome.
The ideal solution would be, if the marker were optional, and could be placed as a symbol, on top of the map - at its centre (address location). That way, it could be easily customised or replaced after placing.
It would be fantastic, if the plugin would remember the previously entered address and zoom-level. The snazzy maps style option is great, but entering all information when trying out styles is becoming very time-consuming.
Great plugin!
Google Map Screenshots are generated too big. Strangely it's always exactly 3% extra height.
EDIT:
It's actually pretty random, but in a squarish format.
Would it be possible to allow zoom level to be input at a zoom level of choice also when it comes to the first two decimals or at least to have half-decimal zoom levels (e.g.: 1.5,2.5,etc)?
Nothing happens when I try to generate a map using Mapbox (Google Maps works fine).
The preview area is blank even Google Maps API Key is saved.
Generate function is OK.
I am working on an project in which map views are a core part of the app. It's quite cumbersome to re-copy and paste the same style over and over again.
It would be amazing if there was a way to save a Snazzy Map style as a preset so I can easily create multiple maps and pick the style lightning fast.
Sorry, but can’t provide any other information. Google works as expected. Choosing Mapbox doesn’t show any result.
Hi,
Would it be possible to introduce an align/offset option wherein I could could specify by how much the location I search for should be offset from the centre?
I'm overlaying text on the map layer; the generated map is centred & inserted as image fill on the map layer; I'd like to show the Text on the left while offsetting the map to the right.
I just found this great plugin today, and Google Maps is working fine.
When I tryto use Mapbox I just get an error message:
There was a poblem, please check the adress settings.
I´ve been trying to enter exactly the adress used in the readme "Jagerstraße 16 Linz".
I installed the plugin via Sketchpacks.
It would be great if this plugin can handle maps.
This could be great when designing iOS apps
After updating to Sketch 52, uses google or mapbox yields the error "Shape layer only: Your selection was a “Rectangle”, that is not a shape layer. Please select a shape layer." This error occurs even when I have a basic rectangle selected. I'm guessing they changed something in how layers are identified that interferes with the layer validation that this plugin uses.
Would really appreciate having this fixed. My team and I love this plugin!
It would be great if sketch-map-generator
could support Apple maps.
I have a problem where pasted styles from Snazzy Maps are not rendering correctly. Not sure if I'm doing it right but objects and styles are definitely not displaying right.
Snazzy Maps style 1: https://screencast.com/t/PKQluCjLv
Plugin generated map 1: https://screencast.com/t/yHG9zcNMfb8
When I open the plugin via shortcut or plugins tab - I am not able to click into any of the text input fields. I am running a beta OS and the latest version of sketch so this might be the cause, but I wanted to open an issue so that you were aware.
Sketch Version: 55.2
Mac OS: Catalina: 10.15 Beta (19A501i)
Map Generator: 3.1.0
I tried to capture logs from console.app but I was not able to run the plugin so not sure if that would be helpful for your debugging. Let me know if you think the logs are still helpful for you to debug this issue and I will try to add them in the comments.
Hi,
The plugin does nothing when trying to use it.
Nothing is written on console.
Sketch 50.2
Plugin 3.0
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.