eddiscovery/elitedangerouscore

Elite Dangerous specific submodule

EDDiscovery is a captain's log and 2D/3D map for Elite Dangerous players. Find more information in the EDDiscovery wiki.

For the current release Release Notes

and to Download the latest version (Make sure you pick the .exe installer unless you want the portable version)

Get help and advice on our Discord

EDDiscovery is not affiliated with nor endorsed by Frontier Developments plc, the developers of Elite: Dangerous.

elitedangerouscore's Issues

powerf,basef scope tuck

EliteDangerousCore/EliteDangerous/EliteDangerous/EDCalculations.cs

Line 102 in c0b34ab

return (basev + FSDGuardianBoosterRange) * boost;

tiny tweak, means almost nothing.. found this while reading the code:

before

                double powerf = Math.Pow(MaxFuelPerJump / fuelmultiplier, 1 / PowerConstant);
                double basev = powerf * massf;
                if (fuel >= MaxFuelPerJump)
                {
                    return (basev + FSDGuardianBoosterRange) * boost;
                }

after

                if (fuel >= MaxFuelPerJump)
                {
                double powerf = Math.Pow(MaxFuelPerJump / fuelmultiplier, 1 / PowerConstant);
                double basev = powerf * massf;
               return (basev + FSDGuardianBoosterRange) * boost;
                }

Small log issue when converting+deleting screenshots

If the screenshot conversion settings are set to delete the original .bmp file after converting it, the program log entry for the conversion will have an empty space where the deleted file name should be:

(This should instead be 'Converted X to Y')

---

Based on a quick look at the code, the problem seems to be line 248 at the end of the Convert() method here:

EliteDangerousCore/EliteDangerous/Screenshots/ScreenShotImageConverter.cs

Lines 246 to 250 in 87f4203

	System.Diagnostics.Debug.WriteLine("Convert " + inputfilename + " at " + systemname + " to " + outputfilename);
	logit(string.Format("Converted {0} to {1}".T(EDCTx.ScreenShotImageConverter_CNV), Path.GetFileName(inputfilename) , outputfilename));
	return new Tuple<string, string, Size>(inputfilename, outputfilename, finalsize);

Path.GetFileName(inputfilename) is returning null, presumably because the file at inputfilename's location has been deleted, so the log entry gets an empty space added to it rather than a file path.

This seems like an easy "bug" to fix, but I don't know anything about the codebase so I figured I'd post an issue about it rather than messing something up myself.

Engineering info is missing for 5 engineers

Engineering info is missing for 5 different engineers:

• Chloe Sedesi
• Etienne Dorn
• Mel Brandon
• Marsha Hicks
• Petra Olmanova

I've looked at their definitions, but they explicitly mention this to be automatically generated by a "netlogentry frontierdata scanner", although I was not able to find any reference to it. Any guidance on this, that I can use to submit a PR?