eddyborja/ebphotopages

A photo gallery for iOS with a modern feature set. Similar features as the Facebook photo browser.

Eddy Borja

@eddyborja

Keyboard cowboy. Hackernews reader. Vim user. You know the type.

ebphotopages's Issues

When toggle tags is Off, can display dots replace tags label?

RT please.

Can't write a comment on a 3.5 inch screen.

That's it thx for the amazing work!

plus uipageviewcontroller is complex....T.T

support for handle link url taps in caption text

Wonderfull library, thank you for your effort. I found this method and "attributedCaptionForPhotoAtIndex" and try to used. It's very good for using with HTML attributes like . But when I try to use with Click this... it's not able handle open URL. I checked that part of code and see that using UILabel with setAttributedText.

Is there any plan to adding this functionality for library in near future?

Fix for iOS 6 Compatibility

Is it possible to work on iOS 6?
Thank you so much for your brilliant work :)

Update podscpec

Hi,

First you have done an amazing work on this library.

Can you update pod spec with a new tag version that include the latest library changes because the 0.9.1 tag do not include the following method in EBPhotoPagesDataSource.h

• (BOOL)photoPagesController:(EBPhotoPagesController *)photoPagesController shouldAllowMiscActionsForPhotoAtIndex:(NSInteger)index;

Thank you.

can default select photo when i use in the more photos ?

Hi, Eddy
sorry, my english isn't good.
i use this EBPhotoPages to my app, have an one questions, when i bind 3 photos in the one TableViewCell, i click it, but always begin EBPhotoPages at photo 1, how to set default photo index when i click photo 2... T.T

thank you.
Eric

Can I load videos from web services?

I want to display videos from my webservices and that to in vertical scrolling, is that possible using this library?

anchor view

how to show arrow dynamically but it shows only up words
its urgent thanks in andvance

Lower

How to hide or remove lowerToolbar and lowerGradient.

Thank you.

Possible problem with Apple's Private APIs

My app just got rejected with this message:

Your app uses or references the following non-public APIs:

commentText

Searching my project for this string showed only the classes in your library. This is obviously a false positive from Apple since I used this library for the last couple of months and updated my app with no problems what so ever. You might want to rename the "commentText" method in EBPhotoCommentProtocol and the selectors that reference this method

Is this repo still being mantained?

Hey @EddyBorja, are you still maintaining this control? I would like to use it, but I see lot's of things you use here were deprecated and that's kind of a show stopper to me... Any idea if you'll be able to keep working in this? If not I think it might be a good idea to find someone to transfer the project to :)

Prevent dots from displaying at all?

I'm have a use case where we are not allowing any actions at all on photos being displayed in EBPhotoPages. We've disabled them all via the EBPhotoPagesDataSource instance, but the "..." button is still being displayed in the toolbar, even though there are no associated actions. Is there any way to prevent the dots from being shown in the first place? A button with no actions associated with it provides a poor user experience.

EBPhotoPagesDatasource not called

Hey,

This is kind of weird but i have implemented the following EBPhotoPagesDatasource method in a class that inherit from EBPhotoPagesController and made sure the datasource and delegate are correctly set but it never get called.

I downloaded the master branch and test the demo project, same happens.

• (void)photoPagesController:(EBPhotoPagesController *)controller
  numberOfcommentsForPhotoAtIndex:(NSInteger)index
  completionHandler:(void (^)(NSInteger))handler

In fact when the picture is first shown with the lower toolbar, the number of comment is never displayed, i guess because the call to the datasource method is not call.

Let me know if something wrong on my side.

Cheers

Can load images from URL?

Hi i'm use loading images from URL it's posible use in this library?

`UIActionSheet` has been deprecated.

The action sheets currently being used in EBPhotoPagesFactory were deprecated in iOS 8.3. Could you update to use UIAlertController with style ActionSheet?

should call super

hey guys shouldn't you call super in both viewWillAppear and viewWillDisapper ?

Hide ... if setDisabledDelete

In this situation please remove the ... button as it does nothing.

how can we use this library in swift...

how can we deal with swift?... i am new to this plz help

main grid view

can you please add a main grid view for them or gallery view so the user can select with image he will start to see

Refreshing image

Hello,
First of all thanks for wonderful control.
I have a problem with refreshing images. My app download images from web server with SDWebImage. It shows a placeholder image until the real one is received. The image is embedded in imageAtIndex method. The problem is the real image is not replaced with placeholder image.

- (void)photoPagesController:(EBPhotoPagesController *)controller
                imageAtIndex:(NSInteger)index
           completionHandler:(void (^)(UIImage *))handler
{
    dispatch_queue_t queue =     dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0);     
    dispatch_async(queue, ^{
        MyPhoto *photo = self.photos[index];
        handler(photo.imageView.image);
    });
}

How can I refresh the image? Could you help me please?

How can I show HTTP pictures not local pics ?

I cant find how can I initiate pictures with NSURL

How to remove lower tool bar ?

Hi,
I used EBPhotoPage in my project.Now i'm set all images and get pinch and zoom.But my requirement is no need to show bottom tool bar.I just shown images with their details only.So can handle that functionality.

Thanks,
Sudalaiyandi

Comments lower toolbar button not hidden when comments disabled

There's a bug on this line,

https://github.com/EddyBorja/EBPhotoPages/blob/master/EBPhotoPagesController/EBPhotoPagesController.m#L277

Should be lowerItems not upper.

Displaying photo with correct orientation

How can i've photo display with correct orientation. Is there a key in metadata which can be used?

Removing just the "tagging" aspect of this lib and using it on a photo

Feeling a bit overwhelmed trying to figure out how to extract just the tagging aspect of this library w. out the entire controller. Can you give me a rough idea of how to do this and how I would use it on a regular UIImage?

cannot hide commentsBarButtonItem

Haven't remove commentsBarButtonItem from mutableLowerItems while checking commentsAreViewable.
Please refer to the last line at source code below from EBPhotoPagesController.m

solution:
change [mutableUpperItems removeObject:self.commentsBarButtonItem];
to [mutableLowerItems removeObject:self.commentsBarButtonItem];

• (void)updateToolbarsWithPhotoAtIndex:(NSInteger)index
  {
  NSArray *upperItems = [self.photoPagesFactory
  upperToolbarItemsForPhotoPagesController:self
  inState:self.currentState];

  NSArray *lowerItems = [self.photoPagesFactory
  lowerToolbarItemsForPhotoPagesController:self
  inState:self.currentState];

  NSMutableArray *mutableUpperItems = [NSMutableArray arrayWithArray:upperItems];
  NSMutableArray *mutableLowerItems = [NSMutableArray arrayWithArray:lowerItems];

  BOOL taggingAllowed = [self.photosDataSource respondsToSelector:@selector(photoPagesController:shouldAllowTaggingForPhotoAtIndex:)] ?
  [self.photosDataSource photoPagesController:self
  shouldAllowTaggingForPhotoAtIndex:index] : YES;

  BOOL activitiesAllowed = [self.photosDataSource respondsToSelector:@selector(photoPagesController:shouldAllowActivitiesForPhotoAtIndex:)] ?
  [self.photosDataSource photoPagesController:self
  shouldAllowActivitiesForPhotoAtIndex:index] : YES;

  BOOL commentsAreViewable = [self.photosDataSource respondsToSelector:@selector(photoPagesController:shouldShowCommentsForPhotoAtIndex:)] ?
  [self.photosDataSource photoPagesController:self
  shouldShowCommentsForPhotoAtIndex:index] : YES;

  if([self.photosDataSource photoPagesController:self shouldExpectPhotoAtIndex:index] == NO){
  taggingAllowed = NO;
  activitiesAllowed = NO;
  commentsAreViewable = NO;
  }

  if(taggingAllowed == NO){
  [mutableUpperItems removeObject:self.tagBarButtonItem];
  [mutableLowerItems removeObject:self.tagBarButtonItem];
  }

  if(activitiesAllowed == NO){
  [mutableUpperItems removeObject:self.activityBarButtonItem];
  [mutableLowerItems removeObject:self.activityBarButtonItem];
  }

  if(commentsAreViewable == NO){
  [mutableUpperItems removeObject:self.commentsBarButtonItem];
  [mutableUpperItems removeObject:self.commentsBarButtonItem];
  }