eddyborja/mlpaccessorybadge

A customizable badge for displaying metadata, especially in UITableViewCells. For iOS.

Eddy Borja

@eddyborja

Keyboard cowboy. Hackernews reader. Vim user. You know the type.

mlpaccessorybadge's Issues

pity to know that Potential leak

• (void)drawRect:(CGRect)rect
  1.potential leak of an object stored into 'gradientRef'
  2.potential leak of an object stored into 'colorSpace'

i'm newbie and looking forward you solving it! nice day

Podspec is out of date

Could you update the pod spec with the latest code base? It appears there is a 1.0 in the versions, but the pod spec is still referring to the 0.9 tag. There are a few updates that would benefit users.

Crash in method luminanceValueForColor: when not running in DEBUG mode

This is a weird one and I am having a hard time trying to figure out why it is happening. If I debug my app from within the simulator or on the device, I do not get a crash, but if I install the app as an Adhoc app, I get a crash on line 286 of MLPAccessoryBadge.m. If I return 0 from that method and not allow it to calculate the luminance value, the crash does not occur.

Here is my code:

        self.badgeView = [MLPAccessoryBadge new];
        [_badgeView setCornerRadius:10];
        [_badgeView.textLabel setFont:[GYFonts gothamFontWithSize:10.0f
                                                        andWeight:GYFontWeightMedium]];
        [_badgeView setBackgroundColor:[GYStyles pomegranateRed]];
        [_badgeView setStrokeWidth:0];
        [_badgeView setTextSizePadding:CGSizeMake(10.0f, 0.0f)];
        [_badgeView setBadgeInnerPadding:CGSizeZero];
        [_badgeView setBadgeMinimumSize:CGSizeMake(20, 15)];
        [_badgeView setShadowAlpha:0.0f];
        [_badgeView setHighlightAlpha:0.0f];
        [_badgeView setGradientAlpha:0.0f];
        [_badgeView setTextColor:[UIColor whiteColor]];
        [self.contentView addSubview:_badgeView];

This code is being run inside the init method of my table cell. Just to reiterate, it does NOT crash if I run it in the debugger, it only crashes when I run from an Adhoc build.

0.9 tag vs master

Hi,

I have noticed that master has the setBadgeHidden:YES feature. Can the podspec refer to a new tag with this feature?

Cheers

demo app crashes on launch

2013-12-19 09:32:18.628 MLPAccessoryBadgeDemo[12746:907] * Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '* -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[0]'

this is from xcode 5

Crash in optimized builds

Just ran into a crash in optimized-only builds, caused by the code in luminanceValueForColor:. The alpha value indexes &rgbValues[4] instead of &rgbValues[3]

CGFloat rgbValues[4];
[color getRed:&rgbValues[0] green:&rgbValues[1] blue:&rgbValues[2] alpha:&rgbValues[4]];

should be

CGFloat rgbValues[4];
[color getRed:&rgbValues[0] green:&rgbValues[1] blue:&rgbValues[2] alpha:&rgbValues[3]];

Possible Memory Leak

In accessoryPathInRect: the CGMutablePath doesn't seem to be released.