Giter Site home page Giter Site logo

Comments (2)

AngCamp avatar AngCamp commented on June 20, 2024

There is a similar issue with basically all the code in detectors.py. The code only works if there is nan's present in the data otherwise it breaks. All these functions need to be rewritten to check if there even are any nan values before you filter them out. Ideally a user should be warned about this as well as they may favor a different solution to what you have assumed they would do.

from ripple_detection.

edeno avatar edeno commented on June 20, 2024

Hi @AngCamp ,

The code will work without NaNs. I have verified this by running the code on simulated data which have no NaNs. Can you post the specific error you are getting?

from ripple_detection.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.