Comments (6)
And when you go back to options, the checkbox is still selected?
from instachrome.
Yes, the checkbox is still selected.
Read Later
Text view
Go to unread
Go to starred
Go to archive
Only "Read Later" is checked, yet it doesn't show up in my context menu. :/
from instachrome.
Can you inspect the saved options doing this and tell me the values that are in the table (of course ignore username and password).
Right click on the extension icon, then choose "Manage extensions...", then on the top right click "Developer mode" and then under the Instachrome row, click "background.html" and a small window should pop up. Then choose "Resources" on the top tabs, and then expand "LocalStorage" on the side bar, and click the item with the random numbers and letters. It should show all the option values for the extension. What does it say in "cx_read_later" ?
from instachrome.
Was having the same problem. Quick poke around in background.js and I found that the function was
if($.db('cx_read_later') === '1') {
chrome.contextMenus.create({
title: 'Read later (send to instapaper)',
contexts: ['link'],
onclick: function(data, tab) {
readLater({id: tab.id, url: data.linkUrl}, null, 'contextual');
}
});
}
when it should have been
if($.db('cx_read_later') === '1') {
chrome.contextMenus.create({
title: 'Read later (send to instapaper)',
contexts: ['page'],
onclick: function(data, tab) {
readLater({id: tab.id, url: data.pageUrl}, null, 'contextual');
}
});
}
Not on a machine with Git at the moment or I'd fork the fix.
from instachrome.
Ah I see the problem then. I implemented the Read Later context option for links only. People was asking for save pages without opening, so you need to click a link for the menu option to show up. But you're right, it makes sense to have the option for the current page as well. I saw your pull request, will add it but with an extra configurable option for that. Thanks.
from instachrome.
Oooh.. I didn't know that was how it functions! A little note in the options page could be helpful. :)
from instachrome.
Related Issues (20)
- Default Icon with Chromed Icons Selected.
- Feature Request: Integrate with Instapaper Folders HOT 2
- Randomly saving Facebook home page HOT 3
- Feature Request: Keyboard Shortcut for TextView HOT 4
- Backspace bleeds through in text fields HOT 3
- Show number of unread items in badge HOT 5
- Disable auto close for google reader. HOT 3
- Mark as read when closing. HOT 3
- Work with Google Reader like the "Read it Later" bookmark HOT 3
- Wrong page title when adding from context menu. HOT 1
- License HOT 5
- "Read Later" function doesn't work behind Active Directory proxy with authentication HOT 2
- Why was it removed from store? HOT 6
- Configuration is not saved HOT 5
- Instapaper doesn't support Chrome v6.0.447.0 dev HOT 5
- Not setting keyboard shortcut causes any text entry to save to Instapaper HOT 4
- Text View Fix HOT 1
- Bookmarklet works with NYBooks.com, Instachrome extension does not. HOT 2
- Improvement: Right Click Link Save HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from instachrome.