Giter Site home page Giter Site logo

Comments (6)

edgarjs avatar edgarjs commented on August 17, 2024

And when you go back to options, the checkbox is still selected?

from instachrome.

zernyu avatar zernyu commented on August 17, 2024

Yes, the checkbox is still selected.

Read Later

Text view

Go to unread

Go to starred

Go to archive

Only "Read Later" is checked, yet it doesn't show up in my context menu. :/

from instachrome.

edgarjs avatar edgarjs commented on August 17, 2024

Can you inspect the saved options doing this and tell me the values that are in the table (of course ignore username and password).

Right click on the extension icon, then choose "Manage extensions...", then on the top right click "Developer mode" and then under the Instachrome row, click "background.html" and a small window should pop up. Then choose "Resources" on the top tabs, and then expand "LocalStorage" on the side bar, and click the item with the random numbers and letters. It should show all the option values for the extension. What does it say in "cx_read_later" ?

from instachrome.

PJnes avatar PJnes commented on August 17, 2024

Was having the same problem. Quick poke around in background.js and I found that the function was

if($.db('cx_read_later') === '1') {
    chrome.contextMenus.create({
        title: 'Read later (send to instapaper)',
        contexts: ['link'],
        onclick: function(data, tab) {
            readLater({id: tab.id, url: data.linkUrl}, null, 'contextual');
        }
    });
}

when it should have been

if($.db('cx_read_later') === '1') {
    chrome.contextMenus.create({
        title: 'Read later (send to instapaper)',
        contexts: ['page'],
        onclick: function(data, tab) {
            readLater({id: tab.id, url: data.pageUrl}, null, 'contextual');
        }
    });
}

Not on a machine with Git at the moment or I'd fork the fix.

from instachrome.

edgarjs avatar edgarjs commented on August 17, 2024

Ah I see the problem then. I implemented the Read Later context option for links only. People was asking for save pages without opening, so you need to click a link for the menu option to show up. But you're right, it makes sense to have the option for the current page as well. I saw your pull request, will add it but with an extra configurable option for that. Thanks.

from instachrome.

zernyu avatar zernyu commented on August 17, 2024

Oooh.. I didn't know that was how it functions! A little note in the options page could be helpful. :)

from instachrome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.