edgio/ec-sdk-go

EdgeCast Go SDK

ec-sdk-go's Issues

[DEN-59] Get Access Rule (ACL)

[Feature Request] Feature parity with UI for Origin Model

The EdgeCast SDK is missing a number of properties related to TLS settings in the Origin Model. As a result, the Edgecast Terraform provider does not support setting any of the affected options. These options exist in the Edgecast Portal UI, hence I would expect them to be available via the REST API / Go SDK.

Missing options for feature parity are:

• Origin Group settings
  • "Use SNI for HTTPS Origin Requests"
  • "SNI Hostname"
  • "Disallow Self-Signed"
  • "Subject Public Key Info Pin Verification"

Related files:
https://github.com/EdgeCast/ec-sdk-go/blob/main/edgecast/origin/origin_models.go

[DEN-58] Add Managed Rule (Profile)

[DEN-20] Get All Managed Rules (Profiles)

[DEN-95] GO SDK: UPDATE Security Application Manager Configuration

Repo Cleanup and Documentation

Tie up loose ends from repo initialization so it's ready for consumption by our Terraform Provider

[DEN-12] GO SDK: Update Custom Rule Set

[DEN-6] Get All Custom Rule Sets

[BUG] AddRateRule - "IsCaseSensitive" should be IsCaseInsensitive

[Feature Request] Enhance ManagedRule to use singular naming and reference GeneralSettings in ManagedRule

Describe the solution you'd like
ManagedRule has DisabledRules and RuleTargetUpdates. These arrays should hold collections of DisabledRule and RuleTargetUpdate types instead of the plural form.

GeneralSettings is embedded into ManagedRule but should instead be included as a single field.

[DEN-87] Manage All Security Application Manager Configurations

[DEN-57] Add Custom Rule Set

[DEN-14] GO SDK: Update Rate Rule

[DEN-56] Add Rate Rule

[DEN-9] GO SDK: Get Rate Rule

[DEN-72] GO SDK: Delete Custom Rule Set

[DEN-58] GO SDK: Add Managed Rule (Profile)

[DEN-89] Get All Security Application Manager Configurations

[DEN-73] GO SDK: Delete Managed Rule (Profile)

[DEN-18] Get All Rate Rules

[Feature Request] make the underlying http.Client replaceable

Is your feature request related to a problem? Please describe.
In my scenario, I need to replace the underlying http.Client used by the sdk with my company customized http.Client (for emitting mertics, using our company's http mesh, etc).

Describe the solution you'd like
There is a similar feature in aws's sdk here:

// WithHTTPClient sets a config HTTPClient value returning a Config pointer
// for chaining.
func (c *Config) WithHTTPClient(client *http.Client) *Config {
	c.HTTPClient = client
	return c
}

Describe alternatives you've considered
NA

Additional context
NA

[DEN-4] GO SDK: Get Custom Rule Set

[Feature Request]

Is your feature request related to a problem? Please describe.
Analytics unreachable via go sdk.

Describe the solution you'd like
Implement analytics client or expose basic ecclient.

Describe alternatives you've considered
I'm just gonna manually implement http reqs.

[BUG] Add Rate Rule doesn't work for OP Type EM

Describe the bug
The following rate rule does not work:

{
    "condition_groups": [
        {
            "conditions": [
                {
                    "target": {
                        "type": "REQUEST_METHOD"
                    },
                    "op": {
                        "type": "EM",
                        "values": [
                            "POST"
                        ]
                    }
                }
            ]
        }
    ],
    "customer_id": "CEA78",
    "disabled": false,
    "duration_sec": 5,
    "num": 10
}

To Reproduce
Steps to reproduce the behavior.
Call wafService.AddRateRule with:

rule := waf.RateRule{
		DurationSec: 5,
		Num:         10,
		CustomerID:  "CEA78",
		ConditionGroups: []waf.ConditionGroup{
			{
				Conditions: []waf.Condition{
					{
						Target: waf.Target{
							Type: "REQUEST_METHOD",
						},
						OP: waf.OP{
							Type:   "EM",
							Values: []string{"POST"},
						},
					},
				},
			},
		},
	}

Expected behavior
Rate rule is created

Screenshots

[DEBUG] POST https://qa-api.edgecast.com/v2/mcc/customers/CEA78/waf/v1.0/limit
failed AddRateRule: SendRequest failed: {"errors":[{"code":400,"message":"value is not accepted for operator type EM. You must use a values array"}],"success":false}

[DEN-15] GO SDK: Update Access Rule (ACL)

[DEN-1] GO SDK: Get Managed Rule (Profile)

[DEN-77] GO SDK: Delete Access Rule (ACL)

[DEN-93] GO SDK: GET Security Application Manager Configuration

[DEN-94] GO SDK: DELETE Security Application Manager Configuration

[DEN-75] GO SDK: Delete Rate Rule

[DEN-89] GO SDK: Get All Security Application Manager Configurations

[DEN-17] Get All Access Rules

[BUG] updateAccessRule.go using old style invocation of wafService

Describe the bug
wafConfig := waf.NewConfig(*apiToken)
wafConfig.Logger = edgecast.NewStandardLogger()
wafService, err := waf.New(wafConfig)

instead of

idsCredentials := auth.OAuth2Credentials{} // WAF does not use these credentials
sdkConfig := edgecast.NewSDKConfig(*apiToken, idsCredentials)
wafService, err := waf.New(sdkConfig)

[DEN-74] GO SDK: Update Managed Rule (Profile)