ediket/nothinkdb

Functional toolkit for rethinkdb.

nothinkdb's Issues

Example in readme.md does not work

When running the example in the readme as-is, I see the following error:

ValidationError: {
  "table": "user",
  "tableName" [1]: -- missing --
}

ok... after changing table to tableName, the error disappears but nothing else happens (I'm expecting to see the newly created users in the console).

The example from rethinkdb works fine.

Add assert messages in relations

prevent create duplicate n-m row.

node-uuid deprecated

[email protected]: Use uuid module instead

Could we switch from node-uuid to uuid without issue?

Implement unique field.

like this.

Joi.string().meta({ unique: true })

Used in update, create

Table.delete should remove related relations.

Joi empty string

Note that empty strings are not allowed by default and must be enabled with allow('').

https://github.com/hapijs/joi/blob/v8.0.3/API.md#string

Add practical examples.

• basic relation examples
  • hasOne
  • belongsTo
  • hasMany
  • belongsToMany
• extending examples
  • Table
• todo example

Rooms for improvement

Structural

• Table#create and Table#attempt are duplicate.
• Why should Table#insert must be accompanied by Table#create? Schema that is passed in the constructor is only good for Table#create where Table#insert is just a raw rethinkdb insert. Table#insert should call Table#create with schema before inserting in the database.
• Why should link be exposed? Suggestion:

// before
bar: hasOne(fooTable.linkedBy(barTable, 'fooId'))
bar: belongsTo(fooTable.linkTo(barTable, 'barId'))
bars: hasMany(fooTable.linkedBy(barTable, 'fooId'))
// after
bar: hasOne(barTable, 'fooId')
bar: belongsTo(barTable, 'barId')
bars: hasMany(barTable, 'fooId')

• Table#createRelation has inconsistent spec.

// before
fooTable.createRelation('bar', foo.id, bar.id)
// after
fooTable.createRelation(foo.id, 'bar', bar)

• Table#createRelation should accept other object instead other.id. Table#foreignKey can be any other field than pk, and for Table#createRelation of belongsTo, right.table.get(otherPk) must be fetched with foreignKey that is not necessarily pk.

Test

• After tests are run, tables are still there. Whatever created during test must be cleared after.
• Bi-direction relationship is not tested.
• Table#withJoin is not tested with relations as object. I'm not even sure what it does.

Implementation Questions

• In relations.js, what's the point of these:

apply = query => query;

query = r.branch(
  row(right.field),
  query.getAll(row(right.field), { index: left.field }),
  r.expr([]),
);

Code still works with apply and branch.

Create Environment class.

create Environment class.

const env = new Environment();
const fooTable = env.createTable({ ... });

await env.sync()  // sync all tables
env.getTable('foos');  // same as fooTable
env.getTableList('foos');  // [...]

Trivial issue on sync test at Table-test

https://github.com/ediket/nothinkdb/blob/master/src/__tests__/Table-test.js#L252

syncTable is used nowhere in the application or test. Is this necessary?

rethinkdb to rethinkdbdash ?

They are quite similar but the second offer much more options and is developped by someone on the RethinkDB team.

Could it be possible to use this instead?

Make sync return query

Now, Table.sync & Environment.sync receive connection as argument.
Change that functions return query, For it could be used with another ecosystem like rethinkdb-pool.