edvsjo/photocropper

photocropper's Issues

Cropping does not always stick to the aspect ratio

This is most clearly seen in Only-Carol-Dress_383296_65_extra4.jpg where the product does not overrlap with edges, but still contains too little white space.

Handling images that goes outside opposite sides.

As mentioned in #9 (review) this should be a separate issue.

Handling of a product extending adjecent sides is working pretty well. Maybe adding a check before pad_to_fill() is called to determine if padding the image is correct. Instead of padding just choose the biggest correct aspect rectangle that fits within the product rectangle and center that?

Handling empty pixels in .tif or .png

In images that contains empty pixels, the program sees the pixels as black. They should be interpreted as white.

Wrongful handling when product not centered.

Clear when using "images/unedited_uniform_background/Adidas-Advantage-Sneakers_484619_10_extra5.jpg" and most of the images related to Adidas-Terrex-Trail-LS-T-shirt_484421_48

Should add corner checks and handling

Possibly could use inpainting to handle this and upscaling.
https://docs.opencv.org/4.5.2/df/d3d/tutorial_py_inpainting.html
http://iizuka.cs.tsukuba.ac.jp/projects/completion/en/

Works poorly with slight variations in background color

The images with in the Only-Carol-Dress_383296_65 series has some slight variations in the background color.
Possibly fixed by altering the stopping criteria in _only_contains() to be more leaniant.

License and Frontend?

If we were to sell this program to sportmann, I think we need a frontend. The frontend does not have to be fancy but you should be able to select images, choose a name, save file, view the cropped image. I made a very rough sketch of this.

We should also consider adding a license to the app. Im thinking GNU v3 or MIT, depending on what degree of open source we want. We should also check the license of our dependensies to make sure we are not violating anything.

https://choosealicense.com/licenses/mit/
https://choosealicense.com/licenses/gpl-3.0/

Add support for batches of images

Make it possible to define an input (and output?) folder and have the program crops every image.