efitr/core-data-structures

core-data-structures's Issues

Feedback: Third Challenge Submission

• You have a good start on your binary tree, but a lot of the tests fail. Make sure your syntax is right in the is_leaf and height methods.
• Double check how many arguments your methods take. There are a lot of TypeError: method_name takes X positional arguments but Y were given errors.

Feedback: Second Challenge Submission

• You have some good attempts on your stack and queue classes, but some of the methods are failing tests. There were a few bugs in your code, but I was only able to identify a couple: make sure you are returning the right things (peek and pop in ArrayStack), and your ArrayQueue seems to be like a stack (enqueue and dequeue from the same side).
• Nice work on your hash table; the size method is incomplete though. Make sure to change self.size anywhere an item could be added or removed (it needs to be changed in one more spot).
• In your set remove function, you are passing in a variable, index_of_found_member, that was not defined, so an error should appear there. In addition, you are passing in another variable that was not defined, inside of a list, to pop one line 46. If you look at the Python docs, you can see that the brackets will cause an error. Finally, if you are removing an item from the set, how will that affect the size property?

Feedback: First Challenge Submission

• While your all_digits dictionary is helpful in your decode function, and your other dictionary works for you encode function, you may consider another way of getting characters by index using the string library in your encode dictionary. It would be the same speed, but it would look a little nicer in code, and use a little less space.
• Your variable names are very verbose throughout your code, which is usually helpful. You may consider renaming some variables like num_base_any, as its current name does not indicate that it is a string, or modulus_number, to better describe what the number is used for.
• In strings.py, you may want to refactor your code as it appears a lot of it is shared between functions.