egglestn/multiple

Sample project, demonstrating multiple radio buttons in RoR

multiple's Issues

Make more stars go solid

When review 3 is picked, only star 3 stays solid - update the JS so all the stars to the left (0 + 1 + 2) are also solid

README update

The README says

the [JS name field] is an exact match of the hidden field created by RoR in collection_radio_buttons

It is an exact match, but it wasn't created by RoR! It was made up by me.

Seed data

bookId is never used in updateStar

JS updateStar method:

• having calculated bookId as a var, use it in building the name var!

Remove inline boolean

... it's not needed

JS updateStar toggle

In JS updateStar

The toggle on the last line reverses the remove a few lines above. It works fine for different values, but if you click the same score twice, it will stay selected. In effect, once you have clicked, you can never not select a score value.

One approach is to only fire the remove if the score value is different. Alternative approaches welcome, as long as the result works and is fairly succinct

Review accessibility

Is this solution accessible-friendly? Is there a way to make radio buttons accessible-friendly? What changes would it need to make it so?

README!

Repo needs a README

Back button does not show current state

You can use the back button to navigate between pages. If you do, the radio button collections have not been reset, but don't show the current DB state either - so they are misleading

While unfixed, the workaround is to not use the back button