eikek/sharry

Sharry is a self-hosted file sharing web application.

sharry's Issues

add mail notification feature

It would be convenient to send mails with the public upload/download links from within sharry (smtp settings provided).

replace regex based markdown processing

Better have a more reliable impl using a real markdown parser like flexmark-java. It is currently “only” used for processing manual files, but will be of use in future cli client, too.

upload of huge file on windows 10 breaks with 403 Authentication failed

this time at 75%, but also at about 90 or 50% upload of a 2.33 GB file breaks if done in a (fresh installed) Windows 10 (with all updates) with Chrome 81.0.4044.92.

if I upload the same file from a Linux Mint 19.3 Cinnamon with Chromium 80.0.3987.163 all is OK.

I only tested this, because a friend reported that he is not able to upload huge files on my sharry and always getting a 403 error. he is also using Windows 10, tried already Chrome 80.0.3987.162 and Firefox 75.0 and is experiencing this issue on two different machines.

error on web
Error: tus: unexpected response while uploading chunk, originated from request (response code: 403, response text: "Authentication failed.")

nginx log (this nginx is behind a https-offloading nginx), look at error code 403 of last PATCH.

sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:00:08 +0200] "HEAD /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/DW8fLzp9Yvn-1MxmgygdfpX-oirY39f72kB-FLbZHoUUTm2 HTTP/1.0" 404 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:00:08 +0200] "POST /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus HTTP/1.0" 201 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:00:54 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 204 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:01:42 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 204 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:02:29 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 204 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:03:22 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 204 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:03:53 +0200] "POST /api/v2/sec/auth/session HTTP/1.0" 200 304 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:04:09 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 204 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:04:41 +0200] "HEAD /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 200 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:05:44 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 204 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:07:20 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 204 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:08:10 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 204 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:08:23 +0200] "POST /api/v2/sec/auth/session HTTP/1.0" 200 304 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:08:57 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 502 575 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:08:57 +0200] "HEAD /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 200 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:09:45 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 204 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:10:32 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 204 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:11:18 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 204 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:12:06 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 204 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:12:54 +0200] "POST /api/v2/sec/auth/session HTTP/1.0" 200 304 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:12:56 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 204 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:13:46 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 204 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:14:39 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 204 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:15:29 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 204 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:16:19 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 204 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:17:10 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 204 0 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:17:24 +0200] "POST /api/v2/sec/auth/session HTTP/1.0" 200 304 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"
sharry.rekmp.net:80 2a01:4f8:210:322b:d32::96 10.21.11.66 - - [11/Apr/2020:23:18:07 +0200] "PATCH /api/v2/sec/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX/files/tus/5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN HTTP/1.0" 403 24 "https://sharry.rekmp.net/app/upload/CeR3a5qjEBd-v3pJ7hnEW14-1inSKT76Nqp-8S7nsVQxbzX" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36"

nothing in sherry-restserver log (log config is default)

Apr 11 23:00:08 vmcloud sharry-restserver[443]: [ioapp-compute-1] DEBUG s.r.r.t.TusRoutes - Return info for file DW8fLzp9Yvn-1MxmgygdfpX-oirY39f72kB-FLbZHoUUTm2
Apr 11 23:00:08 vmcloud sharry-restserver[443]: [ioapp-compute-0] DEBUG s.b.s.OShare - Created empty file: 5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN
Apr 11 23:04:41 vmcloud sharry-restserver[443]: [ioapp-compute-1] DEBUG s.r.r.t.TusRoutes - Return info for file 5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN
Apr 11 23:08:57 vmcloud sharry-restserver[443]: [ioapp-compute-1] DEBUG s.r.r.t.TusRoutes - Return info for file 5dCd2dZYNHW-AtkM2CAkrHc-KK3xbw4Epff-g77mJoi5tDN

Edit uploads

Would be nice to edit the uploads, at least meta data.

Add user email as `Reply-To` header

Outgoing mails can add a Reply-To header with the email address of the current user.

Download as zip causes 100% cpu load.

Hi,

I'm now successfully running the precompiled sharry binaries in a openjdk8 based docker container. Eventhough session management is still a bit wonky, everything works fine otherwise.

What doesn't work however is the "download as zip" option, which just causes CPU load to spike and stall the application. This doesn't look like a normal dependency issue, so maybe a bug?

requests from some android phones don't parse

Error parsing request Right(GET / HTTP/1.1
Host: 127.0.0.1:9310
Connection: close
User-Agent: Mozilla/5.0 (Linux; Android 7.0; SM-G930F Build/NRD90M) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.111 Mobile Safari/537.36
Upgrade-Insecure-Requests: 1
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8
Referer: android-app://com.google.android.gm
Accept-Encoding: gzip, deflate, br
Accept-Language: de-CH,de-DE;q=0.9,de;q=0.8,en-US;q=0.7,en;q=0.6)
Headers/Referer: class java.util.NoSuchElementException : No value found for 'android-app'
2018-01-04T19:05:47.972+0000 ERROR [sharry-server-ACG-19] sharry.server.main [main.scala:109] Error in request
java.lang.Throwable: Decoding of the request header failed: Headers/Referer: class java.util.NoSuchElementException : No value found for 'android-app'
        at spinoco.fs2.http.HttpRequest$.$anonfun$fromStream$2(HttpRequestOrResponse.scala:218)

cli: processing markdown with anchor links

It seems that anchor links in markdown documents are not correctly processed when publishing using the cli tool.

Unable to run with LC_ALL=C

With default LC_ALL=C program freezes with

Exception in thread "main" java.nio.charset.MalformedInputException: Input length = 1
	at java.base/java.nio.charset.CoderResult.throwException(CoderResult.java:274)
	at java.base/sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:339)
	at java.base/sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178)
	at java.base/java.io.InputStreamReader.read(InputStreamReader.java:185)
	at java.base/java.io.BufferedReader.fill(BufferedReader.java:161)
	at java.base/java.io.BufferedReader.readLine(BufferedReader.java:326)
	at java.base/java.io.BufferedReader.readLine(BufferedReader.java:392)
	at scala.io.BufferedSource$BufferedLineIterator.hasNext(BufferedSource.scala:74)
	at scala.collection.Iterator.foreach(Iterator.scala:941)
	at scala.collection.Iterator.foreach$(Iterator.scala:941)
	at scala.collection.AbstractIterator.foreach(Iterator.scala:1429)
	at scala.collection.TraversableOnce.addString(TraversableOnce.scala:360)
	at scala.collection.TraversableOnce.addString$(TraversableOnce.scala:356)
	at scala.collection.AbstractIterator.addString(Iterator.scala:1429)
	at scala.collection.TraversableOnce.mkString(TraversableOnce.scala:326)
	at scala.collection.TraversableOnce.mkString$(TraversableOnce.scala:325)
	at scala.collection.AbstractIterator.mkString(Iterator.scala:1429)
	at scala.collection.TraversableOnce.mkString(TraversableOnce.scala:328)
	at scala.collection.TraversableOnce.mkString$(TraversableOnce.scala:328)
	at scala.collection.AbstractIterator.mkString(Iterator.scala:1429)
	at sharry.server.App.$anonfun$defaultConfig$2(App.scala:76)
	at scala.collection.immutable.List.map(List.scala:286)
	at sharry.server.App.defaultConfig$lzycompute(App.scala:76)
	at sharry.server.App.defaultConfig(App.scala:72)
	at sharry.server.App.endpoints(App.scala:61)
	at sharry.server.main$.main(main.scala:76)
	at sharry.server.main.main(main.scala)

This works

LC_ALL=en_US.UTF-8 ./sharry-server-0.6.1.jar.sh 

My Java is

openjdk version "11.0.4" 2019-07-16
OpenJDK Runtime Environment (build 11.0.4+11-post-Debian-1deb10u1)
OpenJDK Server VM (build 11.0.4+11-post-Debian-1deb10u1, mixed mode)

command line client

It would be nice to have a command line client for doing things like

sharry publish *.mpg

Additional name for upload

It would be nice to have the possibility to add a name to the upload, which is shown in the upload overview afterwards, so you can identify the upload faster, if you have a lot of uploads.

ps: ty for the great work!

Editing "Validity Time" doesn't modify "Published until" date

Hi,

When I edit "Validity Time" of a share, the date in the field "Published until" is not changed.
I have to unpublish and publish again the share for this, I don't know if this is a normal behavior but others settings are applied on the fly but this one not.

multi drops in "Drop files here"-zone not possible

every time I add some files (e.g. from other directory) by dropping into "Drop files here"-zone, files dropped before get cleared. of course I could drop, submit, drop, submit, drop, submit, ... but for easy workflow would be nice if multidrop is supported and only one final submit needed.

Error during "make" process in sbt console

Hello,

I was trying to translate the webapp and I'm facing this error during make process :

[error] stack trace is suppressed; run last webapp / Compile / managedResources for the full output
[error] (webapp / Compile / managedResources) java.io.IOException: Cannot run program "elm" (in directory "/home/pafzedog/sharry-master/modules/webapp"): error=2, Aucun fichier ou dossier de ce type

What I did is :

• Download zip of repository and extract it
• Installing sbt with last release (1.3.9)
• Translate some text in several View.elm files
• open terminal at "Sharry-master" folder end run "sbt"
• run make or make-deb in sbt shell

Can you help me with this error and tell me if this is this way I can translate a bit the UI ?

Home page redirection

Hello,

For the moment, if one goes to the root url of the app (/), a 404 is display.

Is it possible to redirect the user to the /app/ gui ? This is probably better for end user experience :)

Thanks!

Learn More links goto 404

on https://eikek.github.io/sharry/ the boxes "Learn More" links are invalid.

just remove the final slash.

Update core dependencies

There are new major versions of the core dependencies (fs2, doobie). The update is quite some work, because of how sharry uses these libraries. So there is a good chance for refactoring.

Allow setting a custom url identifier

Allow editing an alias to be reachable under "https://domain/#a=custom_name" instead of "https://domain/#a=OTNzD9cvFAG7aUK8gUo1n".

Would be a nice to have feature, but should only be considered if it is not too time consuming to implement as one could always just use a link shortener (self hosted of course :D ) as a workaround.

Corruption with some mime types

While running 1.2 and 1.3, a MS Word document uploaded via the browser downloads a different set of data. It still looks like a zip file, but it's longer than the original, and the data is completely different.

Example hex dumps from the same file (a docx). Below. Other filetypes (jpg, mp4, surprisingly zip) are unmangled.

##Original

hexdump Document.docx |head -10
0000000 50 4b 03 04 14 00 06 00 08 00 00 00 21 00 a3 ef
0000010 bb 1d 65 01 00 00 52 05 00 00 13 00 08 02 5b 43
0000020 6f 6e 74 65 6e 74 5f 54 79 70 65 73 5d 2e 78 6d
0000030 6c 20 a2 04 02 28 a0 00 02 00 00 00 00 00 00 00
0000040 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
*
0000230 00 00 00 00 00 00 00 00 00 b4 94 cb 6a c3 30 10
0000240 45 f7 85 fe 83 d1 b6 d8 4a ba 28 a5 c4 c9 a2 8f
0000250 65 1b 68 fa 01 8a 34 76 44 f5 42 52 5e 7f df 51
0000260 9c 98 12 92 18 f2 d8 18 ac 99 7b ef 19 d9 d2 60

##Downloaded version

0000000 50 4b 03 04 14 00 06 00 08 00 00 00 21 00 c2 a3
0000010 c3 af c2 bb 1d 65 01 00 00 52 05 00 00 13 00 08
0000020 02 5b 43 6f 6e 74 65 6e 74 5f 54 79 70 65 73 5d
0000030 2e 78 6d 6c 20 c2 a2 04 02 28 c2 a0 00 02 00 00
0000040 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
*
0000230 00 00 00 00 00 00 00 00 00 00 00 00 00 00 c2 b4
0000240 c2 94 c3 8b 6a c3 83 30 10 45 c3 b7 c2 85 c3 be
0000250 c2 83 c3 91 c2 b6 c3 98 4a c2 ba 28 c2 a5 c3 84
0000260 c3 89 c2 a2 c2 8f 65 1b 68 c3 ba 01 c2 8a 34 76

add embed snippet for video/media files

Like on other sites, a html snippet on how to embed a video file is quite useful.

Demo: “Validity time is too long.”

No matter what the input is the reply is always the same, i.e Validity time is too long.

MariaDB database migration

Hello guys,

there seems to be an issue with initializing the database. One of the files does not exist anymore (db/migration/common) and there are some tables with case sensitive names in my setup.

Error servicing request: PATCH /api/v2/alias/upload/XXX/files/tus/XXX from 127.0.0.1 java.sql.SQLSyntaxErrorException: (conn= XXX) Table 'DATABASE.FileChunk' doesn't exist

I think this happens because V1.0.0__initial.sql creates the table filechunk however Sharry is checking for FileChunk while runtime.

This issue might be important.

I fixed this by adding lower_case_table_names = 1 underneath the [mysqld] section in /etc/mysql/my.cnf.

add user documentation

This should be accessible from the webapp. It should include all documentation, not only about use of web application.

sharry 0.6.0 cannot create accounts

Hi,

I just installed a fresh debian 10 vm with zulu openjdk8-jre. Downloaded and ran sharry 0.6.0 with enabled admin account. When trying to create a new user (which btw is a bit confusing at first, that you have to enter the name for the new account in the search field), i get this error:

Some error occured at the server without giving specific error message: { code = 405, message = "Method Not Allowed" }

any idea what might be causing this? Nothing in the console output either...

EDIT1: Same behaviour with postgresql
EDIT2: sudo doesn't help either (not that it should)

edit alias is broken

When editing an alias there are the following problems:

1. Changing the unit doesn't seem to have any effect. It always uses hours.
2. When editing the second time (after clicking ”Back”), the form is unusable: no matter what input is given for time, it says 'invalid input string ""'. Can be worked around by reloading the page.

download links in manual are broken

Because the wrong version string is inserted into the link, the link doesn't work.

webapp still “logged in” although cookie is stale

If the cookie is not valid anymore, the api calls fail. But the webapp ist stil in “logged in“ mode, because elm gets the user from browser local storage. In case an api call fails due to auth failure, it should redirect to the login page.

better page on wrong upload id

If an url like #id=abc points to a non existing upload, a blank page is shown. It should show some basic “not-found / not available” message.

`--pass` option in cli doesn't overwrite `password-command` from config

When the option --pass is given to the cli program, it should override password settings from the config file. It currently doesn't, so if a password-command option is specified, it will be used.

Header parsing error with Google Chrome client

There is an issue in parsing request headers made by, at least, Google Chrome 63.0.3239.132

Error is:
class java.lang.Throwable:Decoding of the request header failed: Headers/Cookie: Expected value with optional parameter, got none

Indeed, Chrome uses the following headers:

GET / HTTP/1.1
Host: REDACTED
Connection: keep-alive
Cache-Control: max-age=0
User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36
Upgrade-Insecure-Requests: 1
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8
Accept-Encoding: gzip, deflate, br
Accept-Language: en-US,en;q=0.9
Cookie:

Note the Cookie header without a value, upon which the parser throws an error.

This incomplete header is not present in Firefox or Safari, and the error is not present either.

Re-add "download as zip"

This feature has been removed, since it is broken (#47); it would be great to have it back again :-).

size check when uploading doesn't work properly

When the size limit is 500K it refuses files with 450K with error Uploading too many or too large files. Return with error.. So the check is not correctly implemented.

handling file-upload errors from resumable

Currently, the user gets an alert() when the file size or number of files exceed the limits.

Email sending fails

Hi,

I have issues with the email notification feature.
After trying to send an email notification the webinterfaces just displays an endless loading animation and the console prints the following error:

2017-10-14T20:15:08.807+0000 DEBUG [sharry-server-ACG-24] sharry.server.email.client [client.scala:44] Createt mime message: Date: Sat, 14 Oct 2017 20:15:08 +0000 (UTC)

From: <censored>

To: <censored>

Message-ID: <29182965.2.1508012108807@3d6622c3cbbd>

Subject: Ready to download

MIME-Version: 1.0

Content-Type: text/plain; charset=us-ascii

Content-Transfer-Encoding: 7bit

Hi,

I have pushed some files for you to download. Visit this page:

https://<censored>/#id=TuVK7_iESPYhC8xlH9f05I2dPawz1QAaq4
Cheers,
max
2017-10-14T20:15:09.642+0000 ERROR [sharry-server-ACG-24] sharry.server.email.client [client.scala:53] Error sending mail: Mail(List(To(Address(<censored>)), Subject(Ready to download)),Hi,

I have pushed some files for you to download. Visit this page:


Cheers,
max)
javax.mail.SendFailedException: Invalid Addresses
	at com.sun.mail.smtp.SMTPTransport.rcptTo(SMTPTransport.java:2064)
	at com.sun.mail.smtp.SMTPTransport.sendMessage(SMTPTransport.java:1286)
	at javax.mail.Transport.send0(Transport.java:255)
	at javax.mail.Transport.send(Transport.java:124)
	at sharry.server.email.client$.$anonfun$send1$7(client.scala:50)
	at sharry.server.email.client$.$anonfun$send1$7$adapted(client.scala:50)
	at fs2.Task.$anonfun$map$3(Task.scala:47)
	at fs2.util.Attempt$.apply(Attempt.scala:12)
	at fs2.Task.$anonfun$map$2(Task.scala:47)
	at scala.util.Either.flatMap(Either.scala:269)
	at fs2.Task.$anonfun$map$1(Task.scala:47)
	at scala.Function1.$anonfun$andThen$1(Function1.scala:52)
	at scala.Function1.$anonfun$andThen$1(Function1.scala:52)
	at scala.Function1.$anonfun$andThen$1(Function1.scala:52)
	at fs2.internal.Future.$anonfun$flatMap$1(Future.scala:17)
	at fs2.internal.Future.step(Future.scala:53)
	at fs2.internal.Future.listen(Future.scala:30)
	at fs2.internal.Future.$anonfun$listen$3(Future.scala:34)
	at fs2.internal.Future.$anonfun$listen$3$adapted(Future.scala:34)
	at fs2.internal.Trampoline.$anonfun$map$1(Trampoline.scala:10)
	at fs2.internal.Trampoline$.run(Trampoline.scala:31)
	at fs2.internal.Trampoline.run(Trampoline.scala:12)
	at fs2.internal.Trampoline.run$(Trampoline.scala:12)
	at fs2.internal.Trampoline$FlatMap.run(Trampoline.scala:18)
	at fs2.Task$.$anonfun$async$4(Task.scala:247)
	at fs2.Strategy$$anon$7.apply(Strategy.scala:69)
	at fs2.Task$.$anonfun$async$3(Task.scala:247)
	at fs2.Task$.$anonfun$async$3$adapted(Task.scala:247)
	at fs2.Task$.$anonfun$ref$2(Task.scala:314)
	at fs2.Task$.$anonfun$ref$2$adapted(Task.scala:294)
	at fs2.internal.Actor.act(Actor.scala:58)
	at fs2.internal.Actor.lastTry(Actor.scala:69)
	at fs2.internal.Actor.$anonfun$scheduleLastTry$1(Actor.scala:67)
	at fs2.Strategy$$anon$5$$anon$6.run(Strategy.scala:60)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Caused by: com.sun.mail.smtp.SMTPAddressFailedException: 550 relay not permitted

	at com.sun.mail.smtp.SMTPTransport.rcptTo(SMTPTransport.java:1917)
	... 36 common frames omitted

The smtp settings should be setup properly (they are even displayed on the manual->configuration page, not sure if this is a security issue by the way)

sharry{
  smtp {
    host = "<censored>"
    port = 587
    user = "noreply@<censored>"
    password = "<censored>"
    from = "noreply@<censored>"
  }
}

The email account is setup and I have another service (ShareLatex) using this successfully with the same settings.

According to my mail service the 550 relay not permitted occurs when there was no SMTP authentication.

I took a quick look at the source code, but I could not spot any issue. I am not familiar with Scala though.

Any ideas what might go wrong here?

Sharry: Build from 0.3.0 Release tag
OpenJDK 8

[Enhancement] Better mobile page

This is a great little program and checks virtually all the boxes for me. My only major gripe is the page doesn't scale well on mobile. The text is so small that you have to zoom in. Would be nice if there was a more mobile-friendly version available. No idea if that's something that's possible and it's not a dealbreaker but would make things much better I think.

download via nginx proxy max 1 GB

due to default value of proxy_max_temp_file_size is 1024m (see http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_max_temp_file_size), every download > 1 GB via nginx proxy (as described in https://eikek.github.io/sharry/doc/reverseproxy#nginx) breaks.

just add
proxy_max_temp_file_size 0;
in location / block.

Database dump command wrong ?

I'm not sure what changed, but I had to use "org.h2.tools.Script" instead of "org.h2.tools.ScriptTool" (stated in the documentation) to create the database dump for migration - should the doc be updated ?

I need some help......

I'm a newbie to Linux field so i don't really understand what i did wrong as i followed the instruction carefully.

Theme support

It would be nice to have a dark theme or user-selectable theme, or even a night-mode toggle available in the UI.

Send password in SMS

Hi , It's possible to add option to send the encrypt password in sms from the web ?
We have a SMS gateway that can recieve massage in GET protocol .
I want when user upload a file and set a password he put the cellular number of the recipient and the racipient get the password in SMS .

ShareX Support

Does this support ShareX? If not, can you add that? Thanks!

range requests including end-of-data fail

Range requests of form a-b fail, if range includes end of data. This is probably due to dropping bytes from the right, which is only possible if the chunk is completely filled. But the last chunk is not.

Translating date

Hi,

it would be nice if date (Created, published on, etc ...) could be translated too.

thanks

[Enhancement] Add a copy link button

Hello,

Adding a "Copy link" button next to "Send e-mail" might be a good idea.
Here are some arguments ;)

• The link created by Sharry is not clickable.

• Some users could use an email client instead of Sharry's "send email" button.

• Some administrators may not be able to install a smtp connector on their server.

What do you think ?

Description text is lost when switching view

Hello,

When you type a description text without saving it and then change the view to "split" or "preview", the text is lost.
I don't know if this is normal behavior, but it's quite surprising the first time.

make the download button more visible

Hi,
I find that the download button is not visible enough, it's far away from the file's title on large screens et very small too.
I'm afraid that end users will be looking for it, it should be more visible by higlighting it by color or intuitive text or something else.

What do you think ?

add note share feature

• the description field can contain markdown which can be used to share notes
• simply allow to not add files
• needs better editor with preview
• needs syntax highlighting
• description could be preprocessed (mustache template) to replace {{1}} etc with url of corresponding attached file

Invalid header value

I got this error recently on Chrome Version 73.0.3683.103 (Official Build) (64-bit)

First time I got this, in the past it was working well.

class java.lang.Throwable:Decoding of the request header failed: Headers: Invalid header value for accept

Maybe linked to #35

Actual configuration displayed in the manual tab

I have double checked, my /#manual/configuration.md displays the actual configuration at the bottom as the "Default configuration".

Regarding my setup:
I build my self a small docker image and I can reproduce the configuration issue when passing the config via env variables

The config displayed in the manual seems to be outdated sometimes (displays older configurations values I already changed to something else), maybe it is cached in the browser
Yes it is cached in the browser and sharry returns 304 not modified (even though it is modified)

SSO compatibility

SSO (for Single Sign-On) is a commonly user authentification system used in organizations. Moreover, Sharry is a tool often used in enterprises, for it's flexibility and the one-side authentification.

Unfortunately, Sharry doesn't not support this system.

The organization I currently work for wants to user it, but without SSO, it can't integrate it easily and with maximum security inside the software.
SSO is quite easy to integrate : the app sends a token to the SSO service provided by the user. Then, the SSO service responds with a token send in the return URL. The app now check the token directloy with the SSO service,n and can check if the user is really authenticated.

It would be awesome to have this compatibility inside Sharry, in the external auth subsystem.

Thanks