eislambey/php-rsmq

PHP implementation of Redis Simple Message Queue

php-rsmq's Issues

Insphpect results

https://insphpect.com/report/5f168d883467d

I just randomly chose a PHP project from my main Github page. Happened to be this one 🤷‍♂️

The tool seems to mope about usage of new Unit() in Islambey\RSMQ\RSMQ. After careful inspection, all the 'utils' could be static functions. There is not state (no $this) in Islambey\RSMQ\Util. Maybe use them like that?

Edit: What do you know. It will also tell you not to use static functions. Example

is there a way to not repeatedly insert same message

when the content is same I would like to insert it only once

totalrecv is counter multiple times for a single message

If a received message was not deleted, and it was delivered again after the vt (visibility timeout), it will result in totalrecv being counted twice for that single message. Eventually you see a situation where in a queue totalrecv is more than totalsent.

Is this on purpose? I am of the opinion that totalrecv should only be counted for them a message has been read and acknowledged (deleted). Alternatively, it may make sense to have another attributes called totalcompleted ?