ekman/luhn-algorithm

Minimal, zero-dependency implementation of the Luhn Algorithm for PHP.

luhn-algorithm's Issues

Update PHP version

Update the compatible PHP version to the highest (still maintained) PHP version.

Include changes such as:

• nullable return types
• Type hinting properties

False negative

The following number is valid (successfully tested with other libraries) but it is detected as invalid by this class : 31997233700020

Typo in calculcateCheckDigit() method name.

There is a small typo in a method name.

LuhnAlgorithm::calculcateCheckDigit();

Add @throws LuhmAlgorithmExceptionInterface to all methods in facade

Add @throws LuhmAlgorithmExceptionInterface to all methods in facade. I don't want to do it without making a major version update due to it theoretically is a backward incompatible change.

Implementation does not work for numbers larger than PHP_INT_MAX

This implementation assumes that that the "number" is an integer when it should be a string of [0-9].

Consider SIM card ICCID numbers which are greater than PHP_INT_MAX 64bit.

    public function testOne(): void
    {
        $luhn = new LuhnAlgorithm();
        $this->assertTrue($luhn->isValid(Number::fromString('89148000003974165685')));
    }
Failed asserting that false is true.

    public function testTwo(): void
    {
        $number = Number::fromString($input = '89148000003974165685');
        $this->assertEquals($input, $number->getNumber());
    }

Failed asserting that 922337203685477632 matches expected '89148000003974165685'.

Intval issues

The use of intval in stringToInteger() limits the number that can be used to the maximum signed integer range of -2147483648 to 2147483647