elasfarc/to-do-list

To Do list

a simple to do list

live version

Built With

• Javascript
• CSS
• Html

Getting Started

To get the local copy of the project up and running you will need to run the following commands on your terminal:

git clone https://github.com/elasfarc/To-Do-list.git

To install all the available dependecies run: npm install

To run this application locally : npm run start:Dev And then open your browser on the port 3000

Authors

👤 Mohammed Al-Asfar

• GitHub: @github

Show your support

Give a ⭐️ if you like this project!❤️❤️❤️

to-do-list's Issues

Code Refactor using DRY,KISS and YAGNI

• These functions never used in your code, remove them
  

  To-Do-list/src/domHelpers.js

  Lines 15 to 25 in 79bd6d8

  	export function taskTobeSwapped(e) {
  	if (e.path[0].nodeName !== 'LI') return e.path[0].parentElement;
  	return e.target;
  	}
  	export function exchangeElements(parent, element1, element2) {
  	const clonedElement1 = element1.cloneNode(true);
  	const clonedElement2 = element2.cloneNode(true);
  	parent.replaceChild(clonedElement1, element2);
  	parent.replaceChild(clonedElement2, element1);
  	}

-You have to update the whole array every time

To-Do-list/src/todo.js

Lines 57 to 68 in 79bd6d8

	updateIndex(updatedIndexArr) {
	updatedIndexArr = updatedIndexArr.map((ele) => ele.title);
	const output = [];
	updatedIndexArr.forEach((element) => {
	output.push(this.#storage.find((ele) => ele.description.trim() === element.trim()));
	});
	for (const i in output) {
	output[i].index = parseInt(i, 10) + 1;
	}
	this.#storage = output;
	this.updateLocalStorage();
	}

• it's better to generalize the domHelpers functions to accept any TODOLIST object
  

  To-Do-list/src/domHelpers.js

  Line 3 in 79bd6d8

  import { todo } from './index.js';