eldruin/pcf857x-rs

Platform agnostic driver for the PCF8574, PCF8574A and PCF8575 I/O expanders written in Rust using embedded-hal

pcf857x-rs's Issues

Pins don't implement Peripheral

Looks like there is a lack of impl DerefMut for pins.
Example:

fn main() -> eyre::Result<()> {
    // It is necessary to call this function once. Otherwise some patches to the runtime
    // implemented by esp-idf-sys might not link properly. See https://github.com/esp-rs/esp-idf-template/issues/71
    esp_idf_svc::sys::link_patches();

    let peripherals = Peripherals::take().unwrap();

    let i2c = peripherals.i2c0;
    let sda = peripherals.pins.gpio5;
    let scl = peripherals.pins.gpio6;

    let config = I2cConfig::new().baudrate(100.kHz().into());
    let i2c = I2cDriver::new(i2c, sda, scl, &config)?;
    let mut expander: Pcf8574<I2cDriver> = pcf857x::Pcf8574::new(i2c, SlaveAddr::Alternative(true, true, true));
    let parts = expander.split();

    fn test<'d>(p: impl Peripheral<P = impl OutputPin> + 'd) {
        todo!()
    }
    
    test(parts.p0); // doesn't work
}

Error:

error[E0277]: the trait bound `P0<'_, Pcf8574<I2cDriver<'_>>, I2cError>: DerefMut` is not satisfied
  --> examples/uln2003_via_pcf8574.rs:42:10
   |
42 |     test(parts.p0);
   |     ---- ^^^^^^^^ the trait `DerefMut` is not implemented for `P0<'_, Pcf8574<I2cDriver<'_>>, I2cError>`
   |     |
   |     required by a bound introduced by this call
   |
   = help: the following other types implement trait `Peripheral`:
             AnyIOPin
             AnyInputPin
             AnyOutputPin
             Modem
             ADC1
             ADC2
             CAN
             Gpio0
           and 46 others
   = note: required for `P0<'_, Pcf8574<I2cDriver<'_>>, I2cError>` to implement `Peripheral`
note: required by a bound in `test`
  --> examples/uln2003_via_pcf8574.rs:38:25
   |
38 |     fn test<'d>(p: impl Peripheral<P = impl OutputPin> + 'd) {
   |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `test`

Use u32 as input for PCF8575 instead of u16

PCF8575 has 18 output pins, so u16 doesn't have enough bits for that. A workaround is to set through an array, but it's just a workaround.

Implement fallible OutputPin/InputPin traits

See rust-embedded/embedded-hal#95 and rust-embedded/embedded-hal#108

Offer embedded-hal Pin interface

A split() method should be added that returns the GPIO pins broken into individual generic embedded-hal Pins.
Examples of this are:

• https://github.com/japaric/stm32f103xx-hal/blob/687dc4b2eda17ec20f5a6fd8ffe411297eaef9d1/src/gpio.rs#L81
• https://github.com/therealprof/nrf51-hal/blob/0ea22ead03143c2ae16cf059f08390f71fa71577/src/serial.rs#L69