Giter Site home page Giter Site logo

Comments (5)

danirabbit avatar danirabbit commented on June 10, 2024

Yes, this happens as a consequence to revision 78, which belongs the me. On some captive portals there is important information displayed on the page after you are logged in,such as credit card transaction information or duration. It should not close.

Launchpad Details: #LPC Zisu Andrei - 2016-08-06 21:23:16 +0000

from capnet-assist.

danirabbit avatar danirabbit commented on June 10, 2024

I will get around to removing the alert view from my retires brach, which brings several improvements, such as the window not showing when it's not necessary me (which still bugs me as hell)

Launchpad Details: #LPC Zisu Andrei - 2016-08-06 21:24:53 +0000

from capnet-assist.

danirabbit avatar danirabbit commented on June 10, 2024

Please don't change the status. I'd prefer to have UX team weigh in here

Launchpad Details: #LPC Daniel Fore - 2016-08-06 22:38:41 +0000

from capnet-assist.

danirabbit avatar danirabbit commented on June 10, 2024

Generally, the captive portal confirmation page will do that. But I agree with you.

Launchpad Details: #LPC Zisu Andrei - 2016-08-07 09:15:43 +0000

from capnet-assist.

cassidyjames avatar cassidyjames commented on June 10, 2024

It seems like the Android captive portal sign-in automatically closes when there's a connection or when the connection changes (see #5), so I am unsure if networks have "important" information displayed after a connection is made. I'd be curious to see examples of such networks as well as the behavior of other OSes. But I can think of two solutions:

  1. Restore the close-on-success flow. This is even explicitly mentioned in the copy at capnet.elementary.io, so it's what I lean towards. It would also resolve the issue where a network appears to be captive and then successfully connects, so you're left with a seemingly random capnet window with that page open.

  2. If we want to keep the window open, we could add an infobar with a message like, "You’re connected! You can safely close this window.”

Actually, in combination with the second option, could we automatically close the window only if it successfully loads capnet.elementary.io? That might nicely solve most cases. Thoughts from @elementary/ux?

from capnet-assist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.