Giter Site home page Giter Site logo

capnet-assist's People

Contributors

bagjunggyu avatar cassidyjames avatar codygarver avatar colindemian avatar comradekingu avatar danirabbit avatar davidmhewitt avatar dependabot[bot] avatar elementarybot avatar gre0j avatar hugok79 avatar ihorhordiichuk avatar jendamarek avatar josprachi avatar lemonboy avatar lenemter avatar marcin-serwin avatar matzipan avatar nasserbinlaboun avatar nathanbnm avatar p-bo avatar pdby avatar queeup avatar ricotz avatar ryonakano avatar spinatelli avatar strebski avatar tomiohl avatar weblate avatar yarons avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

capnet-assist's Issues

"You're connected"-Window pops up after starting/stopping docker container

What Happened?

Everytime I start a docker container, the "You're Connected" Window shows up, which gets really annoying after a while.

Steps to Reproduce

Start a docker container.

For example:
docker run -it debian:stretch /bin/bash

Expected Behavior

Nothing visible to the user should happen.

OS Version

6.x (Odin)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

Low contrast background in AppCenter

What Happened?

image
image

Steps to Reproduce

  1. Open AppCenter
  2. Open Capnet Assistant page

Expected Behavior

Not white text on white background

OS Version

7.x (Early Access)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

support for webkit2gtk-4.1

Starting with GNOME 43, some core components of the desktop have been ported to libsoup-3, which apparently brings a lot of new features, including HTTP/2 support. However, applications and libraries cannot load both libsoup-2.4 and libsoup-3 in the same process, as this is unsupported and will crash the application immediately.

The elementary Captive Portal Assistant will also be affected this change eventually, but at least not immediately. It links against webkit2gtk-4.0, which is only compatible with libsoup-2.4, but since it will remain available, at least this project will continue to build and work on GNOME 43. However, webkit2gtk-4.0 will be removed by upstream GNOME in the near-to-mid-future, so capnet-assist needs to support webkit2gtk-4.1 sooner rather than later.

Additionally, if one of the other GNOME libraries that's linked to by capnet-assist gets ported from libsoup-2.4 to libsoup-3, it will also be in trouble even earlier than the webkit2gtk-4.0 removal date, as building against a library that only supports libsoup-3 and webkit2gtk-4.0 will either not work or result in non-functional application binaries.

Strange white log in window appears after resume from suspend.

Strange white log in window appears after resume from suspend. If I close this window and suspend again it appears again after resume. I don't know where this bug report belongs. Thats why I opened it on elementary os. If you know where it belongs please put it right place.

Launchpad Details: #LP1637207 Özgür BASKIN - 2016-10-27 13:46:40 +0000

Ninja error

What Happened?

The meson build command works sucessfully for me with no error messages. But when trying to install using ninja this error message shows up for me: "ninja: error: loading 'build.ninja': No such file or directory"

Steps to Reproduce

1- Runned meson build --prefix=/usr command.
2- Use ninja related command within this folder, e.g: "ninja test", "ninja install".

Expected Behavior

The expected output was to be able to run the test command and the install command sucesfully

OS Version

Other Linux

Software Version

Compiled from git

Log Output

No response

Hardware Info

No response

Add Linter to CI

Update CI process for capnet-assist to include a vala-lint step.

Pops up in my own home network

What Happened?

The captive portal assistant pops up repeatedly in my own home network. Alone today i had to close it 17 times in the last 3 hours. My connection is working fine i think as i have no problems browsing the internet and streaming music.

Steps to Reproduce

  1. be in my home network

Expected Behavior

It does not pop up in a home network

OS Version

6.x (Odin)

Software Version

Latest release (I have run all updates)

Log Output

How to get log output for this? Is it running in the background? If i start it in the command line, it pops up. I want the logs of when it popped up unexpected.

Hardware Info

No response

Feedback is delayed

What Happened?

When I successfully join a captive network through capnet-assist, I'm redirected to the network's page telling me I'm connected (not https://capnet.elementary.io/). I have to manually close the window because it does not auto-close, but then 15-30 seconds later a new capnet-assist window shows up in the foreground to tell me I'm connected (this time showing https://capnet.elementary.io/). It interrupts my browsing to give me information I already have.

Steps to Reproduce

  1. Connect to a captive network through capnet-assist
  2. Immediately close the window as soon as you're connected
  3. Enjoy the internet
  4. Get interrupted by capnet-assist opening a new window to tell you you're connected

Expected Behavior

I think the window should be closed automatically as soon as you're connected to the network. If there is a reason for the huge delay (maybe it takes some time to detect that connection was successful) and you detected the user manually closed the window, then don't open a new one to show "You're connected": either just send a notification, or don't do anything at all because the user already figured out he's connected?

(anyway thanks for your hard work on elementary!)

OS Version

6.x (Odin)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

build CFLAGS are overridden with "-ggdb" only

The line

set (CMAKE_C_FLAGS "-ggdb")
in the CMakeLists.txt file overrides all the build system's default CFLAGS, which results in broken + insecure + un-hardened builds that don't respect the operating system's defaults.

Please remove that line, or replace it with someting like

set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -ggdb")
if you really really need the "-ggdb" flag.

Launchpad Details: #LP1664680 Fabio Valentini - 2017-02-14 19:37:43 +0000

meson build fails due to wrong contents of LINGUAS file

For example, the "aa" locale is present in the LINGUAS file but there are no translations present for it, which leads to the following error in meson:

+ /usr/bin/ninja install -v -j16 -C x86_64-redhat-linux-gnu
ninja: Entering directory `x86_64-redhat-linux-gnu'
[0/1] /usr/bin/python3 /usr/bin/meson --internal install /builddir/build/BUILD/capnet-assist-0.2.1+git171002.200931.a25dfffc/x86_64-redhat-linux-gnu/meson-private/install.dat
msgfmt: error while opening "/builddir/build/BUILD/capnet-assist-0.2.1+git171002.200931.a25dfffc/po/aa.po" for reading: No such file or directory
Traceback (most recent call last):
  File "/usr/bin/meson", line 37, in <module>
    sys.exit(main())
  File "/usr/bin/meson", line 34, in main
    return mesonmain.run(sys.argv[1:], launcher)
  File "/usr/lib/python3.6/site-packages/mesonbuild/mesonmain.py", line 312, in run
    sys.exit(run_script_command(args[1:]))
  File "/usr/lib/python3.6/site-packages/mesonbuild/mesonmain.py", line 279, in run_script_command
    return cmdfunc(cmdargs)
  File "/usr/lib/python3.6/site-packages/mesonbuild/scripts/gettext.py", line 113, in run
    if gen_gmo(src_sub, bld_sub, langs) != 0:
  File "/usr/lib/python3.6/site-packages/mesonbuild/scripts/gettext.py", line 66, in gen_gmo
    '-o', os.path.join(bld_sub, l + '.gmo')])
  File "/usr/lib64/python3.6/subprocess.py", line 291, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['msgfmt', '/builddir/build/BUILD/capnet-assist-0.2.1+git171002.200931.a25dfffc/po/aa.po', '-o', '/builddir/build/BUILD/capnet-assist-0.2.1+git171002.200931.a25dfffc/x86_64-redhat-linux-gnu/po/aa.gmo']' returned non-zero exit status 1.

I have no idea why the travis build works despite this.

Unify the name of the app

The name of the app does not seem to be unified.

In the appdata and desktop file, it is written as "Captive Network Assistant":

Name=Captive Network Assistant

<name>Captive Network Assistant</name>

However, in the codes of this repo, the README.md and in the Open Source page of the website it is written as "Captive Portal Assistant."

The name is not unified and this might make users confusing. I think we should unify the name of the app to either notation.

Close if network changes

If capnet launches, then I change WiFi networks, capnet should automatically close since it is not longer valid for the new network.

Launchpad Details: #LP1536420 Cassidy James Blaede - 2016-01-21 00:50:20 +0000

Package as Flatpak

This seems like a great example of an app that should be sandboxed, actually

Window stays on foreground

What Happened?

The window showing the login page to the captive network stays on the foreground, I can't dock it or place other windows in front of it.

Steps to Reproduce

  1. Connect to a captive network
  2. Wait for the captive network assistant window to pop-up
  3. Try to bring other apps in the foreground

Expected Behavior

The window should be able to be moved to the background : I store the passwords to the captive networks I have to use in my password manager, but I can't use my password manager because the captive network assistant window takes up the whole space of my 13' Lo-DPI screen. It forces me to lookup the password on another device and have to type it manually which is very inconvenient.

OS Version

6.x (Odin)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

Save window size

Currently, the UI doesn't save the window size and every time you connect to a captive portal you might have to resize the window.

Save the state.

Launchpad Details: #LP1651558 Zisu Andrei - 2016-12-20 19:02:39 +0000

Prefer dark

Problem

White screen with Dark Style enabled in described example situation:
"Some networks can appear to be a captive portal at first, triggering this window, then actually end up connecting. In those cases, you'll see this message and can safely close the window."

Proposal

Use prefers-color-scheme to show dark headerbar and subsequently support a dark color scheme for capnet-assist.css

Prior Art

Project Prefer Dark Style

No feedback mechanism for successful connection

When connecting to a portal, capnet doesn't automatically close anymore. This means there is no longer a feedback mechanism to let you know that you've successfully logged in to the captive portal.

Launchpad Details: #LP1610592 Daniel Fore - 2016-08-06 21:01:24 +0000

Saving credentials

Problem

Capnet doesn't save credentials for a captive portal. For example, on a library, cafe or university wifi, I need to reenter my credentials every time I visit. Capnet should auto-connect to these networks.

Proposal

Capnet should save the credentials for the network and log in automatically the next time it detects said network. If it isn't possible, it should at least autofill the credentials to make the experience more seamless for the user (remove a friction point).

From a privacy point of view, Capnet could ask the user, on the first login, if the credentials should be saved or not.

Prior Art (Optional)

No response

90captive_portal_test: drop insecure PATH elements

The fedora package security check complains about this:

   "code" : "SuspiciousPath",
   "context" : {
      "excerpt" : [
         "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
      ],
      "path" : "/etc/NetworkManager/dispatcher.d/90captive_portal_test"
   },
   "diag" : "Potentially insecure PATH element <tt>/local</tt>",
   "subpackage" : "elementary-capnet-assist"

I think that means it wants /usr/local/sbin and /usr/local/bin removed from the PATH variable.

I guess those PATH entries are there because they are / were useful for testing or debugging ... but for release builds, they should be dropped.

Adding Silesian translation file

Hi, could you add translation files for Silesian?

ISO 639-3: szl
Plurals: nplurals=3; plural=(n==1 ? 0 : n%10>=2 && n%10<=4 && (n%100<10 || n%100>=20) ? 1 : 2);

Thank you!

Build independent binary

Hi!

Is there a way to build capnet-assist app as completely independent binary for Linux desktop systems? I am able to build dynamically linked app as it described at readme file of project but I don't want to install list of additional dependencies.

I attempted to change meson.build file to force use static linking but it's continues to fail (here are a discussion about this way).

There is a modified meson.build file :

project(
    'io.elementary.capnet-assist',
    'vala', 'c',
    version: '2.2.3',
    default_options: 'sysconfdir=/etc'
)

i18n = import('i18n')

add_global_arguments('-DGETTEXT_PACKAGE="captive-login"', '-DGCR_API_SUBJECT_TO_CHANGE', language:'c')

executable(
    meson.project_name(),
    'src/Application.vala',
    'src/CaptiveLogin.vala',
    'src/CertButton.vala',
    'src/TabbedWebView.vala',
    'src/Settings.vala',
    dependencies: [
        dependency('gcr-3', static:true),
        dependency('gcr-ui-3', static:true),
        dependency('gio-2.0', static:true),
        dependency('glib-2.0', static:true),
        dependency('gobject-2.0', static:true),
        dependency('gtk+-3.0', static:true),
        dependency('granite', static:true),
        dependency('webkit2gtk-4.0', static:true)
    ],
    install : true,
    link_args: ['-static']
)

meson.add_install_script('meson/post_install.py')

subdir('data')
subdir('po')

install_data(
    '90captive_portal_test',
    install_dir: join_paths(get_option('sysconfdir'), 'NetworkManager', 'dispatcher.d')
)

And also error stack:

The Meson build system
Version: 0.45.1
Source dir: /capnet-assist-master
Build dir: /capnet-assist-master/build
Build type: native build
Project name: io.elementary.capnet-assist
Native C compiler: cc (gcc 7.4.0 "cc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0")
Native Vala compiler: valac (valac 0.40.8)
Build machine cpu family: x86_64
Build machine cpu: x86_64
Found pkg-config: /usr/bin/pkg-config (0.29.1)
WARNING: Static library 'gcr-ui-3' not found for dependency 'gcr-3', may not be statically linked
WARNING: Static library 'gtk-3' not found for dependency 'gcr-3', may not be statically linked
WARNING: Static library 'atk-bridge-2.0' not found for dependency 'gcr-3', may not be statically linked
WARNING: Static library 'atspi' not found for dependency 'gcr-3', may not be statically linked
WARNING: Static library 'systemd' not found for dependency 'gcr-3', may not be statically linked
WARNING: Static library 'gdk-3' not found for dependency 'gcr-3', may not be statically linked
WARNING: Static library 'wayland-cursor' not found for dependency 'gcr-3', may not be statically linked
WARNING: Static library 'wayland-egl' not found for dependency 'gcr-3', may not be statically linked
WARNING: Static library 'wayland-client' not found for dependency 'gcr-3', may not be statically linked
WARNING: Static library 'epoxy' not found for dependency 'gcr-3', may not be statically linked
WARNING: Static library 'graphite2' not found for dependency 'gcr-3', may not be statically linked
WARNING: Static library 'atk-1.0' not found for dependency 'gcr-3', may not be statically linked
WARNING: Static library 'gdk_pixbuf-2.0' not found for dependency 'gcr-3', may not be statically linked
WARNING: Static library 'gcr-base-3' not found for dependency 'gcr-3', may not be statically linked
WARNING: Static library 'gck-1' not found for dependency 'gcr-3', may not be statically linked
WARNING: Static library 'selinux' not found for dependency 'gcr-3', may not be statically linked
WARNING: Static library 'mount' not found for dependency 'gcr-3', may not be statically linked
WARNING: Static library 'ffi' not found for dependency 'gcr-3', may not be statically linked
WARNING: Static library 'p11-kit' not found for dependency 'gcr-3', may not be statically linked
Native dependency gcr-3 found: YES 3.28.0
WARNING: Static library 'gcr-ui-3' not found for dependency 'gcr-ui-3', may not be statically linked
WARNING: Static library 'gtk-3' not found for dependency 'gcr-ui-3', may not be statically linked
WARNING: Static library 'atk-bridge-2.0' not found for dependency 'gcr-ui-3', may not be statically linked
WARNING: Static library 'atspi' not found for dependency 'gcr-ui-3', may not be statically linked
WARNING: Static library 'systemd' not found for dependency 'gcr-ui-3', may not be statically linked
WARNING: Static library 'gdk-3' not found for dependency 'gcr-ui-3', may not be statically linked
WARNING: Static library 'wayland-cursor' not found for dependency 'gcr-ui-3', may not be statically linked
WARNING: Static library 'wayland-egl' not found for dependency 'gcr-ui-3', may not be statically linked
WARNING: Static library 'wayland-client' not found for dependency 'gcr-ui-3', may not be statically linked
WARNING: Static library 'epoxy' not found for dependency 'gcr-ui-3', may not be statically linked
WARNING: Static library 'graphite2' not found for dependency 'gcr-ui-3', may not be statically linked
WARNING: Static library 'atk-1.0' not found for dependency 'gcr-ui-3', may not be statically linked
WARNING: Static library 'gdk_pixbuf-2.0' not found for dependency 'gcr-ui-3', may not be statically linked
WARNING: Static library 'gcr-base-3' not found for dependency 'gcr-ui-3', may not be statically linked
WARNING: Static library 'gck-1' not found for dependency 'gcr-ui-3', may not be statically linked
WARNING: Static library 'selinux' not found for dependency 'gcr-ui-3', may not be statically linked
WARNING: Static library 'mount' not found for dependency 'gcr-ui-3', may not be statically linked
WARNING: Static library 'ffi' not found for dependency 'gcr-ui-3', may not be statically linked
WARNING: Static library 'p11-kit' not found for dependency 'gcr-ui-3', may not be statically linked
Native dependency gcr-ui-3 found: YES 3.28.0
WARNING: Static library 'selinux' not found for dependency 'gio-2.0', may not be statically linked
WARNING: Static library 'mount' not found for dependency 'gio-2.0', may not be statically linked
WARNING: Static library 'ffi' not found for dependency 'gio-2.0', may not be statically linked
Native dependency gio-2.0 found: YES 2.56.4
Native dependency glib-2.0 found: YES 2.56.4
WARNING: Static library 'ffi' not found for dependency 'gobject-2.0', may not be statically linked
Native dependency gobject-2.0 found: YES 2.56.4
WARNING: Static library 'gtk-3' not found for dependency 'gtk+-3.0', may not be statically linked
WARNING: Static library 'atk-bridge-2.0' not found for dependency 'gtk+-3.0', may not be statically linked
WARNING: Static library 'atspi' not found for dependency 'gtk+-3.0', may not be statically linked
WARNING: Static library 'systemd' not found for dependency 'gtk+-3.0', may not be statically linked
WARNING: Static library 'gdk-3' not found for dependency 'gtk+-3.0', may not be statically linked
WARNING: Static library 'wayland-cursor' not found for dependency 'gtk+-3.0', may not be statically linked
WARNING: Static library 'wayland-egl' not found for dependency 'gtk+-3.0', may not be statically linked
WARNING: Static library 'wayland-client' not found for dependency 'gtk+-3.0', may not be statically linked
WARNING: Static library 'epoxy' not found for dependency 'gtk+-3.0', may not be statically linked
WARNING: Static library 'graphite2' not found for dependency 'gtk+-3.0', may not be statically linked
WARNING: Static library 'atk-1.0' not found for dependency 'gtk+-3.0', may not be statically linked
WARNING: Static library 'gdk_pixbuf-2.0' not found for dependency 'gtk+-3.0', may not be statically linked
WARNING: Static library 'selinux' not found for dependency 'gtk+-3.0', may not be statically linked
WARNING: Static library 'mount' not found for dependency 'gtk+-3.0', may not be statically linked
WARNING: Static library 'ffi' not found for dependency 'gtk+-3.0', may not be statically linked
Native dependency gtk+-3.0 found: YES 3.22.30
WARNING: Static library 'granite' not found for dependency 'granite', may not be statically linked
WARNING: Static library 'gee-0.8' not found for dependency 'granite', may not be statically linked
WARNING: Static library 'gtk-3' not found for dependency 'granite', may not be statically linked
WARNING: Static library 'atk-bridge-2.0' not found for dependency 'granite', may not be statically linked
WARNING: Static library 'atspi' not found for dependency 'granite', may not be statically linked
WARNING: Static library 'systemd' not found for dependency 'granite', may not be statically linked
WARNING: Static library 'gdk-3' not found for dependency 'granite', may not be statically linked
WARNING: Static library 'wayland-cursor' not found for dependency 'granite', may not be statically linked
WARNING: Static library 'wayland-egl' not found for dependency 'granite', may not be statically linked
WARNING: Static library 'wayland-client' not found for dependency 'granite', may not be statically linked
WARNING: Static library 'epoxy' not found for dependency 'granite', may not be statically linked
WARNING: Static library 'graphite2' not found for dependency 'granite', may not be statically linked
WARNING: Static library 'atk-1.0' not found for dependency 'granite', may not be statically linked
WARNING: Static library 'gdk_pixbuf-2.0' not found for dependency 'granite', may not be statically linked
WARNING: Static library 'selinux' not found for dependency 'granite', may not be statically linked
WARNING: Static library 'mount' not found for dependency 'granite', may not be statically linked
WARNING: Static library 'ffi' not found for dependency 'granite', may not be statically linked
Native dependency granite found: YES 0.5
WARNING: Static library 'webkit2gtk-4.0' not found for dependency 'webkit2gtk-4.0', may not be statically linked
WARNING: Static library 'gtk-3' not found for dependency 'webkit2gtk-4.0', may not be statically linked
WARNING: Static library 'atk-bridge-2.0' not found for dependency 'webkit2gtk-4.0', may not be statically linked
WARNING: Static library 'atspi' not found for dependency 'webkit2gtk-4.0', may not be statically linked
WARNING: Static library 'systemd' not found for dependency 'webkit2gtk-4.0', may not be statically linked
WARNING: Static library 'gdk-3' not found for dependency 'webkit2gtk-4.0', may not be statically linked
WARNING: Static library 'wayland-cursor' not found for dependency 'webkit2gtk-4.0', may not be statically linked
WARNING: Static library 'wayland-egl' not found for dependency 'webkit2gtk-4.0', may not be statically linked
WARNING: Static library 'wayland-client' not found for dependency 'webkit2gtk-4.0', may not be statically linked
WARNING: Static library 'epoxy' not found for dependency 'webkit2gtk-4.0', may not be statically linked
WARNING: Static library 'graphite2' not found for dependency 'webkit2gtk-4.0', may not be statically linked
WARNING: Static library 'atk-1.0' not found for dependency 'webkit2gtk-4.0', may not be statically linked
WARNING: Static library 'gdk_pixbuf-2.0' not found for dependency 'webkit2gtk-4.0', may not be statically linked
WARNING: Static library 'lzma' not found for dependency 'webkit2gtk-4.0', may not be statically linked
WARNING: Static library 'selinux' not found for dependency 'webkit2gtk-4.0', may not be statically linked
WARNING: Static library 'mount' not found for dependency 'webkit2gtk-4.0', may not be statically linked
WARNING: Static library 'javascriptcoregtk-4.0' not found for dependency 'webkit2gtk-4.0', may not be statically linked
WARNING: Static library 'ffi' not found for dependency 'webkit2gtk-4.0', may not be statically linked
Native dependency webkit2gtk-4.0 found: YES 2.24.2

~~~
long build command
~~~

/usr/bin/ld: cannot find -lgcr-ui-3
/usr/bin/ld: cannot find -lgtk-3
/usr/bin/ld: cannot find -latk-bridge-2.0
/usr/bin/ld: cannot find -latspi
/usr/bin/ld: cannot find -lsystemd
/usr/bin/ld: cannot find -lgdk-3
/usr/bin/ld: cannot find -lwayland-cursor
/usr/bin/ld: cannot find -lwayland-egl
/usr/bin/ld: cannot find -lwayland-client
/usr/bin/ld: cannot find -lepoxy
collect2: error: ld returned 1 exit status

support for gcr-4

GNOME 43 will be released with a new major version of gcr (gcr-4 vs. gcr-3).

At least in Fedora 37, those two will be packaged separately and installable in parallel, but gcr-3 will not be supported forever. capnet-assist will, at some point, need to add support for, or be ported to, gcr-4.

More context for this change is available on the Fedora development mailing list.

Locked down mode if non-HTTPS or non-verifiable cert

We should add a "locked down" mode that disables downloads, JS, etc. when connecting to a non-HTTPS portal or a portal with an invalid/non-verifiable certificate.

I imagine this being shown to the user as an infobar saying "This page is being loaded over an insecure connection. Scripts and downloads have been disabled. (Re-enable Scripts)" or something.

Launchpad Details: #LP1651604 Cassidy James Blaede - 2016-12-20 23:36:05 +0000

Remove 90captive_portal_test

Since Felipe's branch makes the network indicator launch capnet and nm-applet is no longer a process that we ship, I think we can remove this.

It might be worth reaching out to the MATE folks about this change since I think they're currently using capnet. Either we should just leave this in or we should help them out with a distro patch or something.

Launchpad Details: #LP1573777 Daniel Fore - 2016-04-22 20:18:59 +0000

Fails to load user language

What Happened?

Captive Network Assistant doesn't load user language.

(captive-login:2): Gtk-WARNING **: 01:30:18.738: Locale not supported by C library.
	Using the fallback 'C' locale.
Gtk-Message: 01:30:18.755: Failed to load module "canberra-gtk-module"
Gtk-Message: 01:30:18.756: Failed to load module "canberra-gtk-module"

(process:12): Gtk-WARNING **: 01:30:18.799: Locale not supported by C library.
	Using the fallback 'C' locale.
Gtk-Message: 01:30:18.818: Failed to load module "canberra-gtk-module"
Gtk-Message: 01:30:18.819: Failed to load module "canberra-gtk-module"

Tested on Russian and French locales (both are fully translated in master)

Steps to Reproduce

  1. Change language to not English one
  2. flatpak run io.elementary.capnet-assist

Expected Behavior

The app is translated.

OS Version

7.x (Horus)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.