elementsproject/lightning-charge-client-js

JavaScript client for lightning-charge

lightning-charge-client-js's Issues

Is it secure if I make my api token public with lightning-charge-client-js?

Lightning Charge Client requires to publish api secret like:

// Initialize the client
import ChargeClient from 'lightning-charge-client'
const charge = new ChargeClient('http://localhost:9112', '[API-TOKEN]')

But on Lightning Charge Documents, API token is said as mySecretToken, it sounds API token must be secret. If I put API token on client side, everyone can know my API token. Is it secure?

Initialize the client with remote node

Hello,

I set up a Lightning Charge node on Azure, and I can use the command line to generate invoices, but I am having trouble getting this JS library to work.

This is the code I'm using currently to create to the remote node:

var axios = require('axios');
var url = "https://api-token:<API_TOKEN_HERE>@light.konelabs.com/"
axios.post(url + 'invoice', {
  msatoshi: 100000,
  metadata: {
    customer_id: 123,
    product_id: 456
  }
})
  .then(d => console.log(d.data))
  .catch(e => console.log(e))

But I think I'm setting up something wrong when using this library:

var ChargeClient = require('lightning-charge-client');
const charge = require('lightning-charge-client')('https://api-token:<API_TOKEN_HERE>@light.konelabs.com/', 'https://light.konelabs.com/')
const inv = charge.invoice({ msatoshi: 50, metadata: { customer_id: 123, product_id: 456 } })
inv
.then(i => console.log(i))
.catch(e => console.log(e))

Anyone have an idea on what I'm doing wrong?

Add lightning-network as a topic to this repository

Hello,

This repository is listed on the Awesome Lightning-Network list, which is a collection of useful lightning-network projects. However, it seems that the 'lightning-network' topic is missing from this repository's topics.

Adding the 'lightning-network' topic will help users discover your project more easily and recognize its relevance to the lightning-network ecosystem. To add the topic, please follow these steps:

1. Navigate to the main page of the repository.
2. Click on the gear icon next to "About" on the right side of the page.
3. In the "Topics" section, type 'lightning-network' and press Enter.
4. Click "Save changes."

Thank you for your attention and for contributing to the lightning-network community!

Dependency `superagent-use` fails installation.

Looks like the shesek/superagent-use it's breaking the installation process.