Giter Site home page Giter Site logo

elffriend-dnd / foundryvtt-5eoglcharactersheet Goto Github PK

View Code? Open in Web Editor NEW
10.0 10.0 14.0 2.93 MB

Aiming to reproduce the layout of the print 5e Sheet within foundry

License: MIT License

JavaScript 11.96% Handlebars 50.45% TypeScript 12.96% SCSS 24.63%
foundry-vtt foundryvtt

foundryvtt-5eoglcharactersheet's People

Contributors

akrigline avatar endlesnights avatar p4535992 avatar varriount avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

foundryvtt-5eoglcharactersheet's Issues

Manifest+ media

We should leverage the newly finalized manifest+ media links to show screenshots of the sheet to Bazaar users.

dnd5e 0.99 compatibility

Just dropped, odds of breakage are high.

  • Support new speed data source
  • Add "configure movement speed" button
  • Set "Initiative" to be rollable
  • Add Effects Tab
  • Biography Tab is borked with max-width
  • Something broke with the item images

Does not work at all in V10

Just letting you know. I'm super grateful you keep this module working. It's the only character sheet i can stand. If i had the skills to take it over for you i would

Uncaught (in promise) TypeError: abl is undefined

DnD5e version: 1.5.3
Foundry version: 0.8.9
D&D 5e OGL Character Sheet version: 0.13.0

Due to a recent change in the 5e system, the code on this line now sets ability to undefined, causing a TypeError in rollAbilitySave as the abilityId is not a valid value. I managed to work around this with the following (warning! ugly) code:
let ability = event.currentTarget.textContent.substring(0,3).toLowerCase();
I know for a fact that I'm doing that in the worst and most disgusting way possible (especially as it's language-dependent), but it's at least functional for me until this module gets updated by someone who actually knows JS. I certainly don't.
Thanks!

Passive Abilities?

I haven't seen them on the sheet unless I missed it. But an option to show the passive skills would be nice.

Cannot Activate Module

I had the 5eOGLCharacterSheet installed and working fine. I upgraded Foundry to 7.6 and updated all my modules. I had some errors, but didn't see what they were. When I launched Foundry the 5eCharacterSheet was no longer working and when I look in ManageModules I cannot find it in the list within Foundry.

I uninstalled all modules in SetUp and only installed the 5eCharacterSheet module and it still does not appear within ManageModules within Foundry.

Please help, I love the module and want to continue using it.
ConfigureModules
ManageModules

Feature - On the fly modifier fields like Roll20 OGL Sheet

It would be great to have easy to use quick toggle modifiers like you have on Roll20.

Here's a messy screenshot of what I'm referring to:

image

This allows you to quickly add context-sensitive dice combinations or flat numbers without needing any macros or dealing with Active Effects. Would be great for newcomer converts from Roll20.

Unable to open inventory items/passive features

Discord Report:

I'm using dnd 5e ogl character sheets and none of the passive abilities or inventory on the character sheets are expanding, is this happening for anyone else?
Yeah it doesn't seem to be working even in a game world where it's the only active module

Env: core 0.7.5 and dnd5e 1.1.0

Likely cause: Items without images not expanding.

OGL Sheet still not opening (v. 0.6.2, DND5e 1.20, Foundry 0.7.8)

Opening up the game, I go to preexisting and new tokens, and nothing happens when I double click, but then checking the console, I see this:

d {description: undefined, fileName: undefined, lineNumber: undefined, endLineNumber: undefined, message: "An error occurred while rendering OGL5eCharacterSheet 103: Missing helper: "ogl5e-isEmpty"", …}
description: undefined
endLineNumber: undefined
fileName: undefined
lineNumber: undefined
message: "An error occurred while rendering OGL5eCharacterSheet 103: Missing helper: "ogl5e-isEmpty""
name: "Error"
number: undefined

  (anonymous) @ foundry.js:4481
  Promise.catch (async)    
  render @ foundry.js:4479
  render @ foundry.js:5626
  _onClickLeft2 @ foundry.js:41941
  callback @ foundry.js:36337
  _handleClickLeft2 @ foundry.js:36539
  _handleMouseDown @ foundry.js:36501
  a.emit @ index.js:181
  r.dispatchEvent @ InteractionManager.ts:1106
  r.processPointerDown @ InteractionManager.ts:1307
  t.recursiveFindHit @ TreeSearch.ts:173
  t.recursiveFindHit @ TreeSearch.ts:113
  t.recursiveFindHit @ TreeSearch.ts:113
  t.recursiveFindHit @ TreeSearch.ts:113
  t.findHit @ TreeSearch.ts:200
  r.processInteractive @ InteractionManager.ts:1177
  r.onPointerDown @ InteractionManager.ts:1252

I checked the Discord for others who were having similar troubles, and I saw you suggest to download and activate Compact Character sheet, so I have that installed and active, and it still wont open any sheet using 5e OGL

Make the appearance migration less scary.

We should probably swallow this error.

5e-ogl-character-sheet | error trying to migrate description to appearance TypeError: Cannot read property 'value' of undefined
    at OGL5eCharacterSheet.getData (foundryvtt-5eOGLCharacterSheet.js:228)
    at OGL5eCharacterSheet._render (foundry.js:4499)
    at OGL5eCharacterSheet._render (foundry.js:5153)
    at OGL5eCharacterSheet._render (foundry.js:16718)
    at OGL5eCharacterSheet.render (foundry.js:4469)
    at OGL5eCharacterSheet.render (foundry.js:5619)
    at ActorDirectory._onClickEntityName (foundry.js:16199)
    at ActorDirectory._onClickEntityName (foundry.js:25393)
    at HTMLOListElement.dispatch (jquery.min.js:2)
    at HTMLOListElement.v.handle (jquery.min.js:2)

Enhancement - Add a button to set Character Art for Actor

Currently, the only way to set character art to appear in the Actor Directory is to switch off of OGL, set it, then switch OGL back on. Suggestion to add a button above/below the name to add the art, strictly to the directory page, not to the sheet itself.

Note: The token art works just fine, just character art is impossible to access currently.

Feature request: Ammo selecting and attunement tracker

First of all thank you for the work so far and cant wait to see this sheet again in v10.
If this sheet gets updated, would it be possible to add the ammo selection feature found in tidy sheet as well as the Attunement Tracker also found on tidy sheets?

Keep up the good work 👍

Whetstone Compatibility

Convert from hardcoded color strings to Whetstone Global Variables with hard-coded backups.

The colour of the "always prepared" symbol in the spellbook tab has almost no contrast with the "prepared" symbol

The icons for a spell being "prepared" and "always prepared" have such little contrast between them that they are almost completely unreadable at a glance, even for a person with near 20/20 vision, and they are definitely failing to meet any kind of accessibility guidelines for contrasting colours.

People with any kind of vision impairment would likely not even realise there are two different colours even on close inspection. At a minimum, the two symbols should be much much more different colours, but even better, they should be different symbols.

image

Bug - Restore Inventory Icons functionality

Sometime between version 0.6.4 and 0.7.3 , the Add Icons to Inventory option stopped adding icons to most items outside of the actions box.

Screenshots from versions 0.6.4 and 0.7.3 , with no non-required modules installed.
0.6.4
OGL-064-default
0.7.3
OGL-073-default

If this was an intended change, could we get an additional option to have maximum icons?
Otherwise, I hope to see inventory icons return in future versions.

Feature - Add cheboxes for equip and unequip items on items panel

Environment Details

Foundry VTT Version: 0.7.9

Operating System: [Linux]

How Are You Using Foundry: [Linux,Native Application (Electron), Chrome]

Which Game System: Dungeons and Dragons 5th Edition, version 1.2.0

Modules Enabled?: yes

OS, Hosting, Browser (if applicable): Linux/Node/Chrome

Module Version : 0.6.4

Description Details

Add a checkbox for equip and unequip items like in the new version of the character sheet by roll 20.

img

Request: V11 & DnD5e 2.2.2 support

Big fan of this module. It's hugely useful for tables who come from Roll20 and the vertical sheet format is something that's really quite nice compared to the other sheet options.

Will there be any push to develop a version compatible with the newest version of Foundry and the 5e system? Apologies if this has been asked before, I'm unaware of any devblogs or discord channels that follow the dev and their work.

Compatibility Risk Flag

Currently on Foundry 0.7.9, D&D 5e Game System Version 1.2.4 and I'm getting a compatibility risk flag

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.