eltiare/carrierwave-vips

CarrierWave image processing powered by VIPS

carrierwave-vips's Issues

RMagic dependency

Hi.

Why is carrierwave-vips depends on RMagic? If this is not necessary, could you please remove it from gemspec?

Thanks

version bump

Hi,

You accepted a pull request from me a few months back. Would you mind bumping up the version number so that I don't have to have my gem file reference the master branch?

Thanks,

Chris

How to specify resizing kernel options

Hi there, first of all thank you for all the hard work in this gem. After replacing the standard minimagick resize I'm getting different (By a small but noticeable margin) quality results in jpg resizing, even after removing the sharpening mask.
Looking at https://github.com/eltiare/carrierwave-vips/blob/master/lib/carrierwave/vips.rb#L255 it seems resizing images uses either nearest or cubic filter, but ruby vips has more kernel options, with some more coming down the line (See jcupitt/libvips@3b1e3e1). Is there already a way to pass image resize kernel option and it just needs documenting? Or maybe I should tweak different options to get the quality I used to have with image magick?

Here is the image processed by imagemagick(check the ceiling):

Here is the image processed by vips, no sharpening mask:

Add a note about carrierwave-vips-benchmarks into README

Hello!

Would you mind adding a link to the https://github.com/stanislaw/carrierwave-vips-benchmarks?

Thanks.

Unable to convert to Webp

I see that the convert method is restricted to only jpegs and pngs allowed_formats = %w[jpeg jpg png]. Why not allow conversion to other file types?

carrierwave-daltonize

Hey Guys,

I just created a small gem that relies on carrierwave-vips and implements the daltonize algorithm for processing images for colour-blind people.

The actual algorithm was implemented by @jcupitt since I have extremely limited (read, nonexistent) experience with image processing.

However, I need help with a couple of small-ish items that might be easier for anybody with a bit more experience with ruby-vips. Namely:

1. I couldn't work out how to run the algorithm on a png image. It complains with VIPS error: im_disp2XYZ: input not 3-band uncoded char. I hope it's a trivial thing to convert / make this work.
2. Whilst the conversion for deuteranope, protanope and tritanope all work, I'm getting slightly different results than, say, on http://daltonize.appspot.com/ - looking at both the python and javascript imlementations, the last step includes some error correction, which is missing from @jcupitt's algorithm. This might be the reason for the difference?? any help would be much appreciated.

As I said, I have very limited image processing experience, but would really like to get this working, so images can be processed on any app using carrierwave to support colour-blind people. Thanks in advance!

update: I managed to apply some error correction, and it looks closer, but it's still not 100% the same as the results I'm getting using the javascript chrome-plugin or bookmarklet...

Python issue on travis

Looks like Ubuntu on Travis has just somehow modified its structure, it caused the blocking of our python hook (common with the one in ruby-vips). I will work on it a bit later.

Carrierwave vips won't process files with a number in the extension

Believe it or not, an image extension exists with a number in it. Hasselblad uses the "3FR" extension on their raw files.

Specifically in the process! method in vips.rb:

def process!(*)
  ret = super
  if @_vimage
    tmp_name = current_path.sub(/(\.[a-z]+)$/i, '_tmp\1')
    writer = writer_class.send(:new, @_vimage, @_format_opts)
    if @_strip
      writer.remove_exif
      writer.remove_icc
    end
    writer.write(tmp_name)
    FileUtils.mv(tmp_name, current_path)
    @_vimage = nil
  end
  ret
end

Line tmp_name = current_path.sub(/(\.[a-z]+)$/i, '_tmp\1') needs to be changed to tmp_name = current_path.sub(/(\.[[:alnum:]]+)$/i, '_tmp\1')

version bump

Hi,

You accepted a pull request from me a few months back. Would you mind bumping up the version number so that I don't have to have my gem file reference the master branch?

Thanks,

Chris

Configuration Options?

Howdy Mate,

I was wondering if you'd be opposed to having configuration block for the sharpen mask and resampling method? Example usage would be something like...

CarrierWave::Vips.configure do |c|
  c.sharpen_mask = [[ ... ]]
  c.resampling_method = :nohalo
end

I'd be happy to get it worked out (with tests) mostly just wondering if I should spend the time. As well as any other options you think might be useful.

Best,
Seve

P.S. Wanted to apologize for no tests on my previous issue, I've been way busy with launching an app to even look outside (but we launched and I can breathe again).

README error

In the README you mention the format process, when in fact it is convert

support auto_rotate

See libvips/ruby-vips#53

vipsthumbnail now has an autorotate feature, it might be possible to use part of that for ideas.

https://github.com/jcupitt/libvips/blob/master/tools/vipsthumbnail.c#L138

License?

I've recently created a image_processing library, which is just a set of higher-level processing helper methods. This library was originally spawned as a byproduct of Shrine, but the idea was that it's completely generic and usable in any code and with any uploading libraries. Currently I have only MiniMagick processing, but I want to add VIPS as well (and later RMagick).

Your great library would be an awesome "inspiration" for that kind of addition. However, I see that there is no license for this library, and a default license is "all rights reserved". If this was MIT licensed, I was thinking to adapt your code to my library and ruby-vips8, and say in the README that it was adapted from carrierwave-vips. Is that something you would be ok with?