eltongonc/react-soundcloud-explorer

A Javascript webapp based on Object-oriented Programming

react-soundcloud-explorer's Issues

Structure all your code

Place code logic in object method e.g. helpers.fancyLabels()

https://github.com/eltongonc/web_app_from_scratch/blob/33f6460efb8407f885f3abac104765d17f022959/week2/js/music.js#L8

Why are you mixing 'var' and 'let' in your SPA code?

It's not necessarily wrong, Im just curious why you would want that.

Please elaborate on your pros and cons

Faster than regular web applications

Why woud SPAs be faster? They aren't necessarily faster so it really matters why you think they could be.

Your can do more work in less hours.
I think the point is you have to do less work with frameworks. But you reach your functional goals quicker.

Router methods should be in routes object

https://github.com/eltongonc/web_app_from_scratch/blob/33f6460efb8407f885f3abac104765d17f022959/week2/js/music.js#L57

No description, website, or topics provided.

As per Github conventions, please include both a short description as well as a readme detailing the use of your repository.

Nice element creation pattern

I don't know if this is a standard way of generating HTML but it looks pretty cool.
Try to cut down on your whitespace though, there's waaay too many linebreaks.

Also, if you agree to use forEach in one instance, why not use it everywhere for consistency?

Superfluous code in SPA

https://github.com/eltongonc/web_app_from_scratch/blob/master/opdracht5-spa/assets/js/app.js#L24

A switch case might be more useful if you're working with a lot of possible values of one variable.
Also, consider using:
var myvariable =
instead of
var myVariable;
myVariable =

Try to place toplevel variables in relevant object methods

Only variables used in different methods should be in de main scope of the app

https://github.com/eltongonc/web_app_from_scratch/blob/33f6460efb8407f885f3abac104765d17f022959/week2/js/music.js#L3

Be consistent in the use of semicolons at the end of lines

https://github.com/eltongonc/web_app_from_scratch/blob/33f6460efb8407f885f3abac104765d17f022959/week2/js/music.js#L57

Your SPA could use more comments

Lines like these are pretty implicit and really need an explanation: https://github.com/eltongonc/web_app_from_scratch/blob/master/opdracht5-spa/assets/js/app.js#L9

Be consistent in the way you bind event handlers

addEventListener is prefered over on...

https://github.com/eltongonc/web_app_from_scratch/blob/33f6460efb8407f885f3abac104765d17f022959/week2/js/music.js#L57

apiCalls and data handling methods COULD be in their own object

Helper methods sounds more generic to me.

Check if data is all ready stored in localStorage before calling API?

https://github.com/eltongonc/web_app_from_scratch/blob/33f6460efb8407f885f3abac104765d17f022959/week2/js/music.js#L57