eluinhost/minecraft-auth

PHP Library for running a 'fake' Minecraft server that checks auth and kicks on connect

minecraft-auth's Issues

[Insight] User specific files should not appear in .gitignore

in .gitignore, line 14

.DS_Store is user-specific and should not appear in a project .gitignore. Consider adding it to the user global .gitignore instead.

/out
/bin

# OS generated files #
######################
.DS_Store
.DS_Store?
._*
.Spotlight-V100
.Trashes
Icon?

---

Posted from SensioLabsInsight

Stream Encryption

stream encryption should be ran on the entire client instead of per packet basis, move logic into a 'writedata' type function

[Insight] Usage of a function in loops should be avoided

in src/AuthServer/AuthServer.php, line 82

This loop uses a function. To avoid the overhead of executing the function n times, you should precalculate it before the loop.

        $connection->on('status_request', function(StatusResponsePacket $packet) {
            $this->emit('status_request', [$packet]);
        });

        $connection->on('close', function() use (&$connection) {
            for($i = 0; $i<count($this->clients); $i++) {
                /** @var $checkclient AuthClient */
                $checkclient = $this->clients[$i];
                //if we found our connection
                if($checkclient === $connection) {
                    //remove from array and reset the keys

---

Posted from SensioLabsInsight

Check with Mojang servers to fetch UUID e.t.c.

Using the yggdrasil library verify the accounts are valid.

Proper packet layout

Want to be able to expand packets easier if need be, need class structure

[Insight] The composer.json file should not raise warnings

in composer.json

License "GPLv3" is not a valid SPDX license identifier, see http://www.spdx.org/licenses/ if you use an open license.
If the software is closed-source, you may use "proprietary" as license.

---

Posted from SensioLabsInsight

Timeout connections

Currently a connection will be held open forever until the client disconnects or invalid data is sent or the server disconnects it. Need to implement a timeout for connections to force disconnect if no data sent.

Maybe related: UHC auth has been up for a couple of days and says 120 connections are 'open', was around 800 for last week

Add event listener

Need an event listener interface that you implement and add to the main class to get events for when someone logs in successfully

More than 1 client logged in at once will cause a recursive dependency error

Didnt come up during development due to xdebug being installed

How to kill a server?

Just wondering how to kill the server after being launcher?

expose the loop as a constructor argument

Add a way to choose the favicon + description